Random rock paper scissors game... errors in code...please help

[ramosariel]

this is for our project, and i'm still a beginner in programming, so guys I need some help. I want to create a random rock paper scissors game(player vs computer)... I tried many times to delete,recreate and edit my code but i still don't know how to get it right. This is my code:

#include <stdio.h>
#include <stdlib.h>
#include <conio.h>
#include <string>
#include <time.h>
using namespace std;

int main()
{
clrscr();
char b;
string words[3]={"rock","paper","scssors"}
srand(time(NULL));
words[rand()%3];
printf("Enter:");
scanf("%c",b);
for(int g=12;g<=21;g++)
{
if(words==b)
{
printf("Great!");
}
else{
printf("Wrong!");
}
getch();
return 0;
}
}


I know this looks funny to those who are pros but can you explain to me what's wrong with my code.

[weaknessforcats]

First, what is the type of the words array. It says string but there is no string type in C and the code does not look like C++? I suspect the array needs to be an array of char* since each element is itself a string.

Second, this does nothing:

words[rand()%3];

You need to relate this so something.

Third, the user enters a string so using %c in scanf is an error. %c is for a single char. You need %s for an entire string.


Fourth, I see:

if(words==b)
        {
           etc...

so I suspect you want to compare an element of the array to the value entered by the user. In C you compare strings using strcmp.

In addition, the program needs to pick one f the strings in the words array so
word[rand()%3] is the correct thing to do. You just need to compare this to what the user entered:

if(!strcmp(words[rand()%3],b))
        {
            ...they match....
 
           etc...

I hope this gets you along a bit further.

[donbock]

It looks intend to play 10 rounds of the game (12 to 21). If so, then the user should enter a new choice each round'(printf & scanf should be inside the loop).

[ramosariel]

thanks for replying weaknessforcats... I use TurboC which runs on Dosbox for windows 8.1 So here's my new code:

#include <stdio.h>
#include <stdlib.h>
#include <conio.h>
#include <string.h>
#include <time.h>

int main()
{
clrscr();
char b;
char words[]={'r','p','s','\0'};
srand(time(NULL));
printf("Enter:");
scanf("%s",b);
for(int g=12;g<=21;g++)
{
if(!strcmp(words[rand()%3],b)
{
printf(" %s\nGreat!",words);
}
else
{
printf("Wrong!");
}}
getch();
return 0;
}

Errors are:Cannot convert 'int' to 'const char *'
Type mismatch in parameter '_s1' in call to 'strcmp(const char *, const char *)'
Cannot convert 'int' to 'const char *'
Type mismatch in parameter '_s2' in call to 'strcmp(const char *, const char *)'

Here i am again asking you to help me beacause i don't fully understand what your point is, i'm sorry for being annoying. What i am trying to do is to make a rock,paper,scissors game which will be randomly picked by the computer to opposed the player's choice.

[donbock]

strcmp(words[rand()%3,b)
Both of these arguments are chars (a variety of integers), but strcmp expects strings (a variety of pointer). That's the mismatch that the compiler is complaining about. By the way, adding '\0' as the fourth element of words doesn't accomplish anything useful.

Comparing two chars is straightforward:
if( words[rand()%3] == b)
However, notice that 'R' will be considered different than 'r'. Is that what you want?

The user makes a single choice and then the program makes 10 choices. Is that what you want?

[ramosariel]

What I really want is the user could pick his/her own choice every round,whether it is small or capital letter,same as the program picks random choice every round.Also, I don't know how to reset the game automatically (not the whole game but repicking the user's choice again) after the user inputs an invalid letter. Um, can you send me a complete working algorithm that I can view so that I can analyze it and know my mistakes? As you can see, this code of mine isn't really complete and neat. Also,the real purpose of these rock-paper-scissors game is to identify whether the computer or the player will take the turn first on my bigger game project in TC... "Battleship". Please don't mind how many rounds I did put in this code 'cause this is just a sample or a training to me of how would I make a player and a computer take turns alternately. Sorry for some English grammatical error.