Problem creating a menu

[lostsoulofawolf]

void begin_menu(void)
{
    int choice;
 
    do
    {
    printf("English Draughts - Main Menu\n\n");
    printf("1. Play Game\n");
    printf("2. Display Winners\n");
    printf("3. Reset Scoreboard\n");
    printf("4. Quit\n");
    scanf("%d",&choice);
 
        switch (choice)
        {
        case '1' : play();
        break;
        case '2' : /*write function to do here */
        break;
        case '3' : /*write function to do here */
        break;
        case '4' : printf("Goodbye!\n");
        exit(0);
        break;
        default: printf("Please insert a correct choice.\n");
        break; 
        }
    } while (choice != 4);
}
 
void play(void)
{
    while(end != "n");
    {
    printf("Player Names\n\n");
    printf("Enter name for first player:\n");
    scanf("%s",&player_one);
    printf("Enter name for second player:\n");
    scanf("%s",&player_two);
    printf("Begin?(y to start, n to quit)\n");
    scanf("%c",&end);
    } 
    return;
}

When I try to run this the menu appears but if the user selects 1 and hits enter it responds with the default message and reloads the menu. If the user selects 4 and enter it shows the default message but successfully exits. Any idea what my problems are? Thanks!

[weaknessforcats]

You are using an int for the choice. A '1' is an ASCII character with an int value of 48. case '1' and case 48 equivalent.

[donbock]

The scanf format string on line 12 is "%d", which means return an integer value. The case statements (on lines 16,18,20,22) compare character values '1', '2', '3', and '4' against that integer value, so they will never match. However, the loop terminates if the scanned value is equal to the integer value 4, so the loop terminates if you enter "4".