What is wrong about the DrawEngine?

[Xillez]

Hey, it has been a while and I'm back with another problem with my c++ code...

This time it's about a header function (the constructor DrawEngine) in my DrawEngine.cpp file(the DrawEngine.h file that is included in this, is down below)...

Error: line 7, expected unqualified-id before "int"
Error: line 7, expected ")" before "int"

DrawEngine.cpp:

#ifndef DrawEngine_cpp
#define DrawEngine_cpp
 
#include <windows.h>
#include "DrawEngine.h"
 
DrawEngine(int xSize, int ySize)
{
    int screenWidth = xSize;
    int screenHeight = ySize;
 
    //set cursor vivbility to false at start up
}
DrawEngine::~DrawEngine()
{
    //set cursor visibility to true at end
}
 
int DrawEngine::createPlayer(int index, int skin, int idNumber)
{
    //set player model, index, skin and the idNumber of the user
}
 
int DrawEngine::drawPlayer(int index, int idNumber, int posx, int posy)
{
    //go to the correct location
    gotoxy(posx, posy);
    //draw the player
    //switch this out for a command to draw the player
}
 
void DrawEngine::gotoxy(int x, int y)
{
    HANDLE output_handle;
    COORD pos;
 
    pos.X = x;
    pos.Y = y;
 
    output_handle = GetStdHandle(STD_OUTPUT_HANDLE);
 
    SetConsoleCursorPosition(output_handle, pos);
}
#endif DrawEngine_cpp
 

DrawEngine.h:

#ifndef DrawEngine_H
#define DrawEngine_H
 
#include <windows.h>
 
class DrawEngine
{
public:
    int xSize;
    int ySize;
    DrawEngine(int xSize = 800, int ySize = 600);
    ~DrawEngine();
 
    int createPlayer(int index, int skin, int idNumber);
    void deletePlayer(int index);
 
    void erasePlayer(int posx, int posy);
    int drawPlayer(int index, int idNumber, int posx, int posy);
 
    void playerModel(int idNumber, int playerData, int playerId);
 
    void cursorVisibility(bool Visibility);
protected:
    int screenWidth, screenHeigth;
 
private:
    void gotoxy(int x, int y);
};
 
#endif
 

[Xillez]

The "DrawEngine::DrawEngine()" thing in DrawEngine.cpp? then I get the error: multiple definition of `DrawEngine::DrawEngine(int, int)'

[zmbd]

I had to rethink that, what is the namespace you are using?
Also something about how you have line7 doesn't read right... shouldn't be?

drawEngine::drawEngine(int index, int xSize, int ySize)

??

[Xillez]

The Namespace/the name of the class is "DrawEngine"

It's the same as

DrawEngine::DrawEngine(int index, int xSize, int ySize)

"...

It says that in the .cpp file I redefine it...

[zmbd]

I don's see where you have the name space set, ie:

using namespace std;

anywhere within your cpp

However, if you don't want my help.

[Xillez]

I want your help... you know how you can do for example

std::cout

where you have the "Namespace"::"Command/function"

I'm trying to do that since it gives me an error when I try to make it a namespace... but it doesn't work, maybe it's something wrong with my DrawEngine.h?

[zmbd]

you might also look at the start of the CPP:
where's the

#endif

Also...

#include "drawEngine.h"
#include <windows.h>
#include <iostream>
 
using namespace std;
 
DrawEngine::DrawEngine(int xSize, int ySize)
{
    screenWidth = xSize;
    screenHeight = ySize;
 
    //set cursor visibility to false
    cursorVisibility(false);

This is from the evilmonkey tutorial - yes?
That's where I picked this up from anyway.

[Xillez]

hehehe, yes, but it's modified...

forget the

#include <iostream>

forgot to delete that...

(where I copied from):http://www.3dbuzz.com/training/view/...ev/draw-engine

[weaknessforcats]

Is there still an issue here?

I saw this:

#ifndef DrawEngine_cpp
#define DrawEngine_cpp
etc...

Inclusion guards are not put in .cpp files because these files are never included.

The inclusion guard only protects against being included more than once in the same .cpp. This applies only to header files.

What is your issue with the namespace?

Namespaces are open-ended so unlike a struct there is no one place you can go to see what's in the namespace. If you code:

namespace Xillez
{
     class DrawEngine
     {
       etc...
}

you have Xillez::DrawEngine but you have no idea what else might be in this namespace.

[Xillez]

let's forget the #findef DrawEngine_Cpp thing because it's not giving me any errors, but the compiler says that I redefine the DrawEngine::DrawEngine(int index, int xSize, int ySize) in the DrawEngine.cpp.

How can I get rid of this error with the current code?

[weaknessforcats]

There is no error in the current code other than DrawEngine function must be DrawEngine::DrawEngine.

A couple of other functions need to return values but the functions don't appear coded yet so I made them return 0.

With those changes the code compiles and links for me.

The only way you are going to get a redefine on the DrawEngine::DrawEngine is if there a two bodies for the function. This usually happens when a .cpp file is in the project twice. Those #ifndef in the .cpp file lead me to believe you are using this file more than once in your project.

[Xillez]

yes, I am... when ever a game rescieves and update, it's going to print on the screen... but not so much that it crashes the game XD

So there isn't a problem in code execpt that?

[weaknessforcats]

You should never need to use the .cpp file more than once in a project. If you are doing that, then you have a function in disguise.

Go to all the places you use that .cpp code and replace that with a function call. Then have one instance of the .cpp in your project written as a function that is called from everywhere else.

I see other problems in the code but they relate to OO coding and design issues. Since the code works for you, there is no need for me to say anything. Working code trumps my opinions.

[Xillez]

ok, thanks man for the help XD