*HELP!!* Lottery prog.. numbers matching are repeating.

[mkannah]

Hi, i am a beginner. I, uh, should do a lottery that asks the user to input 5 numbers and then generate a 5 random numbers for the lotto results then after it should show what numbers matched, and how many numbers matched then shows the user his/her prize.

My problem is in my code, when i debug it, it shows which numbers matched, but it is repeating.

The question:

Lotto is a game in which winners are chosen by random drawing of numbers from among those who have paid money to participate. Write a program that will simulate the lotto game by asking the user five numbers (use array) and should generate a random number in the range of 0 to 9 (see example below) for each array element. The program will compare the corresponding elements in the two arrays and keep a count of the digits that matches. For instance, if the lottery array contains: 8 5 0 2 4 and the user array contains: 5 3 0 8 4, we can say that there are three numbers that matches. The program should display the random numbers stored in the lotto array and the matching digits. If all of the digits match, display a message proclaiming the user as a grand prize winner. Prizes are as follows:

5 Matching Digits – 500,000.00
4 Matching Digits – 100,000.00
3 Matching Digits – 20,000.00
2 Matching Digits – 500.00
1 Matching Digits – 10.00 (“Balik-Taya”)
0 Matching Digits – Try Again

-----------------------------------
Hint: use rand() for generating random numbers

#include <iostream>
#include <cstdlib>
#include <ctime>

int main()
{ int x = (rand()%10);
cout << x;}


My code goes like this:

// ETO NA TALAGA.cpp : Defines the entry point for the console application.
//
 
#include "stdafx.h"
#include <iostream>
#include <ctime>
#include <cstdlib>
#include <conio.h>
 
using namespace std;
 
int main()
{
    srand(time(0));
 
    int userinput[5], lottoresults[5];
    int counter=0;
    char ans=0;
 
    do{
//intro:
    cout<<"\t\t\n\n";
    cout<<"\t\t\tWelcome to the lucky lotto! \n\n";
    cout<<"\t\t\tLet's get started..\n\n";
    cout<<"\t\t\t  Instruction:\n\n";
    cout<<"\t\t\t  *Input five numbers between 0 and 9 only.\n\n";
 
//inputnum:
 
 
 
    for (int i=0; i<5; i++)
 
    {cout<<"\n\n\t\tPlease type your five lucky numbers for today (0-9): ";
    cin>>userinput[i];
 
    for(int a=1; a<=5; a++){ 
        while(userinput[i]==userinput[i-a])
        {cout<<"\n\n\tYou've already entered that number. Please type another number: ";
         cin>>userinput[i];}
        }
        while(userinput[i]<0||userinput[i]>10)
        {cout<<"\n\n\tEnter numbers between 0-9 only. Please type another number: ";
        cin>>userinput[i];}
    }
 
    for (int i=0; i<5; i++)
 
    system("cls");
 
//results:
 
    for (int x=0; x<40;x++){
    cout<<"\n\n\t\t\tGenerating numbers.... \n\n";
    cout<<"\n\n\t\t\tPlease wait....\n\n";
    for (int x=0;x<1;x++)
    cout<<" ";};
    system("cls");
    cout<<endl;
 
 
    cout<<"\n\n\t\t\tLOTTO WINNING NUMBERS: ";
    for(int lot=0;lot<5; lot++){
    lottoresults[lot]= (rand()%10);
    cout<<lottoresults[lot]<<" ";
    }
 
 
    cout<<"\n\n\t\t\tUSER NUMBERS: ";
    for (int i=0; i<5; i++)
    {cout<<userinput[i]<<" ";}
 
//matcher:
 
    int matchnum[5];
    for(int x = 0; x < 5; x++)
        for(int y = 0; y < 5; y++)
            if(userinput[x] == lottoresults[y])
                counter++;
 
    int o=0;
    for(int x = 0; x < 5; x++)
        for(int y = 0; y < 5; y++){
            if(userinput[x] == lottoresults[y]){
                matchnum[0] = userinput[x];
                ;o++;}
        }
 
    cout<<endl;
    cout<<"\n\n\t\t\tMATCHING NUMBERS: ";
 
    int x = 5;
    for(int y=0; y<5;y++){
        if(y>counter-1)
            break;
            x--;
        cout<<matchnum[0]<<" ";}
        cout<<"\n";
 
 
    cout<<endl;
         if (counter<2)
             cout<<"\n\n\t\t\tThere are "<<counter<<" matching digit. \n.";
         else
             cout<<"\n\n\t\t\tThere are "<<counter<<" matching digits. \n";
 
 
    cout<<"\n\n\t\t\tPRIZE: ";
    switch(counter){
    case 0:
        cout<<"Sorry, none of your digits matched.\n";
        cout<<"\t\t\t\tBetter luck next time!\n\n\t\t\t";
        break;
    case 1:
        cout<<"PHP10.00 (Balik-Taya)\n\n";
        break;
    case 2:
        cout<<"PHP500.00.\n\n";
        break;
    case 3:
        cout<<"PHP20,000.\n\n";
        break;
    case 4:
        cout<<"PHP100,000.\n\n";
        break;
    case 5:
        cout<<"All of your digits matched the lotto results.\n";
        cout<<"\t\t\t\tYou won PHP500,000.\n\n";
        break;
    }
 
    if(counter!= 0)
        for(int x = 0; x < 1; x++){
            cout<<"\n\n\t\t\tCONGRATULATIONS!!\n\n";
            cout<<"\n\n\t\t";
        for(int y = 0; y < 1; y++)
        ;}
        system ("pause");
        system("cls");
 
 
        cout<<endl<<"\n\t\t\tDo you want to play again [Y/N]? ";
        cin>>ans;
 
        while((ans != 'Y' && ans != 'y')&&(ans != 'N' && ans != 'n')){
            cout<<endl<<"\n\t\tPlease Enter Y or N only!\n\n\t\t";
            cout<<"\t\tDo you still want to play again?: ";
            cin>>ans;
 
        }
 
        system("CLS");
 
    }while(ans=='Y'||ans=='y');
    cout<<"\n\n\n\n\n\t\t\tTHANK YOU FOR PLAYING!\n\n\t";
    cout<<"\t\t\Hope you enjoyed.\n\n\t";
    cout<<"\t\tPlay again next time to win for more!\n\n\t\t\t";
 
cin.sync();
cin.get();
return 0;
}
 

THANK YOU VERY MUCH FOR THOSE WHO'LL ANSWER, i'm so in need of help, and this needs to be submitted on or before this monday, which is september 9 2013.

[weaknessforcats]

Exactly what is repeating?

[mkannah]

What repeating here is, the numbers that matched the user's input and the lotto results. Try to run this, then you'll see. Please help me, how to remove the repeating matched numbers. Thanks.

[weaknessforcats]

Anytime you do a rand() you can get the same number more than once.

So, when you generate your lotto number you need to check if you have already received that number, and if so, call rand() again until you get a number you have not received.

The easiest thing to do is add an array of 10 int as an edit mask. Initialize each element of this array to 0.

You now map your rand() %10 number, which must be between 0 and 9 to this 10 int array. If your rand()%10 is 5, then look at the array[5]. If array[5] is 0 you have not received a 5 so change array[5] to 1.

On the other and, if array[5] is 1, then you have already received a 5 and you should call rand()%10 again.

[mkannah]

Thank you very much. What i exactly mean is, the matching numbers. For example.
The output will be like this:

LOTTO WINNING NUMBERS: 6 7 8 4 1
USER NUMBERS: 4 8 0 9 1
MATCHING NUMBERS: 4 1 1 
PRIZE: PHP20,000
CONGRATULATIONS!!
 
 

And there, the matching numbers is repeating. Help me please how to get rid of that.

[weaknessforcats]

You have some very odd code here:

    int o=0;
    for(int x = 0; x < 5; x++)
        for(int y = 0; y < 5; y++){
            if(userinput[x] == lottoresults[y]){
                matchnum[0] = userinput[x];
                ;o++;}
        }
 

You are using a variable named o and you are doing an o++ but you never use o. Instead you use 0 (zero).

Try to avoid using variables named o or l because they look like 0 and 1.

[mkannah]

Ah, i see, thanks. So, what do you think the overall code should be? I am confused, thanks.

[weaknessforcats]

I would use two loops. The outerloop runs from userinput[0] to userinput[4]. The inner loop runs from lottoresults[0] to lottoresults[4] and in this inner loop you match userinput[x] to every element of lottoresults. If you get a match, increment a balance counter.

After the two loops complete, the balance counter should contain the number of matches.