Why does my benefit class run in my program without me calling it.

[Calek916]

The problem that I am having is when I run my program my Benefit class starts running and I have not called it my main but for some reason it is running first instead of my Employee class. This whole program works fine except for the benefit class starts before my Employee class. Can you help me figure it out.

#include <iostream>
#include <stdlib.h>
#include <string>
#include <iomanip>
 
using namespace std;
 
class benefit
{
private:
string healthInsurance;
double lifeInsurance;
int vacationDays;
string PPO;
string HMO;
public:
benefit();
benefit(string health, double life, int vacation);
void displayBenefit();
string getHealthInsurance();
void setHealthInsurance(string healthIns);
double getLifeInsurance();
void setLifeInsurance(double lifeIns);
int getVacationDays();
void setVacationDays(int vacation);
};
class Employee : public iEmployee
{
private:
string firstName;
string lastName;
char gender;
int dependents;
double annualSalary;
benefit Benefit;
public:
Employee();
Employee(string first, string last, char gen, int dep, double salary);
double calculatePay();
void displayEmployee();
string getFirstName();
void setFirstName(string first);
string getLastName();
void setLastName(string last);
char getGender();
void setgender(char gen);
int getDependents();
void setDependents(int dep);
void setDependents(string dep);
double getAnnualSalary();
void setAnnualSalary(double salary);
void setAnnualSalary(string salary);
static int getNumEmployees();
static int numEmployees;
};
class iEmployee abstract
{
public:
virtual double calculatePay() = 0;
};
void displayDivider(string outputTitle)
{
cout << "**************** " + outputTitle + " ****************" << endl;
}
Employee::Employee()
{
firstName = "Not Given";
lastName = "Not Given";
gender ='U';
dependents = 0;
annualSalary = 20000;
 
cout << "Please Enter The Employee's First Name: ";
cin >> firstName;
cout << "Please Enter The Employee's Last Name: ";
cin >> lastName;
cout << "Please Enter The Employee's Gender: ";
cin >> gender;
 
if (gender == 'M' || gender == 'm')
gender = 'M';
else if (gender == 'F' || gender == 'f')
gender = 'F';
else
gender = 'U';
 
cout << "Please Enter The Employee's Dependent Count: ";
cin >> dependents;
 
while (dependents < 0 || dependents > 10)
{
cout << "Please Enter A Number Between 0 And 10: ";
cin >> dependents;
}
cout << "Please Enter The Employee's Yearly Salary: ";
cin >> annualSalary;
 
while (annualSalary < 20000 || annualSalary > 150000)
{
cout << "Please Enter The Employee's Annual Salary Between 20,000 And 150,000: ";
cin >> annualSalary;
}
 
}
Employee::Employee(string first, string last, char gen, int dep, double salary)
{
firstName = first;
lastName = last;
gender = gen;
dependents = dep;
annualSalary = salary;
}
benefit::benefit(string health, double life, int vacation)
{
healthInsurance = health;
lifeInsurance = life;
vacationDays = vacation;
}
string Employee::getFirstName()
{
return firstName;
}
void Employee::setFirstName(string first)
{
firstName = first;
}
string Employee::getLastName()
{
return lastName;
}
void Employee::setLastName(string last)
{
lastName = last;
}
char Employee::getGender()
{
return gender;
}
void Employee::setgender(char gen)
{
gender = gen;
}
int Employee::getDependents()
{
return dependents;
}
void Employee::setDependents(int dep)
{
dependents = dep;
}
void Employee::setDependents(string dep)
{
dependents = atoi(dep.c_str());
}
double Employee::getAnnualSalary()
{
return annualSalary;
}
void Employee::setAnnualSalary(double salary)
{
annualSalary = salary;
}
void Employee::setAnnualSalary(string salary)
{
annualSalary = atof(salary.c_str());
}
double Employee::calculatePay()
{
return annualSalary/52;
}
int Employee::getNumEmployees()
{
return numEmployees;
}
 
string benefit::getHealthInsurance()
{
return healthInsurance;
}
void benefit::setHealthInsurance(string healthIns)
{
healthInsurance = healthIns;
}
double benefit::getLifeInsurance()
{
return lifeInsurance;
}
void benefit::setLifeInsurance(double lifeIns)
{
lifeInsurance = lifeIns;
}
int benefit::getVacationDays()
{
return vacationDays;
}
void benefit::setVacationDays(int vacation)
{
vacationDays = vacation;
}
 
void Employee::displayEmployee()
{
cout << "Employee Information" << endl;
cout << "_________________________________________________ __________________________________________" << endl;
cout << endl;
cout << "First Name: " << firstName << endl;
cout << "Last Name: " << lastName<< endl;
cout << "Gender: " << gender << endl;
cout << "Dependent(s): " << dependents << endl;
cout << "Annual Salary: " << setprecision(2) << showpoint << fixed << annualSalary << endl;
cout << "Weekly Pay: " << calculatePay() << endl;
}
void benefit::displayBenefit()
{
cout << "Health Insurance Type: " << healthInsurance << endl;
cout << "Life Insurance Amount: " << lifeInsurance << endl;
cout << "Vacation Days: " << vacationDays << " days" << endl;
}
int Employee::numEmployees = 0;
int main()
{
 
int numEmpl;
 
cout << "Welcome to your first Object Oriented Programming -- Employee ClassCIS247C, Week 2 Lab" << endl;
cout << "NAME: Brandon Braaten" <<endl;
 
displayDivider("Employee One");
 
 
Employee one;
Employee::numEmployees++;
 
one.displayEmployee();
 
numEmpl = Employee::getNumEmployees();
cout << "--- Number Of Employee Object Created ---" << endl;
cout << "Number Of Employees: " << numEmpl << endl;
 
displayDivider("Employee Two");
 
Employee two("Mary", "Noia", 'F', 5, 24000.00);
Employee::numEmployees++;
 
two.displayEmployee();
 
numEmpl = Employee::getNumEmployees();
cout << "--- Number Of Employee Object Created ---" << endl;
cout << "Number Of Employees: " << numEmpl << endl;
 
cout << "The end of the CIS 247C Week 6 iLab." << endl;
 
system ("pause");
return 0;
}

[Banfa]

What is your evidence for the benefit class "running" first?

The code you have post does not compile which makes it hard to see what is happening when it runs. Post the code you are compiling so we can compile it and then see what happens when it is run if you are getting a problem at runtime.

[Calek916]

@Banfa
Here is a copy of my code.I just ran it and it is working.

#include <iostream>
#include <stdlib.h>
#include <string>
#include <iomanip>
 
using namespace std;
 
// ========== Non-class Methods ==========
void displayDivider(string outputTitle)
{
    cout << "**************** " + outputTitle + " ****************" << endl;
}
 
 
 
 
 
// ========== Class ==========
class benefit
{
private:
    string healthInsurance;
    double lifeInsurance;
    int vacationDays;
    string PPO;
    string HMO;
public:
    benefit();
    benefit(string health, double life, int vacation);
    void displayBenefit();
    string getHealthInsurance();
    void setHealthInsurance(string healthIns);
    double getLifeInsurance();
    void setLifeInsurance(double lifeIns);
    int getVacationDays();
    void setVacationDays(int vacation);
 
    void BenefitInput(); // earl 
};  // class benefit
 
 
benefit::benefit(string health, double life, int vacation)
{
    healthInsurance = health;
    lifeInsurance = life;
    vacationDays = vacation; 
}
 
string benefit::getHealthInsurance()
{
    return healthInsurance;
}
void benefit::setHealthInsurance(string healthIns)
{
    healthInsurance = healthIns;
}
double benefit::getLifeInsurance()
{
    return lifeInsurance;
}
void benefit::setLifeInsurance(double lifeIns)
{
    lifeInsurance = lifeIns;
}
int benefit::getVacationDays()
{
    return vacationDays;
}
void benefit::setVacationDays(int vacation)
{
    vacationDays = vacation;
}
 
void benefit::displayBenefit()
{
    cout << "Health Insurance Type: " << healthInsurance << endl;
    cout << "Life Insurance Amount: " << lifeInsurance << endl;
    cout << "Vacation Days: " << vacationDays << " days" << endl;
}
 
 
benefit::benefit()
{
    cout << "Please Enter the Health Insurance Type PPO or HMO: ";
    cin >>  healthInsurance;
    if (healthInsurance == "PPO" || healthInsurance == "ppo")
            healthInsurance = "PPO";
    else if (healthInsurance == "HMO" || healthInsurance == "hmo")
            healthInsurance = "HMO";
    else
            healthInsurance = "No Health Insurance";
 
    cout << "Please Enter the Life Insurance Amount: ";
    cin >> lifeInsurance;
 
    while (lifeInsurance < 0 || lifeInsurance > 1000000)
    {
        cout << "Please Enter A Dollar Amount Between 0 And 1000000: ";
        cin >> lifeInsurance;
    }
 
    cout << "Please Enter the Amount of Vacation Days: ";
    cin >> vacationDays;
 
    while (vacationDays < 0 || vacationDays > 30)
    {
        cout << "Please Enter Vacation days Between 0 And 30: ";
        cin >> vacationDays;
    }
}  // benefit::benefit()
 
 
 
 
// ========== Class ==========
class iEmployee abstract
{
public:
    virtual double calculatePay() = 0;
};  // class iEmployee
 
 
 
 
// ========== Class ==========
class Employee : public iEmployee
{
private:
    string firstName;
    string lastName;
    char gender;
    int dependents;
    double annualSalary;
    benefit Benefit;
public:
    Employee();
    Employee(string first, string last, char gen, int dep, double salary);
    double calculatePay();
    void displayEmployee();
    string getFirstName();
    void setFirstName(string first);
    string getLastName();
    void setLastName(string last);
    char getGender();
    void setgender(char gen);
    int getDependents();
    void setDependents(int dep);
    void setDependents(string dep);
    double getAnnualSalary();
    void setAnnualSalary(double salary);
    void setAnnualSalary(string salary);
    static int getNumEmployees();
    static int numEmployees;
};  // class Employee
 
 
 
Employee::Employee()
{
    firstName = "Not Given";
    lastName = "Not Given";
    gender ='U';
    dependents = 0;
    annualSalary = 20000;
 
    cout << "Please Enter The Employee's First Name: ";
    cin >> firstName;
    cout << "Please Enter The Employee's Last Name: ";
    cin >> lastName;
    cout << "Please Enter The Employee's Gender: ";
    cin >> gender;
 
    if (gender == 'M' || gender == 'm')
        gender = 'M';
    else if (gender == 'F' || gender == 'f')
        gender = 'F';
    else
        gender = 'U';
 
    cout << "Please Enter The Employee's Dependent Count: ";
    cin >> dependents;
 
    while (dependents < 0 || dependents > 10)
    {
        cout << "Please Enter A Number Between 0 And 10: ";
        cin >> dependents;
    }
    cout << "Please Enter The Employee's Yearly Salary: ";
    cin >> annualSalary;
 
    while (annualSalary < 20000 || annualSalary > 150000)
    {
        cout << "Please Enter The Employee's Annual Salary Between 20,000 And 150,000: ";
        cin >> annualSalary;
    }
 
}  // Employee::Employee()
 
 
Employee::Employee(string first, string last, char gen, int dep, double salary)
{
    firstName = first;
    lastName = last;
    gender = gen;
    dependents = dep;
    annualSalary = salary;
}
 
 
string Employee::getFirstName()
{
    return firstName;
}
void Employee::setFirstName(string first)
{
    firstName = first;
}
string Employee::getLastName()
{
    return lastName;
}
void Employee::setLastName(string last)
{
    lastName = last;
}
char Employee::getGender()
{
    return gender;
}
void Employee::setgender(char gen)
{
    gender = gen;
}
int Employee::getDependents()
{
    return dependents;
}
void Employee::setDependents(int dep)
{
    dependents = dep;
}
void Employee::setDependents(string dep)
{
    dependents = atoi(dep.c_str());
}
double Employee::getAnnualSalary()
{
    return annualSalary;
}
void Employee::setAnnualSalary(double salary)
{
    annualSalary = salary;
}
void Employee::setAnnualSalary(string salary)
{
    annualSalary = atof(salary.c_str());
}
double Employee::calculatePay()
{
    return annualSalary/52;
}
int Employee::getNumEmployees()
{
    return numEmployees;
}
 
void Employee::displayEmployee()
{
    cout << "Employee Information" << endl;
    cout << "___________________________________________________________________________________________" << endl;
    cout << endl;
    cout << "First Name: " << firstName << endl;
    cout << "Last Name: " << lastName<< endl;
    cout << "Gender: " << gender << endl;
    cout << "Dependent(s): " <<  dependents << endl;
    cout << "Annual Salary: " << setprecision(2) << showpoint << fixed << annualSalary << endl;
    cout << "Weekly Pay: " << calculatePay() << endl;
    cout << endl;
    cout << "Benefit Information" << endl;
    cout << "___________________________________________________________________________________________" << endl;
    Benefit.displayBenefit();
 
    cout << endl;
}
 
 
int Employee::numEmployees = 0;
 
 
 
 
 
// ========== Main ==========
int main()
{
 
    int numEmpl;
 
    cout << "Welcome to your first Object Oriented Programming -- Employee ClassCIS247C, Week 2 Lab" << endl;
    cout << "NAME: Brandon Braaten" <<endl;
 
    displayDivider("Employee One");
 
 
    Employee one;
    Employee::numEmployees++;
 
    one.displayEmployee();
 
    numEmpl = Employee::getNumEmployees();
    cout << "--- Number Of Employee Object Created ---" << endl;
    cout << "Number Of Employees: " << numEmpl << endl;
 
    displayDivider("Employee Two");
 
    Employee two("Mary", "Noia", 'F', 5, 24000.00);
    Employee::numEmployees++;
 
    two.displayEmployee();
 
    numEmpl = Employee::getNumEmployees();
    cout << "--- Number Of Employee Object Created ---" << endl;
    cout << "Number Of Employees: " << numEmpl << endl;
 
    cout << "The end of the CIS 247C Week 6 iLab." << endl;
 
    system ("pause");
 
    return 0;
}  // main()

[weaknessforcats]

You have created an Employee objct in main(). One of the data members of Employee is a benefit. Therefore, a benefit object needs to be created in order to create your Employee.

[Banfa]

The code seems to compile an work.

It is not clear what you mean by "Why does my benefit class run in my program without me calling it" if you can explain in more detail what your query is we can answer it, assuming that weaknessforcats hasn't already told you what you need to know.

[Calek916]

Hey Banfa,
Thank you for responding. Here is what I mean as you can see after running my program the first question that is asked is "Please Enter the Health Insurance type PPO or HMO:", then Life insurance, and then vacation days. Health Insurance, life insurance, and vacation days are in my benefit class. If you take a look at my main you can see that I do not have anything calling my benefits class. I have Employee one to call my Employee class in my main. I have had several people look at my code, even my professor, and no one can figure out why. I am hoping that you will be able to see where I went wrong. What should be happening when I run my program is that I should be asking for your first name, last name, etc. Then the question about your health insurance, life insurance and vacation days.

[Banfa]

OK it is as weaknessforcats says your Employee class has a benefit class as a data member. When a class is constructed the following happens

1. Memory is allocated
2. The constructors of all the base classes of the class is called
3. All the data members of the class are constructed, their constructors are called
4. The classes constructor is call

It is important that things happen in this order so that when the constructor of your class is running the class is complete (all base classes and data members constructed)

Since benefit is a data member of Employee when you construct an instance of the Employee class it constructs an instance of the benefit class before running the Employee constructor. Since the benefit class constructor outputs to the screen and requests input from the user you see that first.

Generally it is not very good practice to put so much processing inside a constructor, the constructor should do the minimum possible to make a working class that you can call methods on.

[Calek916]

Thank you for your help it is now working. If I need anymore help I will be back.