Error in integer output!

[Lewis Mbuthia]

I wrote this simple code after introducing myself to the gematria pattern in the Hebrew language.
The program is supposed to input Hebrew phrases and return the integer values of each character.
It compiles great but the output has a series of integers, namely the number 40 at the end of the output process, which has no corresponding character input.
Can anyone suggest a way to remove this error since the output MAY be included in further processes.Any help is highly appreciated.
Here's the code.

 
# include <iostream>
# include <string.h>
using namespace std;
 
int main()
{
    int g1=1000,g2=0,dec=0;
    string heb;
    cout<< "This is the hebrew letter scheme \t";
    cout<< "A-Alef \t";
    cout<< "B-Beth \t";
    cout<< "G-Gyml \t";
    cout<< "D-Dalet \t";
    cout<< "H-He \t";
    cout<< "V-Vau \t";
    cout<< "Z-Zain \t";
    cout<< "C-Chet \t";
    cout<< "T-Teth \t";
    cout<< "Y-Yod \t";
    cout<< "K-Kaf \t";
    cout<< "L-Lamed \t";
    cout<< "M-Mem \t";
    cout<< "N-Nun \t";
    cout<< "S-Samek \t";
    cout<< "I-Ain \t";
    cout<< "P-Pey \t";
    cout<< "O-Tsadhe \t";
    cout<< "Q-Qof \t";
    cout<< "R-Resh \t";
    cout<< "E-Shin \t";
    cout<< "F-Tav \t";
    cout<< "k-final Kaf\t";
    cout<< "m-final Mem\t";
    cout<< "n-final Nun\t";
    cout<< "p-final Pey\t";
    cout<< "o-final Tsadhe\t";
    cout<< "Input Hebrew phrase->\t";
 
    getline(cin,heb);
 
    cout<< "These are the results-> \n";
 
    while (g2<=g1)
    {
      switch (heb[g2])
      {    
       case 'A':
       dec=1000; 
       break;
       case 'B': 
       dec=2; 
       break;
       case 'G':
       dec=3; 
       break;
       case 'D':
       dec=4; 
       break;
       case 'H':
       dec=5; 
       break;
       case 'V':
       dec=6; 
       break;
       case 'Z':
       dec=7; 
       break;
       case 'C':
       dec=8; 
       break;
       case 'T':
       dec=9; 
       break;
       case 'Y':
       dec=10; 
       break;
       case 'K':
       dec=20; 
       break;
       case 'L':
       dec=30; 
       break;
       case 'M':
       dec=40; 
       break;
       case 'N':
       dec=50; 
       break;
       case 'S':
       dec=60; 
       break;
       case 'I':
       dec=70; 
       break;
       case 'P':
       dec=80; 
       break;
       case 'O':
       dec=90; 
       break;
       case 'Q':
       dec=100; 
       break;
       case 'R':
       dec=200; 
       break;
       case 'E':
       dec=300; 
       break;
       case 'F':
       dec=400; 
       break;
       case 'k':
       dec=500; 
       break;
       case 'm':
       dec=600; 
       break;
       case 'n':
       dec=700; 
       break;
       case 'p':
       dec=800; 
       break;
       case 'o':
       dec=900; 
       break;
       default: 
       dec=0;
       break;         
      }
     g2++;
 
       if (dec>=1)
 
        {
         cout << dec << endl;
        }
 
    }
   system("PAUSE");
}
 
 
 

[mac11]

What is the reasoning behind that loop condition? (g2 <= g1) -- Are you sure you need to loop 1000 times? Maybe run your loop based on the size of the input string.

Also, you should change your #include <string.h> to #include <string>

[donbock]

I think mac11 has given you the clue to the spurious numbers at the end of your output.

That's quite a switch statement! Personally, I would have constructed a big lookup table to keep the executable code small. For example, here's the lookup table:

struct gematria {
   int c;
   int value;
   char *name;
   }
 
gematria table[] = {
   { 'A', 1000, "Alef" },
   ...
   { 'o',  900, "final Tsadhe" }
};

This table eliminates the long list of cout's to print the index and it eliminates the big switch. I prefer lookup tables because they let me keep related information close together, such as the three pieces of information: 'A' is Aleph and has a value of 1000.

[Lewis Mbuthia]

Thanks guyz I rewrote the code and the error is gone.