stack trace points to uninit data in below routine

[tvnaidu]

I have memory leak issue, I found from stack trace that "sendto" points to uninitialised data in the below routine, does vsnprintf cause this error?


syscall param socketcall.sendto(msg) points to uninitialised bytes(s)
at 0x43B731E: sendto (in /lib/libpthread-2.5.so)
by 0x439A019: adpModuleDebug (in /pfrm/lib/libi386adaptos.so)

f (!pEntry || (pEntry->debugLevel & debugLevel))
        {
        int len;
        char buf[256];
 
        len = sprintf(buf, "%s:%d:", function, line);
        va_start (arg, pszFormat);
        vsnprintf (&buf[len], 255-len, pszFormat, arg);
        va_end (arg);
        printf ("%s", buf);
        }

[RedSon]

Look, its not very difficult to put your code inside of code tags. You've posted over 200 messages to this board, you should know by now.

The code tag button is the little one that looks like a hash mark. USE IT!

[donbock]

I don't see anything in the code snippet that involves threads or sockets. Do you use threads or sockets elsewhere in your program?

Notice that sprintf returns a negative value if it fails. As a general principle you should trap this error return before using the return value to index into the buffer. This is unlikely to be your problem.

By the way, as a general principle it would have been better to use snprintf rather than sprintf. This is unlikely to be your problem. If you use snprintf then not only might the return value be negative, it might also be larger than the size of your buffer -- you should trap that condition too.

[tvnaidu]

sorry for that, it won't repeat again

[tvnaidu]

I compiled with -g option, basically there is one IOCTL call in the above code with compilation switch, whcih calls sendto call, I am adding that code below:

[ctags]

    UMI_REQ_INFO *  pUmiReq;
    unsigned int    reqBufSize;
 
 
 pUmiReq = (UMI_REQ_INFO *)pBuf;
        pUmiReq->cmd    = cmd;
        pUmiReq->srcId  = pSrcCtx->myId;
        pUmiReq->reqOpt = reqOpt;
        pUmiReq->reqId  = reqId;
        pUmiReq->req    = 1;
 
        if (sendto (pSrcCtx->sockFd, pUmiReq, reqBufSize,
                    0, (struct sockaddr *) &destId, sizeof(UMI_COMP_ID)) == -1)
            {

[/ctags]

[RedSon]

The code tags are [ code] and [/code]

not "ctags". Use the little hash button it will add them in for you.

[tvnaidu]

thank you sir, I did long back, forgot

[tvnaidu]

I did memset pUmiReq to zero before filling stuff, but still it didn't fix "uninitialised data", any idea what is the issue with the above sendto call?. thanks.