help with errors-confused

[tsushio]

hello,i'm a student and i'm in my first year.

i had an assignment using borland c++ and this is what i made

#include <iostream.h>
#include <conio.h>

int main ()
{
int number,odd,even,small,big;


odd = 0;
even = 0;
small = number;
big = number;

cout << "Enter a number: \n";
cin >> number;

while (number != 0)
{
number == 0;
{

if (number %2 = 0)
even = even + 1;
else
odd = odd + 1;
}
{
if (number < small)
number = small;
else
{
if (number > big)
big = number;
else
endl;
}
}

}

cout << "\nThe biggest number is " << big << endl;
cout << "\nThe smalest number is " << small << endl;

cout << "\nThere is " << even << " even numbers." << endl;
cout << "\nThere is " << odd << " odd numbers." << endl;



getch ();

return 0;

}

but it had these errors:

cpp (11,11) : possible use of 'number' before definition
cpp (21,23) : Lvalue required

i tried looking up on the internet on how to fix these errros but somehow i got more confused.

could someone please help me..

on how to fix those errors and explain to me what is 'Lvalue' and 'possible use of 'number' before definition' mean.

p/s: sorry if my english is not good.and if you could, please make the explanation in simple english.^_^

[donbock]

"possible use of 'number' before definition"
This message typically means that you are reading a variable (in this case, 'number') before anything was written to it.

"Lvalue" or "L-value" refers to something that either could or actually does appear on the left side of an equals sign. (This is a simplified definition; it is actually more complicated than that. You should google the term for more accurate information.)

"Lvalue required"
This message typically means that you have a non-Lvalue on the left side of an equals sign. (As you might expect, a non-Lvalue is called an "Rvalue" or "R-value".)

For error message "cpp (n1,n2) text", the error occurred near line n1 of your source code. I don't know what n2 means.

Remember that a single equals sign (=) is used to assign the value on the right side to the variable on the left side; while a double equals sign (==) is used to test whether two values are equal.

You have unusual bracing style.

You probably want to acquire a new value for 'number' every time you pass through the loop. Be careful to keep the proper relative order of getting a new 'number' value and testing for loop termination.

[whodgson]

This compiles:
//19/02/09 15:28

#include <iostream>
#include <conio.h>
using namespace std;
 
int main ()
{
int number,odd=0,even=0,small,big;
 
small = number;
big = number;
 
cout << "Enter a number: \n";
cin >> number;
 
//while (number != 0)
//{
//number == 0;
//{
 
if (number %2 == 0)even = even + 1;
else odd = odd + 1;
 
if (number < small)number = small;
else if (number > big)big = number;
else cout<<endl;
 
cout << "\nThe biggest number is " << big << endl;
cout << "\nThe smalest number is " << small << endl;
 
cout << "\nThere is " << even << " even numbers." << endl;
cout << "\nThere is " << odd << " odd numbers." << endl;
 
getch ();
 
return 0;
 
}

....and outputs this:
/*Enter a number:
47

The biggest number is 47

The smalest number is 2

There is 0 even numbers.

There is 1 odd numbers.*/

[JosAH]

@whodgson
But it doesn't run correctly:

1) you're assigning uninitialized numbers to some variables.
2) your loop is bogus.
3) check the output: where does that '2' come from?

Please check and double check your code before you post it.

kind regards,

Jos

[tsushio]

thank you for the responds.

as for my bracing style, i dont know what to say because that's what our lecturer taught us and even in our textbook (the author is one of our lecturer) stated the same bracing style.

the errors had been fixed and compiling it is a success.Thank you for helping.

but there's another problem.

after editing:

#include <iostream.h>
#include <conio.h>

int main ()
{
int number,even = 0,odd = 0,small,big;



cout << "\nInput an integer, one at a time, and press enter.\n";
cout << "Enter the numbers as many as you want.\n";
cout << "Enter integer 0 to stop.\n";
cout << "Enter number: \n";
cin >> number;

small = number;
big = number;

while (number != 0)
{
number == 0;
{
if ((number % 2) == 0)
even = even + 1;
else
odd = odd + 1;

if (number < small)
number = small;
else
{
if (number > big)
big = number;
else
endl;
}

}

}

cout << "\nThe biggest number is " << big << endl;
cout << "\nThe smallest number is " << small << endl;

cout << "\nThere is " << even << " even numbers." << endl;
cout << "\nThere is " << odd << " odd numbers." << endl;

getch ();
return 0;

}


---------

when i run this program,

this came out:


Input an integer, one at a time, and press enter.
Enter the numbers as many as you want.
Enter integer 0 to stop.
Enter number:
8

------

but after i type the number '8', i cant enter another number.means typing any number caused no effect to the output.what should i do to fix it?

--------

[donbock]

Regarding brace style ... I was referring to the open-brace that immediately precedes the first "if" statement (and the matching close-brace). What do you intend to accomplish with this pair of braces? I'm not saying this is a mistake; I'm only concerned that you're trying to accomplish something that isn't getting done.

Regarding entering multiple numbers ... variable 'number' is an int. That means "cin >> number" will extract one numeric value from stdin and assign it to 'number'. Then you enter the loop ...

[tsushio]

ahh.okay.get it.

i just remembered that when i asked my lecturer if i should put brace for the if statement, and she said i should.

it's confusing now.is the brace necessary?

and regarding entering multiple numbers,i dont quite get it.could you please explain it using an example?

[kiseitai2]

Well, you put the brackets {} in the if statement if you want, but is recommended (even in a book I read) because:
A) it is more organized and easier to read 'cause you know that what's inside the brackets are in the IF statement if you don't remember.

if (this == this)
{
cout << blah;
}
else
{
blah;
}

B) C/C++'s functions are coded with brackets, so it make easy to identify block of code even for a novice that is reviewing your code for the first time.

C) It separates blocks of code that are part of the IF statement from those that are not. Example:

Messy:

If (this==this)
cout << blah1;
blah2 = blah1;

Organized:

If (this== this)
{
cout << blah1;
}
blah2 = blah1;

+(This is my personal opinion) It may even make things easier for the compiler since there is less chance that compilerA will not be confused identifying blocks of codes (like in the messy example) and also compilerB (if you have to use another one) will not be confused either even if it makes programs differently.
++I'll post another reply if I find an answer to the problem in your code. I hope this helps.

[kiseitai2]

#include <iostream.h>
#include <conio.h>

int main ()
{
int number,even = 0,odd = 0,small,big;



cout << "\nInput an integer, one at a time, and press enter.\n";
cout << "Enter the numbers as many as you want.\n";
cout << "Enter integer 0 to stop.\n";
cout << "Enter number: \n";
cin >> number; //this is where your problem lies. You are only asking for a value once. To do it multiple times I recomend wrapping cin within a loop. Sorry I can't tell which one is better because you are the one who knows how developed the program must be and this is your assignment.

small = number;
big = number;

while (number != 0) //Are you sure this loop ends somewhere?
{
number == 0; //looks like an ugly never ending loop to me.
{
if ((number % 2) == 0)
even = even + 1;
else
odd = odd + 1;

if (number < small)
number = small;
else
{
if (number > big)
big = number;
else
endl;
}

}

}

cout << "\nThe biggest number is " << big << endl;
cout << "\nThe smallest number is " << small << endl;

cout << "\nThere is " << even << " even numbers." << endl;
cout << "\nThere is " << odd << " odd numbers." << endl;

getch ();
return 0;

}

Check the comments in bold I put in the code for hints as to what you might want to consider doing to solve the problem (I also put a comment on what it looked like a concerning block). I didn't post comments on all syntax errors (there was another one) nor I fixed the code for you cause I'm only helping, but you are the one who needs to do it so you learn is for your own good). :)

[tsushio]

thank you for the responds.

you help me a lot.

thank you again. ^_____^