Memory Leak (40K per mouse over)

[RomeoPapacy]

I'm currently writing a replacement shell and am suffering from quite dire memory leaks, when running, every time I roll my mouse over the taskbar icon a new window scrolls out revealing the window's caption and then on WM_MOUSELEAVE the window closes again. somehow this process also increases my program's private working set by 40K (using SysInternals' Process Explorer) Any help would be appreciated.

Extract from TaskbarItem.cpp:

LRESULT CALLBACK            TaskbarItem::LocalProc(HWND hWnd,UINT msg,WPARAM wParam,LPARAM lParam){
    switch(msg){
        case WM_MOUSEMOVE:{
            if(this->caption==(TaskExpander*)NULL)
                this->caption=new TaskExpander(&(*this));
            else
                this->caption->Reopen();
        }break;
        case WM_MOVED:
            if(caption!=(TaskExpander*)NULL){
                SendMessage(caption->GetDispHWnd(),WM_MOVED,0,0);
            }
            break;
        default:return DefWindowProc(hWnd,msg,wParam,lParam);
    }
    return 0L;
}

Extract from TaskExpander.cpp:

void                                TaskExpander::Reopen        (){
    if((state & _O)==0){
        KillTimer(dWnd,IDT_TIMER_CLOSE);
        KillTimer(dWnd,IDT_TIMER_TIMEOUT);
        state=OPENING;
        SetTimer(dWnd,IDT_TIMER_OPEN,ANI_TIME,0);
        ShowWindow(dWnd,SW_SHOW);
    }
}
LRESULT CALLBACK                    TaskExpander::LocalProc        (HWND hWnd,UINT msg,WPARAM wParam,LPARAM lParam){
    LPPAINTSTRUCT ps=new PAINTSTRUCT;
    HDC hdc;
    HFONT hFont;
    hFont=global::font::basic;
    switch(msg){        
        case WM_MOVED:{
            LPRECT r=new RECT;
            LPRECT s=new RECT;
            GetWindowRect(pTbi->GetDispHWnd(),r);
            GetWindowRect(hWnd,s);
            position.x=r->right;
            position.y=r->top-1;
            MoveWindow(hWnd,position.x-(s->right-s->left),position.y,(r->right-r->left),r->bottom-r->top,true);
            InvalidateRgn(hWnd,NULL,TRUE);
        }break;
        case WM_PAINT:{
            hdc=BeginPaint(hWnd,ps);
            SetBkColor(hdc,0x00000000);
            SelectObject(hdc,hFont);
            SetTextColor(hdc,0x00FFFFFF);
            size_t psz;
            LPRECT r=new RECT;
            GetWindowRect(hWnd,r);
            HICON icon=pTbi->GetIcon();
            StringCchLength(pTbi->GetTitle(),MAX_LOADSTRING,&psz);
            TextOut(hdc,2*ICON_GAP+ICON_SIZE,ICON_GAP/2,pTbi->GetTitle(),psz);
            DrawIconEx(hdc,ICON_GAP,0,icon,ICON_SIZE,ICON_SIZE,0,NULL,DI_NORMAL);
            EndPaint(hWnd,ps);
            delete r;
            }break;
        case WM_TIMER:
            switch(wParam){
                case IDT_TIMER_OPEN:{
                    state=OPENING;
                    hdc=GetDC(hWnd);
                    LPRECT r=new RECT;
                    size_t psz;
                    SIZE size;
                    SelectObject(hdc,hFont);
                    StringCchLength(pTbi->GetTitle(),MAX_LOADSTRING,&psz);
                    GetTextExtentPoint32(hdc,pTbi->GetTitle(),*&psz,&size);
                    GetWindowRect(hWnd,r);
                    if((size.cx+(2*ICON_GAP)+ICON_SIZE)-(r->right-r->left)>ANI_STEP)
                        MoveWindow(hWnd,position.x-(r->right-r->left)-ANI_STEP,position.y,(r->right-r->left)+ANI_STEP,r->bottom-r->top,true);
                    else{
                        MoveWindow(hWnd,position.x-(size.cx+(2*ICON_GAP)+ICON_SIZE),position.y,(size.cx+(2*ICON_GAP)+ICON_SIZE),r->bottom-r->top,true);
                        KillTimer(hWnd,IDT_TIMER_OPEN);
                        SetTimer(hWnd,IDT_TIMER_TIMEOUT,10000,(TIMERPROC)NULL);
                        state=OPEN;
                    }
                    delete r;
                }break;
                case IDT_TIMER_CLOSE:{
                    state=CLOSING;
                    KillTimer(hWnd,IDT_TIMER_TIMEOUT);
                    LPRECT r=new RECT;
                    GetWindowRect(hWnd,r);
                    MoveWindow(hWnd,position.x-(r->right-r->left)+ANI_STEP,position.y,(r->right-r->left)-ANI_STEP,r->bottom-r->top,true);
                    if(r->right-r->left <= ICON_SIZE+ANI_STEP){
                        KillTimer(hWnd,IDT_TIMER_CLOSE);
                        state=READY;
                        ShowWindow(hWnd,SW_HIDE);
                    }
                    delete r;
                }break;
                case IDT_TIMER_TIMEOUT:{
                    KillTimer(hWnd,IDT_TIMER_OPEN);
                    this->state=CLOSING;
                    SetTimer(hWnd,IDT_TIMER_CLOSE,ANI_TIME,(TIMERPROC)NULL);
                }break;
            }break;
        case WM_INIT:
            ShowWindow(dWnd,SW_SHOW);
            SetTimer(hWnd,IDT_TIMER_OPEN,ANI_TIME,(TIMERPROC)NULL);break;
            state=OPENING;
            break;
        case WM_MOUSEMOVE:
            if(state==CLOSING){
                KillTimer(hWnd,IDT_TIMER_CLOSE);
                SetTimer(hWnd,IDT_TIMER_OPEN,ANI_TIME,(TIMERPROC)NULL);
            }
            if(!tracking){
                TRACKMOUSEEVENT tme;
                tme.cbSize=sizeof(tme);
                tme.dwFlags=TME_LEAVE;
                tme.hwndTrack=hWnd;
                TrackMouseEvent(&tme);
                tracking=true;
            }
            break;
        case WM_MOUSELEAVE:
            KillTimer(hWnd,IDT_TIMER_OPEN);
            KillTimer(hWnd,IDT_TIMER_TIMEOUT);
            SetTimer(hWnd,IDT_TIMER_CLOSE,ANI_TIME,0);
            state=CLOSING;
            tracking=false;
            break;
        case WM_LBUTTONDOWN:
            SetForegroundWindow(pTbi->GetHWnd());
            SetActiveWindow(pTbi->GetHWnd());
            break;
        default:delete ps,hdc,hFont;return DefWindowProc(hWnd,msg,wParam,lParam);
    }
    return 0L;
}

[Banfa]

I see the code allocating TaskExpanders

this->caption=new TaskExpander(&(*this));

but never deleting them and I see the code deleting pointers

default:delete ps,hdc,hFont;return DefWindowProc(hWnd,msg,wParam,lParam);

that have not had memory allocated to them while most of the time it doesn't delete

LPPAINTSTRUCT ps=new PAINTSTRUCT;

allocated PAINTSTRUCTs

[RomeoPapacy]

Thank you for your response.

@Banfa
They would be deleted in the destructor for the TaakbarItem, however this should only cause the memory to go up on the first call surely? memory goes up every time the expander reopens.

adding the "delete ps;" in the relevant places has roughly halved the memory leaking. I managed to find the main cause to be the GetDC() on line 45, adding a corresponding releaseDC has solved the problem.
Thank you for your help.

[weaknessforcats]

You are creating new RECT variables in several places. How are those cleaned up?

[RomeoPapacy]

@weaknessforcats
Those are now all being deleted after use.

Thank you for your help.
This aspect of the program no longer leaks, the rest of the program has the memory management of a sieve but i should be able to sort that out. Thank you.

[Banfa]

I don't know if this is code you inherited or wrote but personally whenever I allocate memory from the heap using new I always put in the corresponding delete immediately before filling in any other code.

You may also want to consider using the handle template