By using this site, you agree to our updated Privacy Policy and our Terms of Use. Manage your Cookies Settings.
454,498 Members | 1,713 Online
Bytes IT Community
+ Ask a Question
Need help? Post your question and get tips & solutions from a community of 454,498 IT Pros & Developers. It's quick & easy.

need help

P: 4
Im writing a fraction calculator program I finished the program but keep getting an error on the do while function. can someone help

heres the program
Expand|Select|Wrap|Line Numbers
  1. #include <iostream>  
  2. #include <iomanip>  
  3. #include <cmath>
  4.  
  5. using namespace std;    // Internal storage 
  6.  
  7. int choice;    
  8. int num1;      
  9. int denom1;      
  10. int num2;    
  11. int denom2;    
  12. int calcden;    
  13. int calcnum;      
  14.  
  15. void menuFunction(void)
  16. {
  17.   int denominator1, numerator1,denominator2, numerator2;
  18.   char operation;
  19.   cout<<"This program will agther your input, and perform mathematical operations on fractions. you will be prompted to enter a denominator and numerator for two fractions, and hen will be asked to enter an operation you wish to perform"<<endl;
  20.   cout<<"Please enter the first numerator"<<endl;
  21.   cin>>numerator1;
  22.   cout<<"Please enter the first denominator"<<endl;
  23.   cin>>denominator1;
  24.   cout<<"Please enter the second numerator"<<endl;
  25.   cin>>numerator1;
  26.   cout<<"Please enter the second denominator"<<endl;
  27.   cin>>denominator2;
  28.   cout<<"You may choose aadition (+), subtraction (-), multiplication (*) or division (/)...please choose an operation:"<<endl;
  29.  cin>>operation;
  30.  //perform error checking, call other functions, etc...
  31. }
  32.  
  33. void add()    
  34. {
  35. calcnum=num1*denom2 + denom1*num2;    
  36. calcden=denom1*denom2;    
  37. }
  38. void subtract()        
  39. {
  40.     calcnum=num1*denom2-(denom1*num2);  
  41.     calcden=calcden=denom1*denom2;  
  42. }
  43.  
  44. void multiply()        
  45. {
  46.     calcnum= num1*num2;      
  47.     calcden=denom1 * denom2;      
  48. }
  49.  
  50. void divide()        
  51. {
  52.     calcnum= num1*denom2;      
  53.     calcden=denom1 * num2;      
  54. }
  55. void exit()      
  56. {
  57.     cout<<"Have a nice day. ";      
  58. }
  59.  
  60. void main()        
  61. {
  62.  
  63. do while(choice!='5')
  64.  {
  65.     cout<<"Enter a number from the menu: ";    
  66.     cin >> choice;
  67.     menu();        
  68.     cout<< "Enter the firts numerator: ";    
  69.     cin >>num1;      
  70.     cout<< "Enter the firts denomerator: ";  
  71.     cin>>denom1;    
  72. cout<< "Enter the second numerator: ";
  73. cin>>num2;    
  74. cout<< "Enter the second numerator: ";    
  75. cin>>denom2;    
  76. cout<<calcnum<<" /"<<calcden;      
  77. }
  78.  
  79. }
Nov 16 '08 #1
Share this Question
Share on Google+
2 Replies


boxfish
Expert 100+
P: 469
It's not
Expand|Select|Wrap|Line Numbers
  1. do while (choice != '5')
  2. {
  3.     // ...
  4. }
It goes like
Expand|Select|Wrap|Line Numbers
  1. do
  2. {
  3.     // ...
  4. } while (choice != '5');
Hope this helps.
Nov 16 '08 #2

Expert 10K+
P: 11,448
Possibly you mean 'while (choice != 5)' (skip that 'do') but there is a lot more wrong:

1) menu() is not a function; menuFunction() is but you only call it after the user
had to make a (blind) choice.
2) you ask the user for a second numerator but you assign it to the first numerator.

Fix those errors first, test it and see what happens.

kind regards,

Jos
Nov 16 '08 #3

Post your reply

Sign in to post your reply or Sign up for a free account.