Another newbie question

[Ethurian]

Hello yes I am a beginner at writing C++ and have been using Visual Studio C++ 2008, my problem is that when I enter this very simple code

#include <stdio.h>

int main( void )
{
int counter = 1;

do {
printf( "%d " , &counter );
} while ( ++counter <= 10 );

return 0;

}

this code is supposed to simply count from 1 to 10 but instead the results are this

1245024 1245024 1245024 1245024 1245024 1245024 1245024 1245024 1245024 1245024
Press any key to continue...

I have checked the code in the book to the code I wrote numerous times and cannot find anything different except the results they display in the book actually work

Any help would be appreciated,

[manontheedge]

where you have "&counter", make it "counter"

what's printing out is the MEMORY ADDRESS of counter, that's the 124... whatever number you're getting. When you put "&" before a variable like you have, you are getting the ADDRESS of it, NOT the value. It's quite possible it's a typo in your book ... I've seen good books with code filled with typos.


...and by the way, your code there is C not C++.

[JosAH]

Hello yes I am a beginner at writing C++

Please don't hijack somebody else's thread; it is considered rude. I've split your
thread (and reply) to its own thread.

kind regards,

Jos (moderator)

[donbock]

You may also what some separator between each printed value, maybe a space or a newline.

[boxfish]

There is a separator; a space after the %d.

[itsraghz]

The perfect answer was given by "manontheedge" !! Remove the "&" and rerun the program. It will be fine!