C++ crash problem...

[Adam01]

Hi, I have been working on some dll project, just to store values.
I hardly use arrays, so it may be a bit on the stupid side.

Ok, this is the program that uses the dll:

#include <iostream>
#include <conio.h>
#include <string>
#include <windows.h>
#include "..\dlltest1\main.h"
using namespace std;
int main()
{
   dll store;
    store.store("hello");
    char *vals = store.getvals(1);
    for (int i = 0; i <= 10; i++) cout << " " << vals[i] << "\n";
      return 0;
}

dll header:

#ifdef DLLDIR_EX
   #define DLLDIR  __declspec(dllexport)   // export DLL information
 
#else
   #define DLLDIR  __declspec(dllimport)   // import DLL information
 
#endif
 
using namespace std;
class dll
{
    private:
    char storagearray[1000][10][1000];
    static int ammount;
 
   public:
      dll();          
      ~dll();        
    int addto(string string, int loc);
    int store(string string, int loc = 0);
    int add(string thing);
    char* getvals(int loc);
};

and dll main:

#include <string>
#include "main.h"
#include <iostream>
 
 
using namespace std;
 
dll::dll(){};
dll::~dll(){};
 
int dll::ammount = 1;
 
int dll::addto(string string, int loc){
    if(storagearray[loc][0][0]){
    int x = 2+ storagearray[loc][1][0];
    if(x<8){
        strcpy(storagearray[loc][x],string.c_str());
        storagearray[loc][1][0] = ++x;
        return 0;
    }
    else return 3;
    }
    else return 2;
}
 
int dll::add(string string){
    for(int i = 1; i <= ammount; i++){
        if(storagearray[i][0][0]) continue;
        else { storagearray[i][0][0] = 1;
        int thing = 2+ storagearray[i][1][0]++;
        strcpy(storagearray[i][thing],string.c_str());
        return 1;
        }
        ammount++;
        storagearray[ammount][0][1]++;
        strcpy(storagearray[ammount][2],string.c_str());
        storagearray[ammount][0][0] = 1;
        cout << (char)string.c_str() << " added. \n";
        return 1;
 
    }
    return -1;
    }
 
int dll::store(string string, int loc){
    int done = 0;
    int dloc = 0;
if(loc == 0) dloc = add(string);
else done = addto(string, loc);
if(dloc == -1) return 5;
else return done;
}
 
    char * dll::getvals(int loc){
        char *array;
        if(storagearray[loc][0][0]){
            for(int i = 0; i <= 10; i++){
                strcpy(array, storagearray[loc][i]);
        }
        }
        return array;
    }
 
 
 

The return value for this is : -1073741571 (0xC00000FD)
It is using the correct object file.

I cant see what the problem is exactly, when building the dll, theres no output errors. But i do have doubts about 'storagearray'.

[weaknessforcats]

What exactly are you trying to do?

A class named dll is very od since an object ios not a dll. Are you trying to create a dll and use it?

I see you mixing C++ strings (string() with C-srrings (char*). Why can't yu use just string objects?

There is a 3D array in your class. C++ programmers generally use a vector instead of an array. Why 3D? If you are attempting to store strings you would have a vector<vector<string> > so I don't see where the third dimiension comes in.

Also that 3D array is very large and is on the stack. Stack memory is not the place for things like this. Again, all this is resolved by using a vector since a vector manages its own memory.

[Adam01]

I was having trouble storing a string in, say, [1][2] - so I assumed that the array was only holding a single value.
so then I used [1][2][1000], and i would copy and string into [1][2], copying the string into [1][2][0-1000], then the crashing came in...

Im making a dll to store stuff (for no reason) .

When I used 2d arrays, they stored values.. wrong, like corrupted.
The translation was working fine (string -> char, char -> string).