strtok and newline

[mickey0]

Hello,
I have to read the _buffer (buffer contains '\r\n' properly) into a a vector; problem is that I need also to check when I step over the '\r\n', because in this case I need to insert 'v' in a vector of vector; Is there a way to do that control using strtok() ?

    char delims = ',';
    char* result = NULL;
    result = strtok( _buffer, delims );
    vector<double> v;
        while (result != NULL) { //and !endOfLine
            result = strtok( NULL, delims );
            v.push_back( atof(result) );
        }
         InsertInVectorOfVector(v)
 

Thanks,

[weaknessforcats]

There is seldom a reason fo mixing the C string library with C++.

In this case, is there a reason you can't use getline() to fill your buffer?

If you know the format of the buffer, you can insert it in a stringstream using << and then extract out the token using >>.

[mickey0]

There is seldom a reason fo mixing the C string library with C++.
In this case, is there a reason you can't use getline() to fill your buffer?
If you know the format of the buffer, you can insert it in a stringstream using << and then extract out the token using >>.

Hello, there isn't any reason; I'd like explore strtok; I wrote this solutions and for me should be right...instead it doens't work:

    vector<double> v;
    vector< vector<double> > doubleVector;
 
    char* line;
    line = strtok(_buffer, "\r\n");
    while ( line != NULL ) {
        cout << line << endl;
        char* value = strtok(line, ",");
            while ( value != NULL) {
                cout << value << endl;
                v.push_back( strtod(value, NULL) );
                value = strtok(NULL, ",");            
            }        
        doubleVector.push_back(v);
        v.clear();
        line = strtok(NULL, "\r\n"); //1
 
    }
 

Problem's at //1, "line" takes bad ptr.... why this? Any suggestions, please?

[Banfa]

Hello, there isn't any reason; I'd like explore strtok;

strtok is not a very good function, and specifically it isn't re-entrant and you use it in a re-entrant manor.

In general I would say you should not use strtok in any program that you intend to keep the source of for more than 10 minutes. There are a lot better ways of parsing a string even in C.

I would assign strtok to the list of C standard library functions that you don't need to know about because you are never going to call (along with atoi, atof, ato... because why call these when the superior strtol, strtoul, strtod exist).