Delete object that is stored in Vector

[thelamb]

Hello all,

I have a question about deleting objects(the objects are stored in a vector)

I Fill the vector as following:

        servObj.push_back(new CGame(serversh, game_id)); (1)
 

Since I am calling new, I need to call delete somewhere else in the program.

If I try to delete the first object that was stored in servObj like this:

                delete &(servObj.at(0));
 

And try to erase the first element after that I get segmentation fault(makes sense).

Now my question is, if I just erase the first element, will it cleanly destroy the object that was stored in the first element?

So:

                 servObj.erase(itservObj);        
 

here itservObj is a vector::iterator. Will this deallocate the memory properly?

I havnt been coding in C++ for that long(read: never had to bother with memory management) so I would appreciate anyone pushing me in the right direction here.

Thanks in advance

[weaknessforcats]

Have you run this in the debugger to see of the CGame destructor is called?

What you have stored in the vector is a pointer to a heap object. Erasing the pointer in the vector does not delete the object.

The vector::at returns a reference to the pointer. Therefore, you should be deleting servObj.at(0), which is your pointer.

[thelamb]

Ok I just tried again, and for some reason it works now where it didnt work before(I guess I missed something in my first try).

For anyone who cares:

 for( itservObj=l_servObj.begin(); itservObj != l_servObj.end(); itservObj++)
                {
                        if( (**itservObj).whoareyou(serversh) == true )
                        {
                                delete (*itservObj);
                                l_servObj.erase(itservObj);
                        }
 
 

Dont know why this didnt work the first try, but thanks for your help anyway :)