magic square

[inferi9]

Hi,
I am working in a program caals magic square and it must be done only with loops and user definied funcations,I will tell you about my code and where my problem, the main is only calls the other funcations,The first funcation makes a squence which the user input where it begins and the differents between easch elements the size of this one dimensional array is 16. the second funcation puts the elements of the one dimensional arry into a two dimensional size 4*4.funcation 3 only print, funcation 4 reverses both the diagonals, funcation 5 which I had a problem with it is that takes the one dimensional array and output it's sum but my problem it only takes the sum of the last four elements and it addes them 16 time, of course the program is not finished because the sum of the one dimensional array divided by four is the magic number,and then I must cheak the sum of the rows and columns to see if itis equal to the magic number.here is my code.

#include <iostream>
using namespace std;
const int ROWS=4;
const int COLUMNS=4;
const int size=16;
void createArithmeticSeq (int list[], int size);
void matricize (int list[], int matrix [ROWS][COLUMNS],int ROWS);
void printMatrix (int matrix[][COLUMNS], int ROWS);
void reverseDiagonal (int matrix[][COLUMNS], int ROWS);
void magicCheak (int list[],int matrix[][COLUMNS],int size,int ROWS);
int main ()
{
    int list [size];
    int matrix [ROWS][COLUMNS];
 
 
     createArithmeticSeq (list, size);
     matricize (list, matrix , ROWS);
     printMatrix (matrix, ROWS);
     reverseDiagonal (matrix, ROWS);
     printMatrix (matrix, ROWS);
     magicCheak (list,matrix, size, ROWS);
 
 
    return 0;
 
}
 
//first funcatio
void createArithmeticSeq (int list[], int size)
 
{
    int first, diff;
    int i;
 
    cout<<"Enter the number that the sequence begin and the differance "<<endl;
    cin>>first;
    cin>>diff;
 
    for (i=0; i<size;i++)
    {
 
        list[i]=first;
        first=first+diff;
        cout<<list[i]<<" ";
    }
 
cout<<endl;
}
 
//second funcation
void matricize (int list[], int matrix [][COLUMNS],int ROWS)
 
{
 
    int i;
    int j;
 
      for(j=0;j<16;j++)
        for (i=0;i<ROWS;i++)
        matrix[i][j]=list[j];
 
}
//funcation    3
void printMatrix (int matrix[][COLUMNS], int ROWS)
{            
 
 
 
 
    int row;
    int col;
    for (row=0;row<ROWS;row++)
    {
        for(col=0;col<COLUMNS;col++)
            cout<<matrix [row][col]<<" ";
    cout<<endl;
    }
 
    cout<<endl;
}
 
 
//fourth funcatin
void reverseDiagonal (int matrix[][COLUMNS], int ROWS)
 
{
    int row;
    int temp;
 
    for(row=0;row<ROWS/2;row++)
    {
        temp=matrix[row][row];
        matrix[row][row]=matrix[ROWS-1-row][ROWS-1-row];
        matrix[ROWS-1-row][ROWS-1-row]=temp;
    }
 
    for (row=0;row<ROWS/2;row++)
    {
        temp=matrix[row][ROWS-1-row];
        matrix[row][ROWS-1-row]=matrix[ROWS-1-row][row];
        matrix[ROWS-1-row][row]=temp;
 
    }
 
 
 
}
// funcatin 5
void magicCheak (int list[],int matrix[][COLUMNS],int size,int ROWS)
 
{
    int i;
 
    for (i=0;i<16;i++)
        cout<<list[i]<<" ";
 
 
 
}

I tried this code for funcation two:

for(j = 0; j < COLUMNS; j++)
    for(i = 0; i < ROWS; i++
        matrix[i][j] = list[i++]

funcation four came out rihgt but the matrix was garzy numbers


so can anyone please help? thank you

[Ganon11]

You will need to use a third variable in your matricize() function. Try making the for loops determine the row/column, and have a third int variable for determining which spot in list gets used - it will be incremented in every execution of the loop.

[inferi9]

I tried anothe variable (k) which goes all the way to 16 but I have two problem:

1_ I do not know where to put this loop and i tried everywhere without any good

2_ the matrix will be only contains the last number which is the last number in the one dimenstional array.

[Ganon11]

You do not need a third loop. Your two loops will properly assign the element to a new position in the matrix. All you need to do is use a third variable (k), starting at the beginning of the list (k = 0;). Every time you assign a number in list to the matrix, increment the k variable.

[inferi9]

Thank you soooooo much you were a great help