array of strings

[sritejv]

Hi guys,

i m have trouble with reading strrings and storing them in a 2d array and printing them

(1)

for(y=0;y<5;y++)
    {
     printf("enter filenames \n");
     scanf("%s",&fnames[y][0]);
    }
 
  for(y=0;y<5;y++)
    {
     printf("filename %s\n",&fnames[y][0]);
    }
 
(2) for(y=0;y<5;y++)
    {
     printf("enter filenames \n");
     scanf("%s",fnames[y]);
    }
 
  for(y=0;y<5;y++)
    {
     printf("filename %s\n",fnames[y]);
    }
 

for both the programs if the input were to be:
aaa
bbb
ccc
ddd
eee

the output is
aaabbb......eee
bbb.....eee
cc...eee
d...eee
eee

what could be wrong?
i thought fname[y] refers to the base address of yth 1D array in the 2D array.

[bharatkukreti]

Hi guys,

i m have trouble with reading strrings and storing them in a 2d array and printing them

(1)for(y=0;y<5;y++)
{
printf("enter filenames \n");
scanf("%s",&fnames[y][0]);
}

for(y=0;y<5;y++)
{
printf("filename %s\n",&fnames[y][0]);
}

(2) for(y=0;y<5;y++)
{
printf("enter filenames \n");
scanf("%s",fnames[y]);
}

for(y=0;y<5;y++)
{
printf("filename %s\n",fnames[y]);
}

for both the programs if the input were to be:
aaa
bbb
ccc
ddd
eee

the output is
aaabbb......eee
bbb.....eee
cc...eee
d...eee
eee

what could be wrong?
i thought fname[y] refers to the base address of yth 1D array in the 2D array.

i dnt think anything wrong its workin fine in vc++ compiler

[sritejv]

i used gcc in fedora linux..cant figure out the error..

[weaknessforcats]

How is your array defined?

[sritejv]

hey i got the error..eventhough the program is correct i overlooked some basics..

my array defn was char fnames[5][3]..//i thought this can 3 character strings,but that is not the case..the compiler appends a zero after each input..

so char fnames[5][4] should be correct..

how is your array defined

weaknessforcats ..u were bang on target!!

basics!!

[Natasha26]

Just a quick check. Does the following sound ok to anyone? It works, but i don't know whether the array gets de-allocated after main() ends?

#include <iostream>
 
int main()
{    char* fname[3];
 
    fname[0] = "aaa";
    fname[1] = "bbb";
    fname[2] = "ccc";
 
    for(int i=0; i<3; i++)
        std::cout << "\n" << fname[i];
 
   // The following should be superflous right? 
   /* for(int i=0; i<3; i++)
         delete [] fname[i];
   */
 
  return 0;}
 

[weaknessforcats]

What ytou have defined is an array of 3 char*. This is OK.
Next, each char* is assigned the address of a const string. This is OK.
Next, you display. This is OK.
Next, you delete. This is a crash. You do not delete unless you used the new operator to allocate. When you don't use new, the compiler will take care of deleting your variables.