error: Class * has no member named *

[Myxamatosis]

Upon compiling my code for a fraction class, the error that i get is a good 50 or so repetitions of

error: Class "Fraction" has no member named "Numer"
and
error: Class "Fraction" has no member names "Denom"

I'm guessing it has something to do with the declaration of these private objects in the .h file, and it's use in the source code

here's a snippet of one of the functions

bool operator>=( const Fraction& One, const Fraction& Two )
{
    int a, b, c, d, e;
 
    a = One.Numer();
    b = One.Denom();
    c = Two.Numer();
    d = Two.Denom();
 
    e = b;
    a = a*d;
    b = b*d;
    c = c*e;
    d = d*e;
 
    return( a >= c );
}
 

the private declaration is

  private:
 
    int Numer_;
    int Denom_;
 

and the boolean operation is as follows

bool operator>=( const Fraction& One, const Fraction& Two);
 

I'm unsure on classes in c++, but this error seems to be the only one

If you need more of my code to find the error, let me know.

Thanks,
-Myxamatosis

[oler1s]

Why are you so surprised? You create private variables for the class. Then you create a separate function, that tries to access those private variables. Perhaps your function shouldn't be external to the Fraction class...

[Myxamatosis]

the bool functions are in the class source code, and the private members are in the fraction.h file.

I guess I just don't understand what you're getting at...I thought when you did
#include "proj.fraction.h"

in the .cpp file, it grants you the access to the members

[Laharl]

If your .cpp file is called proj.fraction.cpp, you will have access to them, if the functions are declared as member functions for your fraction class. The linker handles all this for you, as long as you #include your .h file.

//foo.h
class foo{
  public bar;
  private blah;
  int getBlah();
};
 
//foo.cpp
#include "foo.h"
int foo::getBlah(){
  return blah;
}
 

[oler1s]

I won't directly feed you the answer, because I want you to reach it on your own, but I'll say the following. If it doesn't make sense, don't hesitate to ask me to clarify.

the bool functions are in the class source code

I would imagine so. Your intention is that the bool functions are part of the class, right? However, just putting a function in the same source file as the rest of the class source code doesn't mean they are actually part of the class. Think of it this way. I could take each function of the class, and have it in a different source file. That's perfectly fine. I need to explicitly mark a function as part of a class. Still not getting it?

class A
{
    int add(int a, int b);
};
 
int add(int c, int d);
 
int A::add(int a, int b) { return a + b }
int add(int c, int d) { return c + d }
 

Same for operators... Look up operator overloading for classes explicitly though.

I thought when you did
#include "proj.fraction.h"

in the .cpp file, it grants you the access to the members

All an include statement does is a copy/paste. That's it. Why do you need to copy paste fraction.h into the source file? Because when the compiler sees your source file, it's going to be sitting around wondering what "Fraction" is. So you need to declare the existence of this class called Fraction, and describe what's in it. But that doesn't mean when Fraction is declared that suddenly all syntax rules go out the window.

Sure, fraction.h is included. But is the operator >= a part of the fraction class? Not the way you wrote it. Then, because the variables are private, they cannot be accessed.

[Myxamatosis]

I toyed around with it, and I've managed to rid myself of the operator errors.

However, when I changed my logic operators to accept one parameter ( I had an error saying it can accept only one or zero) it now tells me that

error: `bool operator!=(const Fraction&)' must take exactly two arguments

The source code for the operator goes like this

bool operator!=( const Fraction& One )
{
    Fraction temp;
    int a, b, c, d, e;
 
    a = One.Numer_;
    b = One.Denom_;
    c = temp.Numer_;
    d = temp.Denom_;
 
    e = b;
    a = a*d;
    b = b*d;
    c = c*e;
    d = d*e;
 
    return( a != c );
}
 

I originally had it accepting two Fraction& arguments, but that gave me an error too

I'm kinda lost on this one again, some direction would be great

[Laharl]

That has to be a class member function so that the "this" object can be the hidden first parameter, as it is with all class methods.. 'This' is a pointer to the object calling the method so that it can be set to the other Fraction object.

class Foo{
 int bar;
 bool operator<(const Foo& other); //This is effectively bool operator<(this, const Foo& other);
}
 
bool Foo::operator<(const Foo& other){
 //Implementation
}