Issue implementing stack/push/pop functionality

[xr0krx]

Hi, Im having some problems with my program. I'm kinda new to this stuff; only been doing this for about a month. What it's suppose to do is ask the user to input a word, and then print out the word in reverse order. It's basically using the pop/push idea...sorta. I've tried a variety of ways to convert the string to char to get it to print, but all of them havent worked. Any ideas?

Here's where I ended up...

#include <iostream.h>
#include <cstring.h>
 
const Maxstack = 5;
int Top;
 
//Prototypes
void Push(char Stack[][50], char item);
void Pop(char Stack[][50], char item);
bool Empty();
bool Full();
void Init();
 
main()
{
  char Stack[Maxstack][50];
  //char Item[50];
  char item;
  char ans;
  ans ='y';
  string name;
  string mystack;
  int i = 0;
 
while(ans=='y' || ans == 'Y')
{
 
  cout<<"Enter a word: ";
  cin>>name;
 
  Init();
  for(i=0; i<=name.length(); i++)
  {
   mystack = name.substr(i,1);
   Push(Stack, mystack);
   Pop(Stack, item);
   cout<<item<<endl;
  }
  cout<<"\nDo you want to continue: ";
  cin>>ans;
}
 
return 0;
}
 
void Push(char Stack[][50], char item)
{
    if(Full())
   {
     cout<<"Full";
   }
   else
   {
     strcpy(Stack[++Top], item);
   }
//Stack[++Top] = item;
 
}
 
void Pop(char Stack[][50], char item)
{
  if(Empty())
  {
    cout<<"Empty";
    //strcpy(item, "");
  }
  else
   strcpy(item, Stack[Top]);
   Top--;
  //return StackTop--];
}
 
 
 
bool Empty()
{
  return(Top==-1);
}
 
bool Full()
{
  return (Top+1==Maxstack);
}
 
void Init()
{
  Top =-1;
}

[manontheedge]

there's some stuff in your code that's a bit strange. Can you explain what's going on in that code? I mean, you say you've been doing this for about a month ... do you know what that code is doing?

What I'm getting at is that the basic idea of your question is a much simpler problem, the code you're attempting this with is way too complicated and sparadic. So, the idea is ...

read a word in ... you can put this word in a char array, for example

 
 
char* input;
 
or
 
char input[50];
 
 

then you need to know how long that input is, one way of doing that is using

 
 
strlen( input );
 
 

once you know what the length of the string is, you can print it out backwords by using a loop. Something like,

 
 
for ( i = strlen( input); i > 0; i-- )
{
    cout << input[ i ];
}
 
 

this is just to give you an idea, there are many ways to do this. My point though is to look at the problem at a basic level, and not to over complicate it.

[xr0krx]

Ah okay, it finally works now. Thanks for the help.

[weaknessforcats]

You should be using iostream and not iostream.h.

iostream.h is pre-ANS C++ from prior to 1998.

Also, I assume this is homework since a stack template already exists in the STL.