Dear gurus,
I have been reading about polymorphism and generally think that I get the idea. At least I've gotten some code to work. Now I'm trying to get a little fancier and can't seem to figure out the following dilemma.
I have an abstract class Base, and some Derived classes: - class Base {
-
public:
-
void f1 () {
-
//....
-
}
-
-
virtual void f2() = 0;
-
};
-
-
class Derived1 {
-
public:
-
Derived1(int p1, int p2) {
-
//...
-
}
-
void f2() {
-
//...
-
}
-
};
-
-
class Derived2 {
-
public:
-
Derived2(int p1, int p2) {
-
//...
-
}
-
void f2() {
-
//...
-
}
-
};
-
-
Until recently, I was happy with just declaring a derived class and using it: - void someFunc(Base var);
-
-
int main(int argc, char *argv[]) {
-
Derived var(p1, p2);
-
-
someFunc(var);
-
return 0;
-
}
Now, what I really want is to be able to decide at runtime what class type to use. I can't pre-declare it either because I have pure virtual functions (e.g. f2) in my Base class. I tried making them non-pure (just empty) and then assigning like this: - void someFunc(Base var);
-
-
int main(int argc, char *argv[]) {
-
Base var;
-
if (arg[1] == 0) {
-
Derived1 v(p1, p2);
-
var = v;
-
} else {
-
Derived2 v(p1, p2);
-
var = v;
-
}
-
-
someFunc(var);
-
return 0;
-
}
It compiled fine, but the program clearly does not work right. So now I'm realizing that I'm missing some concepts here and need help.
Thanks in advance
9 6463
Dear gurus,
I have been reading about polymorphism and generally think that I get the idea. At least I've gotten some code to work. Now I'm trying to get a little fancier and can't seem to figure out the following dilemma.
I have an abstract class Base, and some Derived classes: - class Base {
-
public:
-
void f1 () {
-
//....
-
}
-
-
virtual void f2() = 0;
-
};
-
-
class Derived1 {
-
public:
-
Derived1(int p1, int p2) {
-
//...
-
}
-
void f2() {
-
//...
-
}
-
};
-
-
class Derived2 {
-
public:
-
Derived2(int p1, int p2) {
-
//...
-
}
-
void f2() {
-
//...
-
}
-
};
-
-
Until recently, I was happy with just declaring a derived class and using it: - void someFunc(Base var);
-
-
int main(int argc, char *argv[]) {
-
Derived var(p1, p2);
-
-
someFunc(var);
-
return 0;
-
}
Now, what I really want is to be able to decide at runtime what class type to use. I can't pre-declare it either because I have pure virtual functions (e.g. f2) in my Base class. I tried making them non-pure (just empty) and then assigning like this: - void someFunc(Base var);
-
-
int main(int argc, char *argv[]) {
-
Base var;
-
if (arg[1] == 0) {
-
Derived1 v(p1, p2);
-
var = v;
-
} else {
-
Derived2 v(p1, p2);
-
var = v;
-
}
-
-
someFunc(var);
-
return 0;
-
}
It compiled fine, but the program clearly does not work right. So now I'm realizing that I'm missing some concepts here and need help.
Thanks in advance
You are speaking about polymorphism and you haven't used virtual or inherited from base class.
Raghuram
You are close.
What you do at runtime is create a Derived object.
Then assign the address of this object to a Base pointer.
Your example shows assignment to a Base object and this is incorrect. When you assign to a Base object, the Derived object is sliced so that the Derived part is cut off. Bad news. In C++ polymorphism only works when you use a Derived object through a Base* otr a Base&.
Next, since a Derived object is being used as a Base object, then it is important to call a Derived method instead of a Base method when this Derived object is used as a Base* or Base&. This is where the virtual function comes in.
Try to example again, only this time use a Base* to represent your Derived object.
You are speaking about polymorphism and you haven't used virtual or inherited from base class.
Raghuram
yes, sorry, I meant to write: - class Derived1 : public Base {
-
-
}
-
class Derived2 : public Base {
-
-
}
You are close.
What you do at runtime is create a Derived object.
Then assign the address of this object to a Base pointer.
Your example shows assignment to a Base object and this is incorrect. When you assign to a Base object, the Derived object is sliced so that the Derived part is cut off. Bad news. In C++ polymorphism only works when you use a Derived object through a Base* otr a Base&.
Next, since a Derived object is being used as a Base object, then it is important to call a Derived method instead of a Base method when this Derived object is used as a Base* or Base&. This is where the virtual function comes in.
Try to example again, only this time use a Base* to represent your Derived object.
Thanks! The pointer did the trick (mostly). The following works as expected: - #include <stdio.h>
-
#include <stdlib.h>
-
#include <iostream>
-
#include <string>
-
-
using namespace std;
-
-
class Base {
-
public:
-
// string temp;
-
virtual void whoami() = 0;
-
};
-
-
class Derived1 : public Base {
-
public:
-
virtual void whoami() {
-
cout << "== Derived1 ==" << endl;
-
}
-
};
-
-
class Derived2 : public Base {
-
public:
-
virtual void whoami() {
-
cout << "== Derived2 ==" << endl;
-
}
-
};
-
-
int main(int argc, char *argv[]) {
-
int t = 0;
-
Base * var;
-
-
if (t == 1) {
-
Derived1 v;
-
var = &v;
-
var->whoami();
-
} else if (t == 0) {
-
Derived2 v;
-
var = &v;
-
var->whoami();
-
}
-
var->whoami();
-
-
return 0;
-
}
The only problem I have left is if I uncomment the string temp declaration in line 10, The program crashes with the following message: -
== Derived2 ==
-
pure virtual method called
-
terminate called without an active exception
-
Abort
-
I am working with a much bigger code base in reality and it took me a while to isolate the issue to that seemingly innocent declaration. I am starting to think that this is a compiler issue. Does anyone have any clues? I am using gcc version 4.1.2
Thanks.
If t is not 0 or 1 you will call var->whoami() when it is still an uninitialized Base*.
Ka-Boom!
If t is not 0 or 1 you will call var->whoami() when it is still an uninitialized Base*.
Ka-Boom!
yes, I realize that. I'm omitting some safety checks to keep the example short. Clearly, t is initialized here, it goes Ka-Boom anyway, but only if I uncomment line 10.
Well I uncommented line 10 (string temp), compiled and executed this using Visual Studio.NET 2005 and it did not Ka-Boom.
Is the code in your Post #5 the exact code that crashes??
Well I uncommented line 10 (string temp), compiled and executed this using Visual Studio.NET 2005 and it did not Ka-Boom.
Is the code in your Post #5 the exact code that crashes??
yes, it is. What is even more weird is that if I declare 'int temp' instead, it works fine. I finally got everything to work by declaring 'new Derived'. If someone can explain to me why this makes sense, that would be great, otherwise the thread can be considered closed. Here is the working code in case somebody else cares: -
class Base {
-
string temp;
-
public:
-
virtual void whoami() = 0;
-
};
-
-
class Derived1 : public Base {
-
public:
-
virtual void whoami() {
-
cout << "== Derived1 ==" << endl;
-
}
-
};
-
-
class Derived2 : public Base {
-
public:
-
virtual void whoami() {
-
cout << "== Derived2 ==" << endl;
-
}
-
};
-
-
int main(int argc, char *argv[]) {
-
int t = 0;
-
Base * var;
-
-
if (t == 1) {
-
//Derived1 v;
-
//var = &v;
-
var = new Derived1;
-
var->whoami();
-
} else if (t == 0) {
-
//Derived2 v;
-
//var = &v;
-
var = new Derived2;
-
var->whoami();
-
}
-
var->whoami();
-
-
return 0;
-
}
-
Your crash is here: -
if (t == 1) {
-
Derived1 v;
-
var = &v;
-
var->whoami();
-
} else if (t == 0) {
-
Derived2 v;
-
var = &v; <<<<<<<<<<<<<<<<<<<<<<<<<
-
var->whoami();
-
}
-
var->whoami(); <<<<<<<<<<KA-BOOM!
-
The Derived2 object goes out of scope at the end of the if statement. But you still use the object after it has gone out of scope.
This is the old: A function can never return an address or a reference to a local variable.
Sign in to post your reply or Sign up for a free account.
Similar topics
by: Kurt |
last post by:
i just can't figure out why something im doing is not
working correctly....
public interface IInterface
{
int someProperty
{
get;
set;
}
|
by: Kurt Lange |
last post by:
no... the array is created dynamically.
and no... that defeats the purpose of what im trying
todo..
encapsulate all initializing of variables in base
class...
derive from it... by deriving...
|
by: philippe sillon |
last post by:
Hi,
I have a problem to implemente the strategy pattern. the problem come
from that a method take different arguments type (object in interface
and String / Int in implemented class).
When...
|
by: Lars-Erik Aabech |
last post by:
Hi!
I've got a small challenge with my class library. I've got an abstract base
class with some protected fields. It has two derived classes, and it should
be possible to cast these classes to...
|
by: Steve Teeples |
last post by:
Can someone tell me the correct method of casting and object at run time.
Here is a sample of what I'm trying to do. classA acts as a base for classes
that execute code in classes derived from...
|
by: Greg Conely via .NET 247 |
last post by:
I am creating a application that will be using plugins. I am doing this so that when I want to let this application work with another type of dbase system, I only have to write\install one plugin,...
|
by: Michael |
last post by:
Hi,
I think my problem deals with class casting and inheritance.
I want to deal with various Audio Formats, reading into memory for
modification, working with it (done by different classes),...
|
by: anders.forsgren |
last post by:
This is a common problem with generics, but I hope someone has found
the best way of solving it.
I have these classes: "Fruit" which is a baseclass, and "Apple" which
is derived. Further I have...
|
by: Brett Romero |
last post by:
Say I have a class inheriting some base class:
BaseClass
{
void Foo()
{
Update();
}
}
|
by: Tem |
last post by:
I have classes A,B,C,D,E,F that implement InterfaceBase.
Whats the best way to down cast obj to the correct type?
Is there a more elegant way to do this than?
Public Void...
|
by: aa123db |
last post by:
Variable and constants
Use var or let for variables and const fror constants.
Var foo ='bar';
Let foo ='bar';const baz ='bar';
Functions
function $name$ ($parameters$) {
}
...
|
by: ryjfgjl |
last post by:
If we have dozens or hundreds of excel to import into the database, if we use the excel import function provided by database editors such as navicat, it will be extremely tedious and time-consuming...
|
by: ryjfgjl |
last post by:
In our work, we often receive Excel tables with data in the same format. If we want to analyze these data, it can be difficult to analyze them because the data is spread across multiple Excel files...
|
by: emmanuelkatto |
last post by:
Hi All, I am Emmanuel katto from Uganda. I want to ask what challenges you've faced while migrating a website to cloud.
Please let me know.
Thanks!
Emmanuel
|
by: BarryA |
last post by:
What are the essential steps and strategies outlined in the Data Structures and Algorithms (DSA) roadmap for aspiring data scientists? How can individuals effectively utilize this roadmap to progress...
|
by: nemocccc |
last post by:
hello, everyone, I want to develop a software for my android phone for daily needs, any suggestions?
|
by: Hystou |
last post by:
There are some requirements for setting up RAID:
1. The motherboard and BIOS support RAID configuration.
2. The motherboard has 2 or more available SATA protocol SSD/HDD slots (including MSATA, M.2...
|
by: marktang |
last post by:
ONU (Optical Network Unit) is one of the key components for providing high-speed Internet services. Its primary function is to act as an endpoint device located at the user's premises. However,...
|
by: jinu1996 |
last post by:
In today's digital age, having a compelling online presence is paramount for businesses aiming to thrive in a competitive landscape. At the heart of this digital strategy lies an intricately woven...
| |