473,231 Members | 1,595 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 473,231 software developers and data experts.

There is some prolem in the funciton modification below. Please checkit and tell me what is worng?

void directory::modification()//???????????
{
clrscr();

cout<< "\n\t @@@@@@ @@@@@ @@@@@ @@@@@@ @@@@@ @ @
@@@@@@ ";
cout<< "\n\t=====@ @ @ @ @ @ @@ @
@ =====";
cout<< "\n\t=====@@@@@@ @ @ @ @ @ @ @ @ @
@@@ =====";
cout<< "\n\t=====@ @ @ @ @ @ @ @@
@ @ =====";
cout<< "\n\t @@@@@@ @@@@@ @@@@@ @ @@@@@ @ @
@@@@@@ \n\n\n\n";
cout<<"I am inside the modification function before opening of
addressesFiile.";
getch();
long pn;
int n,i;
ifstream inFile;
ofstream outFile;

inFile.open("addressesFile");
if(!inFile)
{
cout<<"\nI am inside the modification function after opening
of addressesFiile. Checking now with if";
getch();
cout<<"\n File not found!";
outFile.close();
exit(-1);
}
outFile.open("new");
cout<<"\nI am inside the modification function after just creating
new";
getch();
n=test();
if(n==0)
{
cout<<"\nI am inside the modification function. new is
empty";
getch();
cout<<"\n The file is empty. ! ";
getch();
return;
}
cout<<"\nI am inside the modification function before entering the
while loop.";
getch();
int deleteMe = 0;
while(inFile.good())
{

inFile.read((char*)&obj,sizeof(obj));
outFile.write((char*)&obj,sizeof(obj));
cout<<"\nI am inside the modification function inside the while
loop and I have finished round "<<deleteMe+1;
deleteMe = deleteMe + 1;
getch();
}
cout<<"\nI am inside the modification function just outside
the while loop.";
inFile.close();
outFile.close();
outFile.open("addressesFile",ios::trunc);
inFile.open("new");
if(inFile.fail())
{
cout<<"\n Sorry! File not found !";
exit(-1);
}
char ch;
cout<<"\n Enter the Land Line Phone Number or the Contact :";
cin>>pn;
ch=cin.get();
cin.get(ch);
for(i=0;i<n;i++)
{
inFile.read((char*)&obj,sizeof(obj));
char d;
if(pn==landLinePhone)
{
//view1();
cout<<" Name : "<<obj.contactName<<"\n";
cout<<" Home Address : "<<obj.homeAddress<<"\n";
cout<<" EMAIL ADDRESS : "<<obj.email<<"\n";
cout<<" Cellular Phone Nmber : "<<obj.cellularPhone<<"\n";
cout<<" Land Line Phone Number : "<<obj.landLinePhone<<"\n
\n";

d=check("HOUSE PHONE NUMBER ");
if((d=='y') || (d=='Y'))
{
cout<<"\n Enter the new land line phone number of the
contact, please. :";
cin>>landLinePhone;
ch=cin.get();
cin.get(ch);
}
if(check("OFFICE PHONE NUMBER ")=='Y')
{
cout<<"\n Enter the new cellular phone number of the
contact, please. :";
cin>>cellularPhone;
ch=cin.get();
cin.get(ch);
}
if(check("Name of the Contact")=='y')
{
cout<<"\n Enter the name of the contact, please. : ";
cin.getline(contactName,20,'\n');
}
if(check("HOME ADDRESS")=='y')
{
cout<<"\n Enter the new Home Address of the contact,
please. :";
cin.getline(homeAddress,50,'\n');
}
if(check("EMAIL ADDRESS:")=='y')
{
cout<<"\n Enter the new E-mail Address of the contact,
please. :";
cin.getline(email,25,'\n');
}
}//the outer if ends here.
outFile.write((char*)&obj,sizeof(obj));
}
outFile.close();
inFile.close();
}
Feb 13 '08 #1
2 1890
`Some problem' is rather vague. Anyway, here are some brief notes on
`what's wrong':

Unpopular wrote:
void directory::modification()//???????????
{
[...] -- many noisy lines ommited here and below
inFile.open("addressesFile");
outFile.open("new");
I'd guess, that file "new" is now empty and locked for writing in text mode.
n=test();
Hu?? What happens in test()?
if(n==0)
{
cout<<"\n The file is empty. ! ";
getch();
return;
Of course "new" is empty! So bye bye here?
}
while(inFile.good())
{
So let's do some _binary_ I/O on _text_ files -- good luck!
inFile.read((char*)&obj,sizeof(obj));
outFile.write((char*)&obj,sizeof(obj));
What is obj? There are _very_ strong restrinctions, if you want to use
it like that!
}
inFile.close();
outFile.close();
outFile.open("addressesFile",ios::trunc);
inFile.open("new");
for(i=0;i<n;i++)
Hu, what's n? Ahh, I see, the result of your test() above -- weird.
{
And again, binary I/O on a text file, using undefined `obj':
inFile.read((char*)&obj,sizeof(obj));
Only cowards check return values -- real programmers post in c.l.c++ :)
if(pn==landLinePhone)
What's landLinePhone? Did you mean obj.landLinePhone?
{
cout<<" Name : "<<obj.contactName<<"\n";
cout<<" Home Address : "<<obj.homeAddress<<"\n";
cout<<" EMAIL ADDRESS : "<<obj.email<<"\n";
cout<<" Cellular Phone Nmber : "<<obj.cellularPhone<<"\n";
cout<<" Land Line Phone Number : "<<obj.landLinePhone<<"\n
Ever thought of providing a suitable operator <<()? Then you may write
cout << obj;
d=check("HOUSE PHONE NUMBER ");
check()? Sorry, but I'm getting tired now.

I think, switching to binary file mode will fix one of your `some problem'.
But you should improve your coding style. And if you need more help,
you'll have to post code, that compiles and runs.

-- ralph

Feb 14 '08 #2
On Feb 14, 1:13 pm, "Ralph D. Ungermann" <use...@mloge-ungermann.de>
wrote:
`Some problem' is rather vague. Anyway, here are some brief notes on
`what's wrong':
Unpopular wrote:
void directory::modification()//???????????
{
inFile.open("addressesFile");
outFile.open("new");
I'd guess, that file "new" is now empty and locked for writing
in text mode.
First, until you test the status of outFile, you don't know
whether the open succeeded or not. If it didn't succeed, you
can't say anything about the file "new". If it did succeed,
then their is an empty file by that name---if the file existed
beforehand, you've emptied it, and if it didn't, you've created
it. (That's what the standard requires.) I can't see why it
would be locked, however.
while(inFile.good())
And of course, this is NOT the way to read a file.

(I didn't even look at the code in the original posting; it was
too big and too much of a mess to be bothered with. So I don't
really know what the OP was trying to do. But looping on
"inFile.good()" is never correct.)
{
So let's do some _binary_ I/O on _text_ files -- good luck!
inFile.read((char*)&obj,sizeof(obj));
outFile.write((char*)&obj,sizeof(obj));
What is obj? There are _very_ strong restrinctions, if you want to use
it like that!
Like: it must be an array of characters (char or unsigned char).
The cast in question is a reinterpret_cast, and any time you
need a reinterpret_cast, you should ask yourself questions.
(Although if all he does is then write it with write(), it
almost certainly doesn't matter, since read will read it as an
array of characters, and write will write it as an array of
characters. But then, why isn't it defined as an array of
characters?)

And of course, as you point out, if you really want to do binary
I/O, you need to open the files in mode binary, and imbue the
"C" locale.

--
James Kanze (GABI Software) email:ja*********@gmail.com
Conseils en informatique orientée objet/
Beratung in objektorientierter Datenverarbeitung
9 place Sémard, 78210 St.-Cyr-l'École, France, +33 (0)1 30 23 00 34
Feb 15 '08 #3

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

6
by: gonzalo briceno | last post by:
I have been using phplib for a while and I really like the framework except for form creation. Maybe it is me but I in my opinion there isn't a good way to create forms or should I say, everything...
1
by: manish | last post by:
Hi, I am a fresher in the programming field i.e although I have done programming at the basic level but at professional level I am very new and I am facing many problems. These probllems are...
3
by: fastwings | last post by:
mm the code //////makemenu.h//// class menu { public: int op; pmenu(int op,int sub = 0) { switch op {
7
by: olga | last post by:
Hi, On my site, i want to pass a javascript variable to php. I know that this needs to done in a link or in a post. I want to know if there is a way i can do it with an html link. I should...
22
by: Jeff Parker | last post by:
I have a web application that for the real estate industry. Here is one of the sites using said application. http://www.wellsre.com As you can see if you click this link here...
1
by: BigAbility | last post by:
regKey = regKey.OpenSubKey("...."); regKey.SetValue("...", "value"); this code doesn't work registry modification not allow in .Net?? how should i do?
2
by: Henry | last post by:
Hi all, I tried to install the php-5.1.4 on my server but failed. Kindly please help me. Below are what I have installed: 1) IBM Informix Dynamic Server Version 9.40.FC7 2) GNU_C_C++...
1
by: bylum | last post by:
prolem exception org.apache.jasper.JasperException at jsp the list exception : org.apache.jasper.JasperException...
3
by: usenet.tolomea | last post by:
I'm working on a remote object system, something kinda like Pyro. For the purposes of caching I need to be able to tell if a given dict / list / set has been modified. Ideally what I'd like is for...
0
by: VivesProcSPL | last post by:
Obviously, one of the original purposes of SQL is to make data query processing easy. The language uses many English-like terms and syntax in an effort to make it easy to learn, particularly for...
3
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 3 Jan 2024 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM). For other local times, please check World Time Buddy In...
2
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 7 Feb 2024 starting at 18:00 UK time (6PM UTC) and finishing at about 19:30 (7.30PM). In this month's session, the creator of the excellent VBE...
0
by: fareedcanada | last post by:
Hello I am trying to split number on their count. suppose i have 121314151617 (12cnt) then number should be split like 12,13,14,15,16,17 and if 11314151617 (11cnt) then should be split like...
0
by: stefan129 | last post by:
Hey forum members, I'm exploring options for SSL certificates for multiple domains. Has anyone had experience with multi-domain SSL certificates? Any recommendations on reliable providers or specific...
0
Git
by: egorbl4 | last post by:
Скачал я git, хотел начать настройку, а там вылезло вот это Что это? Что мне с этим делать? ...
1
by: davi5007 | last post by:
Hi, Basically, I am trying to automate a field named TraceabilityNo into a web page from an access form. I've got the serial held in the variable strSearchString. How can I get this into the...
0
by: Aftab Ahmad | last post by:
Hello Experts! I have written a code in MS Access for a cmd called "WhatsApp Message" to open WhatsApp using that very code but the problem is that it gives a popup message everytime I clicked on...
0
by: Aftab Ahmad | last post by:
So, I have written a code for a cmd called "Send WhatsApp Message" to open and send WhatsApp messaage. The code is given below. Dim IE As Object Set IE =...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.