std::string remove the last character if its a '/'

[rsennat]

hi,
how do I remove the last character in a string only if its a "/". otherwise no need to remove the last character.

im using std::string. tried with find_last_of( ).

thanks
rsennat

[rsennat]

Is this efficient,

size_t pos = Path.find_last_of("/");
if(pos == Path.length()-1)
{
    Path.erase(Path.length()-1);
}
 

hi,
how do I remove the last character in a string only if its a "/". otherwise no need to remove the last character.

im using std::string. tried with find_last_of( ).

thanks
rsennat

[weaknessforcats]

No.

You should find_last_of() and check the value of pos afterwards, it if is string::npos, the / was not found. Please do not assume that -1 means not found.

Otherwise, the / was found and you can erase the character at the location where it was found:

string::size_type pos = Path.find_last_of("/");
if(pos !=string::npos)
{
    Path.erase(pos);
}
 

[mvidelgauz]

Sorry weaknessforcats, it seems that you didn't understand rsennat's question.

The question was about about last character in a string whatever it is and not about last occurrence of '/' character. You code will remove '/' even if it is found in the middle of string.

The correct code is:

if (path.length() > 0)
{
    std::string::iterator it = path.end() - 1;
    if (*it == '/')
    {
         path.erase(it);
    }
}