Segmentation Fault in Simple C Program

[parkskier]

Ok, so I got a segmentation fault when I tried to run the program I created. I understand what this error means, but I don't know where it is. If someone can quickly look through my code and point it out that'd be great. BTW, the code isn't completely finished (ie the file to write on isn't being written on yet) but this doesn't effect this segmentation fault as far as I know.

I'm using Linux Red Hat to run the program and Emacs to compile it.

Syntax:

void swap (float *a, float *b);
 
int main ( )
{
 
  float diam[20], a, b;
  int swap_count=0, n;
 
  FILE *fptr1, *fptr2;
  fptr1=fopen("a10.dat", "r");
  fptr2=fopen("a12.txt", "w");
 
  fscanf(fptr1,"%f", &diam[n]);
 
do
  {
    for(n=0; n<=19; n++)
      {
    diam[n]=a;
    diam[n+1]=b;
    if(a>b)
      {
        swap_count++;
        void swap (float a, float b);
      }
    else
      {
        a=a;
        b=b;
        swap_count=0;
      }
      }
  }while(swap_count>=1);
 
 printf("Diameter=%f\n", diam[n]);
 
 
      fclose (fptr1);
      fclose (fptr2);
}
 
void swap (float *a, float *b)
{
  float temp;
 
  temp=*a; *a=*b; *b=temp;
 
}

[Ganon11]

This may not be causing your segfault, but when using the swap function, you should not say "void swap(float a, float b);" This is creating a new function named swap that takes two floats as arguments. You should instead use "swap(a, b);", which will actually use the swap function you created with your variables a and b.

[weaknessforcats]

It's right here:

for(n=0; n<=19; n++)
{
diam[n]=a;
diam[n+1]=b;
etc...\

When n is 19, then n+1 is 20. Your array is 20 which means the largest index is 19. That is, diam[20] is outside your array bound.

Hence the seg fault.

[parkskier]

So to fix that I should just replace the n<=19 with a different number such as....err...20? I'm not exactly sure how to fix this.

I tried different numbers in place of 19 (such at 18-21) and still get the segmentation fault.

[kalegs]

i am not sure what you are trying to achieve...but i guess
24. void swap (float a, float b); should be swap(&a,&b)

[saikatkolkata]

1. u haven't initialized 'a' and 'b' so in the for loop..it should be
a=diam[n];
b=diam[n+1];

2. function swap(&a,&b);

[parkskier]

The program is supposed to read in 20 values from a file and put them in an array. Then it is supposed to sort these values from smallest to largest using the swap function to compare individual values and change them.

I tried do what was listed above but to no avail. The error I get when I change void swap (float a, float b) to swap (&a, &b) is this:

error: cannot convert `float*' to `float' for argument `1' to `voidswap(float, float)'

Help?

[weaknessforcats]

tried different numbers in place of 19 (such at 18-21) and still get the segmentation fault.

Your calculated index value must be in the range 0-19. Those are your 20 array elements.

error: cannot convert `float*' to `float' for argument `1' to `voidswap(float, float)'

I have no idea what that's about. It compiles fine for me as swap(&A,&b).

That error looks like you have swap that has float arguments and not float* arguments. You didn't change that and not tell us, did you??

[Arulmurugan]

The program is supposed to read in 20 values from a file and put them in an array. Then it is supposed to sort these values from smallest to largest using the swap function to compare individual values and change them.

I tried do what was listed above but to no avail. The error I get when I change void swap (float a, float b) to swap (&a, &b) is this:

error: cannot convert `float*' to `float' for argument `1' to `voidswap(float, float)'

Help?

Hi,
the program will not suppose to do, what you expected, i am seeing lot of mistake here.
1)
fscanf(fptr1,"%f", &diam[n]);
what will happen ,when "n" is a junk val, because not inited.

2) what are you tring to achive
diam[n]=a;
diam[n+1]=b;
3) Wrong statement
void swap (float a, float b);
Different compiler may say different error, but it is not valied atleast here.
4) what are you doing here..
a=a;
b=b;
i hope now you know , what is you requiremnet , so write write your own code.

Regards
Arul