C++ - Programming Tic Tac Toe Win32 Console Application

[vpascuzzi]

Hey folks,

Thought I could use some help with this. I have the basic foundation around the app, but cannot seem to get things working correctly.

Can someone have a look at the code below and help me to tweak it to get it working correctly?


Thanks in advance,

VPascuzzi.

// TicTacToe.cpp : Defines the entry point for the console application.
//
 
#include "stdafx.h"
#include <cctype>
#include <conio.h>
#include <iostream>
#include <iomanip>
//#include <stdlib.h>
using std::cin;
using std::endl;
 
// Function Prototypes
int Display_Grid( int* Cells );  // Displays tic tac toe grid; refreshed every turn
int Check_Game_State( int* Cells );  // Tracks game status to determine WIN, LOSE, TIE, CONTINUE
int Machine_Move( int* Cells );  // AI computer move
int Open_Spots( int* Cells );  // Function to display open cells
 
int _tmain(int argc, _TCHAR* argv[])
{
    int Player1_Move = NULL; // Player1 move temporary storage
    int Cells[9] = { NULL };  // Array for storing cell contents
    int Open_Cells[9] = { NULL };  // Array for storing list of open cells
    int Game_State_Flag = 0;  //{ "CONTINUE", "WIN", "LOSE", "DRAW" );
 
    for ( int Move_Counter = 0; Move_Counter < 9; Move_Counter++ ){
        Display_Grid( Cells );
        Open_Spots( Open_Cells );
 
        printf( "\nPlayer please select a number from 1 - 9: " );
        cin >> Player1_Move;
 
        Open_Cells[Player1_Move-1] = 1;
        Cells[Player1_Move-1] = 79;
 
        Open_Cells[Machine_Move( Cells )];        // CPU makes move depending on Cells[] values
 
        system( "CLS" );
    }
    return 0;
}
 
// Function Definitions
int Display_Grid( int* Cells ){
        printf( " %c | %c | %c \n", Cells[0], Cells[1], Cells[2]);
        printf( "---+---+---\n");
        printf( " %c | %c | %c \n", Cells[3], Cells[4], Cells[5]);
        printf( "---+---+---\n");
        printf( " %c | %c | %c \n", Cells[6], Cells[7], Cells[8]);
 
    return 0;
} // end Display_Grid function definition
 
int Check_Game_State( int* Cells ){
 
    return 0;
}// end Check_Game_State function definition
 
int Machine_Move( int* Cells ){
    for ( int i = 0; i < 9; i++ ){
        for ( int j = 1; j <= 9; j++ ){
            if( ( Cells[i+j] == NULL ) && ( Cells[i] + Cells[j] == 158 ) )
                Cells[i+j] = 88;
        }
    }
    return *Cells;
} // end Machine_Move function definition
 
/* Fix this function
   It currently checks the Cells array incorrectly.*/
int Open_Spots( int* Cells ){
    printf( "Open spots remaining:\n" );
    for ( int i = 1; i <= 9; i++ ){
        if ( Cells[i-1] == NULL )
            printf( " %d ", i );
    }
    return *Cells;
}
 

[Laharl]

Try returning a pointer to the array, with &Cells. The return type would be int**.

There's also no need to have these int functions (like display) return 0 when they can be void, especially since there is no exception handling to take advantage of return states.

Also, what's up with all these nonstandard headers? I don't know 'stdafx.h', but conio has a pretty bad reputation.

[Savage]

int Player1_Move = NULL; // Player1 move temporary storage

Can you explain me what is this supposed to do?
Also please explain your problem in greater detail.By telling I'm having a problem and not specifying what it is,make as guess things,instead of being able to accurately help you.It's recommended to read our posting guidelines,especially the part where it's described how to post accurate question.

[Studlyami]

What exactly is your problem? Heres a few things i see.

for ( int Move_Counter = 0; Move_Counter < 9; Move_Counter++ ){
Display_Grid( Cells );
Open_Spots( Open_Cells );

int Check_Game_State( int* Cells ) {

return 0;
}// end Check_Game_State function definition

The game can end before 9 moves. So you need to have an array that checks all rows, then all columns (straight across, then straight drown) to see if the cells equal x or o. Then you need to check the diagonals to see if any of the two diagonals is equal to 3 x's or o's. This needs to go in the Check_Game_State function. That means you would need to change you main loop to a do while loop. I would create a boolean value to keep track if the game is finished or not (used in the loop i described above). The Check_Game_State function should return the boolean value used in the loop i described above.

int Cells[9] = { NULL }; // Array for storing cell contents

If your storing the cells and setting them to NULL then if a Cell == NULL the cell is open. The open cell array is not needed.

Also I'm not quite sure what your logic is behind the machine move function mind explaining that one a little bit better? Anyways i hope this helps. If any of this is unclear let me know.