gets() problem

[Barbosapt]

I have this global variable:

...
typedef struct{
    int numero;
    char nome[200];
    char morada[200];
    int contacto;
} Cliente;
Cliente clientes[2000];
...
 

and this part of code:

void adiccionarCliente(){
    char nomeCliente[200];
    char moradaCliente[200];
    int contactoCliente=0;
 
 
    printf("Introduza o nome do cliente:\n");
    gets(nomeCliente);
    strcpy(clientes[numeroCliente].nome, nomeCliente);
....
}
 

But when i run the program it just skips that gets(nomeCliente) and dont ask me for a nomeCliente.
Sorry about my variable aren't in english.
If you could help i would be gratefull.
Thank you, Barbosa.

[Savage]

It jumps both printf and gets?
Have you tried flushing the streams?

[Barbosapt]

It jumps both printf and gets?
Have you tried flushing the streams?

only skips gets...and yes same problem even with flush

[Barbosapt]

I have this after:

...
printf("Introduza a morada do cliente:\n");
    gets(moradaCliente);
    strcpy(clientes[numeroCliente].morada, moradaCliente);
...
 

and it works...

[oler1s]

Do not use gets. Use fgets.

gets is kept around for historical uses, but it has been marked in documentation and on numerous forums as a "Do not use under any circumstances".

gets has absolutely no bounds checking on input.

[Barbosapt]

...
printf("Introduza o nome do cliente:\n");
    fgets(nomeCliente,200,stdin);
    strcpy(clientes[numeroCliente].nome, nomeCliente);
...
 

same problem

[weaknessforcats]

Can you post the code that calls adiccionarCliente() ??.

I want to be sure you are calling the function in the first place because I compiled and ran your code using Visual Studio.NET 2005 and it worked.

[Barbosapt]

void menuPrincipal(){
    int opcao=0;
    printf("Escolha uma opccao:\n");
    printf("1 Atender Cliente\n");
    printf("2 Adiccionar Cliente\n");
    printf("3 Editar Cliente\n");
    printf("4 Estatisticas\n");
    printf("0 Sair\n");
    do {
        scanf("%i",&opcao);
        switch (opcao){
            case 1:
                atenderCliente();
                break;
            case 2:
                adiccionarCliente();
                break;
            case 3:
                editarCliente();
                break;
            /*case 4:
                estatisticas();*/
            case 0:
                return;
                break;
            default:
                printf("Erro: a opcao escolhida nao existe!\n");
                printf("Escolha uma opcao:\n");
                break;
        }
    } while(opcao<0||opcao>4);
    return;
}
 

[Savage]

Both of these functions(gets and fgets) on error or EOF returns NULL.Have you checked to see whether this functions passes or not?

Also,I'm not suggesting that following is a good solution but it might work:

You said that next call to gets worked,so have you tried to put another call to gets(or fgets) after that one?

[oler1s]

Your code confirms my suspicions. Let’s work backwards, to see how one might diagnose the problem. Remember that information about the various C functions can be found in documentation, easily googled. Problem: fgets seems to be skipped.

What does fgets do? It extracts from the file stream (in your case stdin) until it reaches a newline. Then it returns. So perhaps fgets isn’t being skipped, but is returning right away. Why would it do that? Perhaps because there is something already in stdin. Since it’s returning right away, it stands to reason there is a newline left in stdin. So let’s work through our previous I/O operations and see what might involve putting a newline in stdin.

And we see scanf. How does scanf work? It takes input from the user. Then it attempts to parse the input into various tokens you specify. In your case, you want the user to type in a number. So let’s say I type in 4. Since I also hit the enter key, what we really have is 4\n. Now, scanf parses that input, and extracts 4. And it leaves everything else alone. So stdin now contains \n. And when you call fgets, it picks out the \n and returns immediately.

Wrong solution: fflush(stdin). Flushing is only defined for output streams. Not input.

Solution 1: Change your scanf to fgets, and manually convert it to an integer.
Solution 2:

int ch = 0;
while((ch = getc(stdin)) != EOF && ch != '\n');
 

That is how you “flush” stdin.

[Barbosapt]

Both of these functions(gets and fgets) on error or EOF returns NULL.Have you checked to see whether this functions passes or not?

Also,I'm not suggesting that following is a good solution but it might work:

You said that next call to gets worked,so have you tried to put another call to gets(or fgets) after that one?

That worked thank you Savage.

oler1s thanks too...but im too lazy to do that :P

[sicarie]

oler1s thanks too...but im too lazy to do that :P

Goal in life to be featured in thedailywtf.com?

Otherwise, I'd say put the effort in now. Then you'll learn it, and it won't take effort, you'll know to design it that way instead of changing it later (or finding other odd errors later).

[mikh]

Your code confirms my suspicions. Let’s work backwards, to see how one might diagnose the problem. Remember that information about the various C functions can be found in documentation, easily googled. Problem: fgets seems to be skipped.

What does fgets do? It extracts from the file stream (in your case stdin) until it reaches a newline. Then it returns. So perhaps fgets isn’t being skipped, but is returning right away. Why would it do that? Perhaps because there is something already in stdin. Since it’s returning right away, it stands to reason there is a newline left in stdin. So let’s work through our previous I/O operations and see what might involve putting a newline in stdin.

And we see scanf. How does scanf work? It takes input from the user. Then it attempts to parse the input into various tokens you specify. In your case, you want the user to type in a number. So let’s say I type in 4. Since I also hit the enter key, what we really have is 4\n. Now, scanf parses that input, and extracts 4. And it leaves everything else alone. So stdin now contains \n. And when you call fgets, it picks out the \n and returns immediately.

Wrong solution: fflush(stdin). Flushing is only defined for output streams. Not input.

Solution 1: Change your scanf to fgets, and manually convert it to an integer.
Solution 2:

int ch = 0;
while((ch = getc(stdin)) != EOF && ch != '\n');
 

That is how you “flush” stdin.

You are my hero! Now, why didn't I think about that earlier? Thank you soooooo much :-*