Use of fscanf

[dn6326]

Hi, basically im trying to read in a file that represents a matrix, where the first line is in the format of <number of rows> <number of collumns> then all lines after that follow the format
<row> <col> <value> i.e. the file would look like
2 2
1 1 2
1 2 3
would represent the matrix
| 2 3 |
| 0 0 |

im having trouble using fscanf to read the numbers into a 2d array. I get a bus error when I try to fscanf the second line, Ive used ftell to check the position of the stream and it seems to be in the right place but it never works. My code looks like this:

int main (int argc, char * argv[])
{
FILE *file;
file = fopen(argv[1], "r");

int rows, cols, x, y, z;
fscanf(file, "%d %d", &rows, &cols);

int matrix[rows][cols];

fscanf(file, "\n%d %d %d", x, y, z); //this is where the problem is.

fclose(file);
}

many thanks

Dan

[weaknessforcats]

Read this and posty again of you still have problems:

First, there are only one-dimensional arrays in C or C++. The number of elements in put between brackets:

int array[5];
 

That is an array of 5 elements each of which is an int.

int array[];
 

won't compile. You need to declare the number of elements.

Second, this array:

int array[5][10];
 

is still an array of 5 elements. Each element is an array of 10 int.

int array[5][10][15];
 

is still an array of 5 elements. Each element is an array of 10 elements where each element is an array of 15 int.

int array[][10];
 

won't compile. You need to declare the number of elements.

Third, the name of an array is the address of element 0

int array[5];
 

Here array is the address of array[0]. Since array[0] is an int, array is the address of an int. You can assign the name array to an int*.

int array[5][10];
 

Here array is the address of array[0]. Since array[0] is an array of 10 int, array is the address of an array of 10 int. You can assign the name array to a pointer to an array of 10 int:

int array[5][10];
 
int (*ptr)[10] = array;
 

Fourth, when the number of elements is not known at compile time, you create the array dynamically:

int* array = new int[value];
int (*ptr)[10] = new int[value][10];
int (*ptr)[10][15] = new int[value][10][15];
 

In each case value is the number of elements. Any other brackets only describe the elements.

Using an int** for an array of arrays is incorrect and produces wrong answers using pointer arithmetic. The compiler knows this so it won't compile this code:

int** ptr = new int[value][10];    //ERROR
 

new returns the address of an array of 10 int and that isn't the same as an int**.

Likewise:

int*** ptr = new int[value][10][15];    //ERROR
 

new returns the address of an array of 10 elements where each element is an array of 15 int and that isn't the same as an int***.

With the above in mind this array:

int array[10] = {0,1,2,3,4,5,6,7,8,9};
 

has a memory layout of

0 1 2 3 4 5 6 7 8 9

Wheras this array:

int array[5][2] = {0,1,2,3,4,5,6,7,8,9};
 

has a memory layout of

0 1 2 3 4 5 6 7 8 9

Kinda the same, right?

So if your disc file contains

0 1 2 3 4 5 6 7 8 9

Does it make a difference wheher you read into a one-dimensional array or a two-dimensional array? No.

Therefore, when you do your read use the address of array[0][0] and read as though you have a
one-dimensional array and the values will be in the correct locations.