CTString in detour function

[iam_clint]

Ok the issue is I am reverse engineering a game (I use IDAPRO) and detouring a function. This function happens to be AddChatMessage(uchar,long,CTString,CTString)
I have the detour working its running to my function But i can't seem to figure out how to get CTString into a readable text

FARPROC WINAPI myAddChatMessage(char *char1,long long1,char *String1, char *String2)
{
    char szTemp[1024];
    std::string str1 = String1;
    std::string str2 = String2;
    sprintf(szTemp, "string: %s string2: %s",str1.c_str(),str2.c_str());
    MessageBox(NULL,szTemp,"Add Chat Message Function",MB_OK);
    return false;
}
 

The Reverse Engineered Function

AddChatMessage(uchar,long,CTString &,CTString &)
 

I have tried several different approaches this just happened to be the last one I tried. So if someone could please shed some light on this all help would be appreciated.

[RedSon]

Ok the issue is I am reverse engineering a game (I use IDAPRO) and detouring a function. This function happens to be AddChatMessage(uchar,long,CTString,CTString)
I have the detour working its running to my function But i can't seem to figure out how to get CTString into a readable text

FARPROC WINAPI myAddChatMessage(char *char1,long long1,char *String1, char *String2)
{
    char szTemp[1024];
    std::string str1 = String1;
    std::string str2 = String2;
    sprintf(szTemp, "string: %s string2: %s",str1.c_str(),str2.c_str());
    MessageBox(NULL,szTemp,"Add Chat Message Function",MB_OK);
    return false;
}
 

The Reverse Engineered Function

AddChatMessage(uchar,long,CTString &,CTString &)
 

I have tried several different approaches this just happened to be the last one I tried. So if someone could please shed some light on this all help would be appreciated.

It could be that your string needs to be a wide char. You will need to make szTemp, str1, str2 all into wide chars (wchar_t or TCHAR) then use a wide printf method, if memory servers I think you want wsprintf but you'll need to double check.

[weaknessforcats]

You need to use the TCHAR mappings. You cannot use char, wchat_t, sprintf, etc in Windows code. Try:

FARPROC WINAPI myAddChatMessage(PCHAR char1,long long1,PCHAR String1, PCHAR String2)
{
    TCHAR szTemp[1024];
//could be either string or wstring based on the character set
//STL is incompatible with TCHAR. You will need your own #define
//to toggle between string and wstring based on Unicode defined or not.
//
    //std::string str1 = String1;
    //std::string str2 = String2;
    _stprintf(szTemp, TEXT("string: %s string2: %s"),String1,String2);
    MessageBox(NULL,szTemp,TEXT("Add Chat Message Function"),MB_OK);
    return false;
}
 

MessageBox is also a TCHAR mapped function toggling between MessageBoxA and MessageBoxW.

Read http://msdn2.microsoft.com/en-us/library/ms860358.aspx.