Loop not working in assignment

[pdring]

Hi everyone,
I have had a look through the site but can't find anything to help with a little problem i am experiencing with a college assignment. I wonder if anyone would like to help out?

My assignment is : the program should prompt the operator to enter the number of contracts negotiated this week.
After all data has been entered, the program should display the following information for each employee:
Number of contracts negotiated
Total pay
Tax payable
Net pay
It should also display the following overall data:
Total number of contracts negotiated
Total amount of pay
Total tax deducted

I have declared the following structure

struct employeeInfo
{
char name [20];
char job [20];
int basicPay;
int taxAllowance;
int totalContracts;

};
struct employeeInfo employee[noEmployees];

i have declared the number of employees as 5, and for each of the 5 employees i have written:

strcpy (employee[0].name, "John Nixon");
strcpy ( employee[0].job, "Team Leader");
employee[0].basicPay = 320;
employee[0].taxAllowance = 5750;

although for each employee ([0] to [4]),the data is different.

The code i have written works perfectly when it comes to displaying info about the individual employees but the only way i can display info about all the employees e.g. total contracts, is to write a line like this:

overallContracts = employee[0].totalContracts + employee[1].totalContracts + employee[2].totalContracts + employee[3].totalContracts + employee[4].totalContracts;

this works fine but seems clumsy to me and also, using this method it seems impossible to find the correct way of obtaining the total tax payable, as each employee has a different tax allowance that must be divided by 52 (weeks) and subtracted from their total pay! Imagine how long that calculation would be if we were dealing with a lot of employees.
I have tried a few attempts at putting some combinations through a for loop (using a count variable), but they all seem to throw back incorrect figures.
Can anyone point me in the right direction to find a solution ?
thanks for any help,
Phil Dring (Cornwall)

[scruggsy]

I have tried a few attempts at putting some combinations through a for loop (using a count variable), but they all seem to throw back incorrect figures.
Can anyone point me in the right direction to find a solution ?

That's the way to do it, with a loop.
Why don't you post your non-working loop code so we can figure out the problem?

[pdring]

That's the way to do it, with a loop.
Why don't you post your non-working loop code so we can figure out the problem?

Hi, thanks for replying. first I have inserted the for loop that does work for each employee:

for (count = 0;count <noEmployees; count++)
          {
           if (employee[count].totalContracts > 5)
                totalPay =  employee[count].totalContracts + 100;  /* bonus £100 for over 5 contracts*/
 
          totalPay = employee[count].basicPay + (employee[count].totalContracts * 25); /*bonus £25 for each contract*/
          weeklyTaxAllowance = (employee[count].taxAllowance / 52);   /*allowed to earn this befor tax is deducted*/
          taxpayable = (totalPay - weeklyTaxAllowance)* vatRate; /*- weeklyTaxAllowance;  */
          netPay = totalPay - taxpayable;   /* take home pay*/
 
          printf ("\n%s\n\nContract(s) negotiated\t %d\nTotal Pay\t\t œ%0.2f\nTax Payable\t\t œ%0.2f\nNet Pay\t\t\t œ%0.2f ", employee[count].name, employee[count].totalContracts, totalPay,taxpayable, netPay);
          printf ("\n--------------------------------------------------------------");

}

this is the for loop that does not work:

 for (count = 0;count <noEmployees; count++)
          {
          overallContracts =  employee[count].totalContracts;     /* to find the total amount of contracts*/
          overallTotalPay = (employee[count].basicPay + (employee[count].totalContracts * 25));  /* to find the total amount of pay inc. £25 bonus for each contract*/
          overallTaxpayable = (employee[count].basicPay + (employee[count].totalContracts * 25)- (employee[count].taxAllowance / 52)* vatRate);/*to find tax payable by all staff*/
          }

thanks for looking, any help will be appreciated
Phil.

[oler1s]

Look at the equations in your non-working for loop. You have something = employeedata right? But you aren't just repeatedly setting overalltaxPayable equal to something.

You are repeatedly adding to it. Use the += operator, not the = operator.

[pdring]

Look at the equations in your non-working for loop. You have something = employeedata right? But you aren't just repeatedly setting overalltaxPayable equal to something.

You are repeatedly adding to it. Use the += operator, not the = operator.

Thankyou so much, I have now learned to look over the basics before trying to find complicated answers!!