strange ) expected error

[drsmooth]

i have this code in the header of one of my classes:

bool hasWorker;
void assignWorker(Civilian *);
Civilian *myWorker;

is something wrong with that that i am not noticing i keep getting a :

[C++ Error] Job.h(19): E2293 ) expected

on the void assignWorker(Civilian *); line...

the civilian class was included at the top of the header as so:

#ifndef Job_h
#define Job_h
 
#include <iostream>
#include <string>
#include <vector>
#include "Civilian.h"

im actually experiencing a similar problem in the Civilian class here:

   void giveJob(Job *);
   void advanceTask();

they accomplish similar things so i assume the problem may be related?

thanks
ken

[Meetee]

i have this code in the header of one of my classes:

bool hasWorker;
void assignWorker(Civilian *);
Civilian *myWorker;

is something wrong with that that i am not noticing i keep getting a :

[C++ Error] Job.h(19): E2293 ) expected

on the void assignWorker(Civilian *); line...

the civilian class was included at the top of the header as so:

#ifndef Job_h
#define Job_h
 
#include <iostream>
#include <string>
#include <vector>
#include "Civilian.h"

im actually experiencing a similar problem in the Civilian class here:

   void giveJob(Job *);
   void advanceTask();

they accomplish similar things so i assume the problem may be related?

thanks
ken

What about Civilian? Is it defined? Is there any other error along with this?

[drsmooth]

the Civilian class is defined with a header and cpp files and every function is defined in the cpp.

im getting other errors but theyre all after that one and it seems the ) expected is causing the other two...

[drsmooth]

i noticed a peculiar thing happening maybe someone could explain... all my code compiles perfectly fine until i include the civilian header.

   void giveJob(Job &);
   void advanceTask();
   Job myJob;

that code works just fine and compiles but as soon as i add:

#include "Civilian.h"

to the Job class header,

void giveJob(Job &);

gives me this error:

[C++ Error] Civilian.h(29): E2293 ) expected


may it have something to do with methods set up to take each other as parameters?

e.g i have a
giveJob(Job&);
in the civilian class, and i have a assignWorker(Civilian *) in the job class

could that be thr problem? i seem to think it cant be...

[weaknessforcats]

Do you have a null line at the end of Civilian.h??

You may have to post your header so we can see what line 29 is about. The error is there or earlier in the file.

[drsmooth]

the contens of my civilian header are as follows:

#ifndef Civilian_h
#define Civilian_h
#include <iostream>
#include <string>
#include "Job.h"
using namespace std;
class Civilian
{
  public:
   static long nextID;
//-------------------------
//--constructors-----------
   Civilian();
   Civilian(int);
//-------------------------
//--public member variables
   long myID;
   bool isAlive, hasJob, hasHouse;
   int daysWithoutFood;
   string pronoun;
//------------------------------------
//--methods involved in daily activity
   void age(int);
   bool eat(int,int);
   void advanceDay();
   void satisfy(int);
//--------------------------------
//--methods involved in working
   void giveJob(Job &);
   void advanceTask();
   Job myJob;
//--------------------------------
//--methods to access private members
   const string getName(){return name;}
   const string getCivString();
   const int getSatisfaction(){return satisfaction;}
  private:
//--identification
   void assignName();
   string name;
   char gender;
   int ageDays,ageMonths,ageYears;
//--statistical
   long totalFoodConsumed;
//--pertinant to other calculations
   int satisfaction;
  public:
   static string itos(int);
   string getAgeMDY();
   string getIsEmp();
};
#endif
 

[weaknessforcats]

I compiled OK using your Civilian.h and this main() with Visual Studio.NET 2005:

int main()
{
     bool hasWorker;
     void assignWorker(Civilian *);
     Civilian *myWorker;
 
}
 

All I had to do was create an empty class Job.

I did get a warning here:

const int getSatisfaction(){return satisfaction;}
 

A function that returns an int does not need to make that int a const. The compiler ignores the const. Only when you return a pointer or a reference does this make sense.

So I don't know where that leaves you.

[drsmooth]

the strange thing is the error is a ') expected' i feel like that should be a syntax error but i dont see that there is any problem...

i've tried changing just about anything related to this functoin and the error goes away when i remove the #include "Civilian.h" from the job class

its just strange....

[weaknessforcats]

Maybe it's time to look at your Job.h.

[drsmooth]

would you like me to post it? or was that a directive to look at it myself?


i looked it over and nothing looked bad to me but if i knew what the problem was i wouldnt have to bother you guys...

[weaknessforcats]

Post it. I'm curious now.

I intend to compile your code using Visual Studiuo.NET 2005.

[drsmooth]

#ifndef Job_h
#define Job_h
 
#include <iostream>
#include <string>
#include <vector>
#include "Civilian.h"
using namespace std;
using std::vector;
 
class Job
{
  public:
    Job(string, int);
    Job();
    void accomplishTime();
    string getName();
    string getActiveTask();
    bool hasWorker;
   Civilian *myWorker;
  private:
    void analyzeDataFile();
    int destination, pos, taskCount;
    vector<int> taskTimes;
    vector<string> taskNames;
    int goodsPerCycle, startDelay, taskTimeRemaining;
  public:
    int activeTask;
    string jobName;
};
#endif

this is the original version, i had to comment out line 20 because i gave me this error:

[C++ Error] Job.h(20): E2303 Type name expected

i use borland c++ builder

thanks alot

[weaknessforcats]

Line 20 is Civilian* myWorker and your compiler is complaining that Civilian is not a type. That is, the compiler has not seen the Civilian class yet.

This is caused by including Job.h inside Civilian.h. The Job.h is included before the Civilian class declaration.

Use a forward reference in your Job.h:

class Civilian;  //forward reference
class Job{
{
   Civilian* myWorker;
};
 

and the error will go away. The forward refercence is enough information for the compiler to allow a Civilian*. More than that, and you will need the entire Civilian class declaration.

[drsmooth]

what would that "forward reference" do? how do they work?

that will probably fix the other problems i was having as well

thank you

[weaknessforcats]

The rule is: You cannot use a type before you declare it.

Therfore this code:

class Job
{
    Civilian* myWorker;
};
 

cannot compile unless you have declared Civilian as a type already. You do this by preceding this code with the struct or class definition of Civilian.

However, if all you need is a Civilian*, then rthe compiler does not need to see the actual struct/class declaration. You can abbreviate by:

class Civilian;   //forward reference
class Job
{
    Civilian* myWorker;
};
 

This forward reference tells the compiler that there is a struct/class Civilian but it hasn't been encountered yet. That assurance is enough for the compiler to allow a Civilian*.

You need this in those situations where class Job has a Civilian* and class Civilian has a Job*. Not that this is your case but without the forward reference this situation could never be compiled.

[drsmooth]

ok yea that definitely fixed the problems...thanks alot