LPCTSTR to char* in _UNICODE project

[justin001]

In my _UNICODE & _MBCS build project, I have LPCTSTR string (i.e.it will be wchar_t*) .The following function is not giving proper result and instead it is producing junk data.

I have confirmed it with writing the resultant data in to the file(not printing it on console).The actual requirement of this function was to convert LPCTSTR to char* since I want the resultant string in character buffer.

Can anyone please correct me what I have done wrong in it?


(e.g. val points to "c++ では、偉大な言語である。")

char* conversion(LPCTSTR val)
{
 LPCWSTR wstr = val; 
 int count = wcslen(wstr);
 char* c = new char[count + 1]; 
 wchar_t* pwchr = const_cast<wchar_t*> (&wstr[0]);
 for(int j = 0; j < count; ++j)
 {
    c[j] = static_cast<char> (*pwchr);   
    pwchr++;
 }    
 c[count] = '\0';  
 wchar_t *op; 
 wcstombs(c,val,count);
 return c;
}
 

Thanks in advance !

[xoinki]

hi,
you cant do this.

c[j] = static_cast<char> (*pwchr);
 

instead use WideCharToMultiByte() function using CP_UTF8 to convert the data to utf8 and handle it properly..
remember.. wchar_t is UNICODE i.e 2 byte strings, if u r trying to get that in char means it is single byte.. so your program is not working.. if u use the above function, 2 byte string will be represented in multibyte format thereby u can copy to char * successfully.

Regards,
Xoinki

[justin001]

Hi xoinki,

Thanks for your immediate reply.
I changed my code but still not satisfied with the output...Instead of junk data which I got earlier, now I am getting"?????????????"

char* conversion(LPCTSTR val)
{
char *ansistr;
 
int lenW = _tcslen(val);
int lenA = ::WideCharToMultiByte(CP_ACP, 0, val, lenW, 0, 0, NULL, NULL);
if (lenA > 0)
{
    ansistr = new char[lenA + 1]; // allocate a final null terminator as well
    WideCharToMultiByte(CP_ACP, 0, val, lenW, ansistr, lenA, NULL, NULL);
    ansistr[lenA] = 0; // Set the null terminator yourself
}
else
{
AfxMessageBox(_T("Error!"));
}
char* c = new char[lenA + 1]; 
strcpy(c,ansistr);
//...use the strings, then free their memory:
delete[] ansistr;
 
  return c;
}
 

Please correct me if I am wrong at any place....

Thanks

[sicarie]

justin001-

A small aside - if you could read the box to the right when replying or creating a post, and use the code tags (also available here), it would be greatly appreciated and help your code be more readable.

Thanks!

[justin001]

justin001-

A small aside - if you could read the box to the right when replying or creating a post, and use the code tags (also available here), it would be greatly appreciated and help your code be more readable.

Thanks!

I understood my mistake.

Thanks!

[sicarie]

Oh, it's not a mistake at all - it's just something that helps the people reading your posts a great deal.

Thanks!

[xoinki]

hi justin,
1) plz check whether your OS supports chinese language fonts.. if it is not installed install it.
2) you are trying to convert into multibyte format, using CP_ACP.. nothing but ANSI codepage.. which does not support chinese/japanese/korean etc. you need to use CP_UTF8 instead as i suggested earlier.

Thnx and regards
xoinki

[justin001]

hi justin,
2) you are trying to convert into multibyte format, using CP_ACP.. nothing but ANSI codepage.. which does not support chinese/japanese/korean etc. you need to use CP_UTF8 instead as i suggested earlier.
Thnx and regards
xoinki

Hi xoinki,
You were absolutely right and even I changed it to CP_UTF8

Thank You very much, the question is resolved now.