Access violation

[jewel87]

Hello,
I am working on a program with several classes. It is for storing employee data.
I enter all data in the edit boxes in my form, then press a button create new employee and it should store this data in the memory and display in labels.
The problem is i am getting an access violation exception at inputting the data into one of the objects.
Here is the function for the button:

void __fastcall TForm1::CreateEmployeeButtonClick(TObject *Sender)
{
        theEmployeeList.addEmployee(i, Size);
 
        theEmployeeList.getEmployee(i)->create(EnterEmployeeName,
                                              EnterEmployeeSurname,
                                              EnterEmployeeSocialNumber,
                                              EnterEmployeeSalary,
                                              EnterHouseName,
                                              EnterHouseNo,
                                              EnterStreet,
                                              EnterTown,
                                              EnterPostCode,
                                              EnterCountry,
                                              EnterDOBdate,
                                                EnterDOBmonth,
                                                EnterDOByear,
                                                EnterEmploymentStartDate,
                                                EnterEmploymentStartMonth,
                                                EnterEmploymentStartYear,
                                                EnterBankCode,
                                                EnterAccountNo,
                                                EnterBalance,
                                                EnterBankName,
                                                EnterRate,
                                                EnterOverdraftLimit,
                                                EnterConditions);
 
        theEmployeeList.getEmployee(i)->display(NameField,
                                              SurnameField,
                                              SocialNumberField,
                                              SalaryField,
                                              AddressMemo,
                                              DOBLabel,
                                              EmploymentStartDateLabel,
                                              BankCodeLabel,
                                              AccountNoLabel,
                                              BalanceLabel,
                                              BankNameLabel,
                                              RateLabel,
                                              OverdraftLimitLabel,
                                              ConditionsLabel);
 
}
 

The addEmployee function:

void EmployeeList :: addEmployee(int &i, int &SIZE)
{
        i = SIZE;
        myEmployeeList.push_back(Employee());
        SIZE++;
        ListSize = SIZE;
}
 

The create function for employee:

void Employee :: create(TEdit *EnterEmployeeName,
                        TEdit *EnterEmployeeSurname,
                        TEdit *EnterEmployeeSocialNumber,
                        TEdit *EnterEmployeeSalary,
                        TEdit *EnterEmployeeHouseName,
                        TEdit *EnterEmployeeHouseNo,
                        TEdit *EnterEmployeeStreet,
                        TEdit *EnterEmployeeTown,
                        TEdit *EnterEmployeePostCode,
                        TEdit *EnterEmployeeCountry,
                        TEdit *EnterDOBdate,
                        TEdit *EnterDOBmonth,
                        TEdit *EnterDOByear,
                        TEdit *EnterEmploymentStartDate,
                        TEdit *EnterEmploymentStartMonth,
                        TEdit *EnterEmploymentStartYear,
                         TEdit *EnterBankCode,
                         TEdit *EnterAccountNo,
                         TEdit *EnterBalance,
                         TEdit *EnterBankName,
                         TEdit *EnterRate,
                         TEdit *EnterOverdraftLimit,
                         TEdit *EnterConditions)
{
        //save data for the employee
        FirstName = EnterEmployeeName->Text;
        Surname = EnterEmployeeSurname->Text;
        Salary = StrToInt(EnterEmployeeSalary->Text);
        SocialNumber = StrToFloat(EnterEmployeeSocialNumber->Text);
 
        HomeAddress -> create(EnterEmployeeHouseName->Text,
                                StrToInt(EnterEmployeeHouseNo->Text),
                                EnterEmployeeStreet->Text,
                                EnterEmployeeTown->Text,
                                EnterEmployeePostCode->Text,
                                EnterEmployeeCountry->Text);
.....
}
 
 

And the create function for the HomeAddress pointer, this is basically where i get the exception, after it inputs all data, on the closing bracket.

void Address :: create(String aHouseName, int aHouseNumber, String aStreet,
             String aTown, String aPostcode,  String aCountry)
{
        Street = aStreet;
        HouseNo = aHouseNumber;
        HouseName = aHouseName;
        PostCode = aPostcode;
        Town = aTown;
        Country = aCountry;
 
}
 

I was thinking that might do with the constructors and memory allocation, but it all seems correct.
This is where i allocate the memory for address:

Employee :: Employee()
{
        FirstName = "";
        Surname = "";
        SocialNumber = -1;
        Salary = -1;
        DOB = new clsDate();
        EmploymentStartDate = new clsDate();
        myCurrentAccount = new CurrentAccount();
 
        HomeAddress = new Address();
}
 

I've been getting this exception for other program as well and can't figure out what i'm doing wrong.
Would be very grateful if anyone has advice.

[weaknessforcats]

Employee :: Employee()
{
FirstName = "";
Surname = "";
SocialNumber = -1;
Salary = -1;
DOB = new clsDate();
EmploymentStartDate = new clsDate();
myCurrentAccount = new CurrentAccount();

HomeAddress = new Address();
}

Part of yourt problem is here. FirstName is set to the address of a "" string. If you ever try to chnage FirstName, you will crash with a segmentation fault.

You have to:

FirstName = new char[1];
FirstName[0] = '\0';
 

Now you have a null string in FirstName that can be deleted.

Also you see me be calling constructors instead of creating objects.

HomeAddress = new Address();

This shouls be:

HomeAddress = new Address;
 

I would make changes thoughout tyour code that a) never assigns a literal to a field you may change, b) create objects and do not call constructors.

I don't see you class but it should also have a destructor and a copy constructor.