AnsiString input from file

[jewel87]

Hi guys,
I have a problem with inputting from a file. I have this function:

 
void Product :: InputFromFile()
{
        fstream inputfile;
        inputfile.open("input.txt");
 
        inputfile>>ProductID;
        inputfile>>ProductName.c_str();
        inputfile>>Weight;
        inputfile>>PriceWithoutVAT;
 
        PriceWithVAT=CalculateVATPrice();
 
        inputfile>>ExpiryDate.c_str();
        inputfile>>AmountInStock;
        inputfile>>ReorderLimit;
         inputfile>>ProductCategory.c_str();
         inputfile>>InputDate.c_str();
         inputfile>>DueDate.c_str();
         inputfile>>Manufacturer.c_str();
         inputfile>>ManufacturerAddress.c_str(); 
         inputfile.close(); //
}
 

and a simple text file with data. The program reads only the data until the line inputfile>>PriceWithoutVAT; , and doesn't see all the rest data. It even ignores the CalculateVATPrice() function, which in other functions works fine.
I have tried this also as:

 
       fstream inputfile;
        inputfile.open("input.txt");
 
        inputfile>>ProductID;
        inputfile.getline(ProductName.c_str(),10,'\n');
        inputfile>>Weight;
        inputfile>>PriceWithoutVAT;
 
        PriceWithVAT=CalculateVATPrice();
        inputfile.getline(ExpiryDate.c_str(),10,'\n');
 
        inputfile>>AmountInStock;
        inputfile>>ReorderLimit;
 
       inputfile.getline(ProductCategory.c_str(),10,'\n');
       inputfile.getline(InputDate.c_str(),10,'\n');
       inputfile.getline(DueDate.c_str(),10,'\n');
       inputfile.getline(Manufacturer.c_str(),10,'\n');
       inputfile.getline(ManufacturerAddress.c_str(),10,'\n');
       inputfile.close();
 

It has the same result. I'm really stuck, everything seems right, and it works for the first lines, which are done in the same way.
Please help if anybody has any ideas.
Thanks.

[weaknessforcats]

What's haappening is that one of your inputfile>> is failing.

The >> operator fetches data into the variable you specify. It that variable is the wrong type (like trying to fetch a 1 so a char or an A to an int), the >> operator sets a fail bit.

This fail bit is the first things check by the >> operator itself. SO on the next inputfile>> the fail bit is on so the >> does nothing and returns.

The effect is that after the failure, all of the >> operators in your program appear to not work.

You have to
1)test every >> operator to make sure the fail bit is off:

inputfile>>data;
if (inputfile.fail() == true)
{
    //Big problem
}
//OK to continue
 

If the fail bit is on, you can reset it by calling inputfile.clear(). However, the data that caused the error is still in the inout stream and will have to be dealt with.

Remember, the >> assumes you know ahead of time what data is being fetched AND that the data elements are separated from each other by whitespace. If this is not the case, then you can't use the >> operator.

[jewel87]

What's haappening is that one of your inputfile>> is failing.

The >> operator fetches data into the variable you specify. It that variable is the wrong type (like trying to fetch a 1 so a char or an A to an int), the >> operator sets a fail bit.

This fail bit is the first things check by the >> operator itself. SO on the next inputfile>> the fail bit is on so the >> does nothing and returns.

The effect is that after the failure, all of the >> operators in your program appear to not work.

You have to
1)test every >> operator to make sure the fail bit is off:

inputfile>>data;
if (inputfile.fail() == true)
{
    //Big problem
}
//OK to continue
 

If the fail bit is on, you can reset it by calling inputfile.clear(). However, the data that caused the error is still in the inout stream and will have to be dealt with.

Remember, the >> assumes you know ahead of time what data is being fetched AND that the data elements are separated from each other by whitespace. If this is not the case, then you can't use the >> operator.

First of all, thank you very much for the reply.
You know, I'm starting to think that either Borland at all or just my version specifically has a very bad compiler.
Yesterday i left this function as it was, and today when I opened the program and recompiled it, while debugging using breakpoints I see that it is reading all the rest data that it wasn't reading yesterday, it's processing the function it ignored yesterday, but now instead it is giving me some error just in the end, something about access violation at xxxxx.
I'll try to resolve this somehow, if anyone has suggestions please post.