Converting Bytes into integer sets

[freeurmind]

hello, i'm writing a function that translate Bytes of type unsigned char to integer array of 1's and 0's, i'm taking a message of 33 Bytes and translating them in an int array of 264 integers, here's the function:

void readByte(unsigned char * buffer, int binarr[])
{
    unsigned char mask = 1 << 7;
    bool mybit;
    int j =0;
    for ( int i =1; i <= sizeof(binarr) ; i++)
    {
        mybit = (bool) (buffer[j] & mask);
        if (mybit) 
            binarr[i]  = 1;
        else 
            binarr[i] = 0;
        buffer[j]<<=1 ;
        if ( i % 8 == 0)
            j++ ;
    }
}

but it looks like something is wrong it cause when i try to display my array first it shows me much more than 264 integers and second its not binary it contains other numbers then 1's and 0's
here is my main:

void main()
{
    ifstream InFile("Myfile", ios::binary);
    unsigned char message[33];
    int bin[264];
    if (!InFile)
    { 
        cerr<<"InFile could not be opened";
        exit(1);
    }
    InFile.read( (char *)message, 33);
    cout<<"my message is:";
    for ( int i =0; i< sizeof(message) ; i++)
        cout<<message[i];
    readByte(message, bin);
    cout<<"\n"<<"my binary representation is:";
    for ( int i =0; i< 264 ; i++)
        cout<<bin[i];
}

Please help on this issue, if u need furthe explanation i'll be happy to answer

[weaknessforcats]

You might try an easier approach.

To see the bit in position 128 you:

quotient = your number / 128

This will be some number

Next:

result = quotient % 2

and the result is 0 or 1 as an integer

Or covert it to a displayable character:

charresult = result + '0'

In one line of code this is:

(your number / 128) % 2 + '0'

If you use a loop divide the 128 by 2 to get the next least significant bit.