Need help with this error

[hjast]

test has exited due to signal 10 (SIGBUS).

This is the circle class

 
#include <iostream.h>
 
 
class Shape
{
  private:
     int x_Center, y_Center;
 
  public:
    Shape()
    {
    cout <<"In defualt constructer";
    }
    Shape(Shape& sh)
    {
    x_Center=sh.x_Center;
    y_Center=sh.y_Center;
    }
     // Constructors
     Shape(int cx, int cy)
    {
        x_Center=cx;
        y_Center=cy;
    }
 
     // Member functions
     int getCenter_X();
     int getCenter_Y();
     virtual void draw()=0;
};
 
class Rectangle : public Shape
{
private:
    int length,width;
 
 public:
 
  // Default constructor
  Rectangle (Rectangle& r) : Shape(r)
    {
    length=r.length;
    width=r.width;
    }
 
  // Constructor
  Rectangle (int cx, int cy,int l,int w) : Shape(cx, cy)
    {
    length=l;
    width=w;
      cout << "In Rectangle constructor" << endl;
    }
 
 
 
    // Destructor
    ~Rectangle ()
      {
    cout << "In Rectangle destructor" << endl;
      }
 
    void draw()
    {
    cout <<"In drawing of Rectangle"<<endl;
    }
 
    Rectangle & operator=(const Rectangle &obj)
    {
    int cx=this->getCenter_X();
    int cy=this->getCenter_Y();
    int length=this->length;
    int width=this->width;
    Rectangle newRect(cx,cy,length,width);
 
    return newRect;
    }
    // Methodds
    void printAllValues();
};
 
class Circle : public Shape
{
private:
int diameter;
 
 public:
 
  // Default Constructor
  Circle ()
    {
      cout << "In the default constructor of Circle" << endl;
    }
 
    Circle (Circle& r) : Shape(r)
    {
    diameter=r.diameter;
    }
  // Constructor
  Circle (int cx, int cy, int dia) : Shape (cx, cy)
    {
      cout << "In Circle Constructer" << endl;
      diameter=dia;
    }
 
    // Destructor
    ~Circle ()
      {
    cout << "In Circle destructor" << endl;
      }
      void draw()
    {
    cout <<"In drawing of Circle"<<endl;
    }
    Circle & operator=(const Circle &obj)
    {
    int cx=this->getCenter_X();
    int cy=this->getCenter_Y();
    int diameter=this->diameter;
     Circle newCircle(cx,cy,diameter);
 
    return newCircle;
    }
    // Methods
    void printAllValues();
};
 

This is the tester

#include "shape.h"
#include <iostream>
 
int main()
{
Rectangle r(10,10,10,10);
r.draw();
Circle aCircle(10,10,10);
aCircle.draw();
cout <<"Rectangle" <<endl;
r.printAllValues();
cout <<endl <<"Circle" <<endl;
aCircle.printAllValues();
cout<< endl <<"Constucting copy of Rectangle" <<endl;
Rectangle r2(r);
r2.printAllValues();
cout << endl <<"Constructing copy of Circle" <<endl;
Circle aNotherCircle(aCircle);
aNotherCircle.printAllValues();
 
cout << endl;
Rectangle rect;
rect=r;
rect.printAllValues()
 
return 0;
}

Why is this Error happening and what does it mean?

[gpraghuram]

Hi,
There are couple of issues with the code
1)The code for overloading = operator is wrong
You are creating a stack object and returning it.
It shuld be like this

Rectangle & operator=(const Rectangle &obj)
{
  //fill the this ooj with values from obj and return this lik
   cx=obj.getCenter_X();
  //first check for this is = to obj
  return *this.
}
 

2)Same is the case with Circle & operator=(const Circle &obj)

Correct these errors and try to run the code.

Raghuram

[hjast]

Here is the updated code. It still gives a SIGBUS error and I don't know why.


Main code

 
#include <iostream.h>
 
 
class Shape
{
  private:
     int x_Center, y_Center;
 
  public:
    Shape()
    {
    cout <<"In defualt constructer";
    }
    Shape(Shape& sh)
    {
    x_Center=sh.x_Center;
    y_Center=sh.y_Center;
    }
     // Constructors
     Shape(int cx, int cy)
    {
        x_Center=cx;
        y_Center=cy;
    }
 
     // Member functions
     int getCenter_X();
     int getCenter_Y();
     void setCenter_X(int i)
     {
     x_Center=i;
     }
     void setCenter_Y(int i)
     {
     y_Center=i;
     }
     virtual void draw()=0;
};
 
class Rectangle : public Shape
{
private:
    int length,width;
 
 public:
 
  // Default constructor
  Rectangle (Rectangle& r) : Shape(r)
    {
    length=r.length;
    width=r.width;
    }
 
  // Constructor
  Rectangle (int cx, int cy,int l,int w) : Shape(cx, cy)
    {
    length=l;
    width=w;
      cout << "In Rectangle constructor" << endl;
    }
 
 
 
    // Destructor
    ~Rectangle ()
      {
    cout << "In Rectangle destructor" << endl;
      }
 
    void draw()
    {
    cout <<"In drawing of Rectangle"<<endl;
    }
 
    Rectangle & operator=(Rectangle &obj)
    {
    int x=obj.getCenter_X();
    int y=obj.getCenter_Y();
    this->setCenter_X(x);
    this->setCenter_Y(y);
    this->length=obj.length;
    this->width=obj.width;
    return *this;
    }
    // Methodds
    void printAllValues();
};
 
class Circle : public Shape
{
private:
int diameter;
 
 public:
 
  // Default Constructor
  Circle ()
    {
      cout << "In the default constructor of Circle" << endl;
    }
 
    Circle (Circle& r) : Shape(r)
    {
    diameter=r.diameter;
    }
  // Constructor
  Circle (int cx, int cy, int dia) : Shape (cx, cy)
    {
      cout << "In Circle Constructer" << endl;
      diameter=dia;
    }
 
    // Destructor
    ~Circle ()
      {
    cout << "In Circle destructor" << endl;
      }
      void draw()
    {
    cout <<"In drawing of Circle"<<endl;
    }
    Circle & operator=(Circle &obj)
    {
    this->setCenter_X(obj.getCenter_X());
    this->setCenter_Y(obj.getCenter_Y());
    this->diameter=obj.diameter;
    return *this;
    }
    // Methods
    void printAllValues();
};
 

Tester code

#include "shape.h"
#include <iostream>
 
int main()
{
Rectangle r(10,10,10,10);
r.draw();
Circle aCircle(10,10,10);
aCircle.draw();
cout <<"Rectangle" <<endl;
r.printAllValues();
cout <<endl <<"Circle" <<endl;
aCircle.printAllValues();
cout<< endl <<"Constucting copy of Rectangle" <<endl;
Rectangle r2(r);
r2.printAllValues();
cout << endl <<"Constructing copy of Circle" <<endl;
Circle aNotherCircle(aCircle);
aNotherCircle.printAllValues();
 
cout << endl;
Rectangle rect;
rect=r;
rect.printAllValues()
 
return 0;
}
 

I am so confused why this is not working.

[gpraghuram]

Hi,
First of all the code is not compiling
1)Class Rectangle dosent have a default constructor and it fails there in compilation
2)printAllValues() dosent have a body for it and gives a linker error.
I made changes locally and after that it compiled and ran successfully without any issues.
I am using g++ with cygwin

Raghuram