variables in functions

[mng2nf]

if someone could check this out... i've been working on this function, try to focus on 'InstCarpTot' as a main one, i keep getting errors that it is being used without being initialized and i don't know what to do to fix it. i'm pretty new to functions and am not familiar with how they work. thanks

//declaring functions
void GetDimensions(int &Length, int &Width);
int CalculateArea(int Length, int Width);
void GetDiscount(double &Discount);
void GetUnit_Price(double &Unit_Price);
double CalInstCarpTot(int Area, double Unit_Price);
double Subtotal(double InstCarpTot, double Discount);
double Total(double Subtot);
void PrintMeasurements(int Length, int Width);
void PrintCharges(int Area, double Discount);
 
 
int main()
{
    int Length, Width, Area;
    double Discount, Unit_Price, InstCarpTot, Subtot;
 
 
 
 
//print functions
    GetDimensions (Length, Width);
    Area=CalculateArea(Length, Width);
 
    cout << Area << endl;
    GetDiscount(Discount);
 
    GetUnit_Price(Unit_Price);
    CalInstCarpTot(Area, Unit_Price);
    Subtotal(InstCarpTot, Discount);
    Total(Subtot);
    PrintMeasurements(Length, Width);
    PrintCharges( Area, Discount);
 
    return 0;
}
 
//get the total cost for installation 
double CalInstCarpTot(int Area, double Unit_Price)
{
    double TotLabor, InstCarpTot, TotUnit_Price;
 
    const double Labor=0.42;
    TotLabor=Labor*Area;
    TotUnit_Price=Unit_Price*Area;
    InstCarpTot=TotUnit_Price+TotLabor;
 
    return InstCarpTot;
}
 
 
 
 
 
//print the costs using variables entered by user
void PrintCharges(int Area, double Discount)
{
    double InstCarpTot;
    cout << setw(13) <<left <<"Carpet w/ Labor" << setw(26) << right<< InstCarpTot <<endl;

[Shashi Sadasivan]

Hi,
that should give a u a compile time warning, (not an error)
Just set default values to your variables.

cheers

[mng2nf]

Hi,
that should give a u a compile time warning, (not an error)
Just set default values to your variables.

cheers

thanks but i need the program to work with variables inputted by the user, and the program gives warnings but it doesn't run when it hits the 'unitinialized' variables

[Shashi Sadasivan]

Hi,
What i meant was, change your code from:

int Length, Width, Area;
double Discount, Unit_Price, InstCarpTot, Subtot;

to

int Length=0, Width=0, Area=0;
double Discount=0, Unit_Price=0, InstCarpTot=0, Subtot=0;

And you should be allright.

cheers

[mng2nf]

Hi,
What i meant was, change your code from:

int Length, Width, Area;
double Discount, Unit_Price, InstCarpTot, Subtot;

to

int Length=0, Width=0, Area=0;
double Discount=0, Unit_Price=0, InstCarpTot=0, Subtot=0;

And you should be allright.

cheers

:/ when i do that it makes all of my variables into 0 instead of what was calculated by the program

[Shashi Sadasivan]

Well, the variables have just been initialised at this line,
How come it already got calculated before being initialized? (ding ding)

EDITED:
Hi,
Its been a long time since ive seen C/C++ code (im into C#)
but isint

GetDimensions (Length, Width);

supposed to be

GetDimensions (*Length, *Width);

??
cheers

[weaknessforcats]

thanks but i need the program to work with variables inputted by the user, and the program gives warnings but it doesn't run when it hits the 'unitinialized' variables

That's fine. But using variables that have never neen initialized os a major source of error. Major compilers, like Visual Studio.NET give warnings about using uninitialized variables. That is, to make a function call using one of those variables require that a copy be made. You cannpt reliably copy an uninitialized variable. There's not guarantee the function will intialize it making a crash not farr away.

Just provide a default value, then go ahead and ask for user input.