Program Crashs When Input Is Entered

[geebanga88]

Hi have this program which keep crashing upon entering input, i think there is somthing wrong with the get_temp function returning the variables back to main?.

 
#include <stdio.h>  
#include <ctype.h> 
 
float Get_Temp (float &kelvin_temp, char &conversion_type)
{ 
 
     printf ("Welcome to the temperature conversion program\n"); 
     printf ("Please enter the temperature in Kelvin degres:\n"); 
     scanf ("%f", &kelvin_temp); 
 
     printf ("What is your conversion type:\n F for Fahrenheit \n C for Celsius\n"); 
     scanf ("%c", &conversion_type); 
 
     return (kelvin_temp, conversion_type); 
 
}
 
void Water_Type (float &celsius_temp)
{ 
     if ( celsius_temp <= 0 ) 
          printf ("Your water type is a solid\n"); 
     else if (( celsius_temp > 0 ) && ( celsius_temp < 100 )) 
          printf ("Your water type is a liquid\n"); 
     else if ( celsius_temp >= 100 ) 
          printf ("Your water type is a gas\n"); 
 
     return; 
 
} 
 
void Conversion (char conversion_type, float kelvin_temp) 
{ 
     float fahrenheit_temp, celsius_temp; 
 
     switch ( conversion_type ) 
            {
            case 'c': {
                 celsius_temp = kelvin_temp - 273; 
                 Water_Type(celsius_temp); 
                 printf ("Your temperature in degrees celsius is %f\n", celsius_temp); 
                 }
                break; 
 
            case 'f': { 
                 celsius_temp = kelvin_temp - 273;  
                 fahrenheit_temp = ((9 * celsius_temp) / 5) + 32; 
                 Water_Type(celsius_temp); 
                 printf ("Your temperature in degrees fahrenheit is %f\n", fahrenheit_temp); 
                }
                break;
 
            return; 
            } 
}
 
int main ()  
{ 
    float kelvin_temp; 
    char conversion_type;
 
 
    Get_Temp (kelvin_temp, conversion_type); 
    printf ("%c\n", conversion_type);
    Conversion (conversion_type, kelvin_temp); 
 
 
    getchar();
    getchar ();
    return 0; 
 
}  
 

[Savage]

Function can only return a single value:

float Get_Temp (float &kelvin_temp, char &conversion_type)
{
 
     printf ("Welcome to the temperature conversion program\n");
     printf ("Please enter the temperature in Kelvin degres:\n");
     scanf ("%f", &kelvin_temp);
 
     printf ("What is your conversion type:\n F for Fahrenheit \n C for Celsius\n");
     scanf ("%c", &conversion_type);
 
     return (kelvin_temp, conversion_type);<-------------------------
 
}

[geebanga88]

Ahh yer, how could i over

[geebanga88]

Ahh yer, how could i over come this, cause i have to return these values back to main some how?

[ilikepython]

Ahh yer, how could i over come this, cause i have to return these values back to main some how?

Since this is C, you can't use pass by reference so you could use pointers:

void GetTemp(float *kelvTemp, char *convers)
{
    scanf("%f", kelvTemp);
    scanf("%c", convers);
}
 

Then the changes should occur in the calling function.

[geebanga88]

I now get this error when addding the pointers:

cannot convert `float' to `float*' for argument `1' to `void Get_Temp(float*, char*)'

 
Get_Temp (kelvin_temp, conversion_type);  
 

[ilikepython]

I now get this error when addding the pointers:

cannot convert `float' to `float*' for argument `1' to `void Get_Temp(float*, char*)'

 
Get_Temp (kelvin_temp, conversion_type);  
 

You have to pass the addresses of the integers:

Get_Temp(&kelvin_Temp, &conversion_type);
 

[JosAH]

Ahh yer, how could i over come this, cause i have to return these values back to main some how?

How about *two* little functions: one returns the temperature value and the other
one returns the calculation method. Never let one function do two disjunct things;
your mistake is a perfect example why you shouldn't do that.

kind regards,

Jos

[sicarie]

FYI-

I've changed the title of the thread to be a bit more descriptive.

[geebanga88]

Hi ive added a new function but the program still crashes?, i am still confused as to why it might be:( This is the program code now:

 
void Get_Temp (float *kelvin_temp)
{ 
 
     printf ("Welcome to the temperature conversion program\n"); 
     printf ("Please enter the temperature in Kelvin degres:\n"); 
     scanf ("%f", &kelvin_temp); 
 
     return; 
 
}
 
void Get_Conversion (char *conversion_type) 
{ 
     printf ("What is your conversion type:\n F for Fahrenheit \n C for Celsius\n"); 
     scanf ("%c", &conversion_type); 
 
     return; 
 
}
 
 
void Water_Type (float &celsius_temp)
{ 
     if ( celsius_temp <= 0 ) 
          printf ("Your water type is a solid\n"); 
     else if (( celsius_temp > 0 ) && ( celsius_temp < 100 )) 
          printf ("Your water type is a liquid\n"); 
     else if ( celsius_temp >= 100 ) 
          printf ("Your water type is a gas\n"); 
 
     return; 
 
} 
 
void Conversion (char conversion_type, float kelvin_temp) 
{ 
     float fahrenheit_temp, celsius_temp; 
 
     switch ( conversion_type ) 
            {
            case 'c': {
                 celsius_temp = kelvin_temp - 273; 
                 Water_Type(celsius_temp); 
                 printf ("Your temperature in degrees celsius is %f\n", celsius_temp); 
                 }
                break; 
 
            case 'f': { 
                 celsius_temp = kelvin_temp - 273;  
                 fahrenheit_temp = ((9 * celsius_temp) / 5) + 32; 
                 Water_Type(celsius_temp); 
                 printf ("Your temperature in degrees fahrenheit is %f\n", fahrenheit_temp); 
                }
                break;
 
            return; 
            } 
}
 
int main ()  
{ 
    float kelvin_temp;
    char conversion_type;
 
 
    Get_Temp (&kelvin_temp); 
    Get_Conversion (&conversion_type); 
    Conversion (conversion_type, kelvin_temp); 
 
 
    getchar();
    getchar ();
    return 0; 
 
}  
 
 

[ilikepython]

Hi ive added a new function but the program still crashes?, i am still confused as to why it might be:( This is the program code now:

 
void Get_Temp (float *kelvin_temp)
{ 
 
     printf ("Welcome to the temperature conversion program\n"); 
     printf ("Please enter the temperature in Kelvin degres:\n"); 
     scanf ("%f", &kelvin_temp); 
 
     return; 
 
}
 
void Get_Conversion (char *conversion_type) 
{ 
     printf ("What is your conversion type:\n F for Fahrenheit \n C for Celsius\n"); 
     scanf ("%c", &conversion_type); 
 
     return; 
 
}
 
 
void Water_Type (float &celsius_temp)
{ 
     if ( celsius_temp <= 0 ) 
          printf ("Your water type is a solid\n"); 
     else if (( celsius_temp > 0 ) && ( celsius_temp < 100 )) 
          printf ("Your water type is a liquid\n"); 
     else if ( celsius_temp >= 100 ) 
          printf ("Your water type is a gas\n"); 
 
     return; 
 
} 
 
void Conversion (char conversion_type, float kelvin_temp) 
{ 
     float fahrenheit_temp, celsius_temp; 
 
     switch ( conversion_type ) 
            {
            case 'c': {
                 celsius_temp = kelvin_temp - 273; 
                 Water_Type(celsius_temp); 
                 printf ("Your temperature in degrees celsius is %f\n", celsius_temp); 
                 }
                break; 
 
            case 'f': { 
                 celsius_temp = kelvin_temp - 273;  
                 fahrenheit_temp = ((9 * celsius_temp) / 5) + 32; 
                 Water_Type(celsius_temp); 
                 printf ("Your temperature in degrees fahrenheit is %f\n", fahrenheit_temp); 
                }
                break;
 
            return; 
            } 
}
 
int main ()  
{ 
    float kelvin_temp;
    char conversion_type;
 
 
    Get_Temp (&kelvin_temp); 
    Get_Conversion (&conversion_type); 
    Conversion (conversion_type, kelvin_temp); 
 
 
    getchar();
    getchar ();
    return 0; 
 
}  
 
 

Since you are already passing a pointer to the function, you don't need to get the address of the variable (pointer):

scanf("%c", conversion_type);
 

Same thing for the float.

[geebanga88]

Ok i still removed the & from scanf funcitons, i get the program to compile but when after i enter the temp and then enter the conversion type it still crashes then?

[geebanga88]

im not sure y but i think it as somthing to do with the inputs
E.g This works when i just get the conversion type.

 
 
void Get_Conversion (char *type) 
{ 
     printf ("What is your conversion type:\n F for Fahrenheit \n C for Celsius\n"); 
     scanf ("%c", type); 
 
     return; 
 
}
 
void Conversion (char type) 
{ 
 
     switch ( type ) 
            {
            case 'c': {
 
                 printf ("C has been selected \n"); 
                 }
                break; 
 
            case 'f': { 
 
                 printf ("F has been selected \n"); 
                }
                break;
 
            return; 
            } 
}
 
 
 
 
int main ()  
{  
    float kelvin_temp;
    char type;
 
 
    Get_Conversion (&type); 
    printf("Your type is %c\n", type); 
    Conversion (type);
 
    getchar();
    getchar ();
    return 0; 
 
}  
 
 

But when i add the gettemp function it will crash after i enter in the conversion type.

 
void Get_Temp (float *kelvin_temp)
{ 
 
     printf ("Welcome to the temperature conversion program\n"); 
     printf ("Please enter the temperature in Kelvin degres:\n"); 
     scanf ("%f", kelvin_temp); 
 
     return; 
 
} 
 

[ilikepython]

im not sure y but i think it as somthing to do with the inputs
E.g This works when i just get the conversion type.

 
 
void Get_Conversion (char *type) 
{ 
     printf ("What is your conversion type:\n F for Fahrenheit \n C for Celsius\n"); 
     scanf ("%c", type); 
 
     return; 
 
}
 
void Conversion (char type) 
{ 
 
     switch ( type ) 
            {
            case 'c': {
 
                 printf ("C has been selected \n"); 
                 }
                break; 
 
            case 'f': { 
 
                 printf ("F has been selected \n"); 
                }
                break;
 
            return; 
            } 
}
 
 
 
 
int main ()  
{  
    float kelvin_temp;
    char type;
 
 
    Get_Conversion (&type); 
    printf("Your type is %c\n", type); 
    Conversion (type);
 
    getchar();
    getchar ();
    return 0; 
 
}  
 
 

But when i add the gettemp function it will crash after i enter in the conversion type.

 
void Get_Temp (float *kelvin_temp)
{ 
 
     printf ("Welcome to the temperature conversion program\n"); 
     printf ("Please enter the temperature in Kelvin degres:\n"); 
     scanf ("%f", kelvin_temp); 
 
     return; 
 
} 
 

What do you mean? It crashes without even calling the function? What kind of input are you giving it?

[geebanga88]

ahhh dont worry i think i got it sorted