possible seg fault

[jhagens14]

The following program compiles successfully on a Microsoft Visual C++
6.0 compiler but when I execute it..it encounters an unknown
error..may be a because of a seg fault..

#include <string.h>
#include <iostream.h>

int main(int argc, char **argv){
int i;
int len;
char *addressLine[8];

addressLine[1] = "String1";
addressLine[2] = "String2";

for(i = 1; i <= 8; i++){
len = strlen(addressLine[i]);
if (len >= 1){
cout << "Address: " << addressLine[i];
cout << "\n";
}
}
return (0);
}

but when I just use the following without the loop..

cout << "Address: " << addressLine[1];

it just works fine...

Please help!...

[Laurent D.A.M. MENTEN]

jh*******@fastermail.com a écrit :

The following program compiles successfully on a Microsoft Visual C++
6.0 compiler but when I execute it..it encounters an unknown
error..may be a because of a seg fault..

#include <string.h>
#include <iostream.h>

int main(int argc, char **argv){
int i;
int len;
char *addressLine[8];

addressLine[1] = "String1";
addressLine[2] = "String2";

for(i = 1; i <= 8; i++){
len = strlen(addressLine[i]);
if (len >= 1){
cout << "Address: " << addressLine[i];
cout << "\n";
}
}
return (0);
}

but when I just use the following without the loop..

cout << "Address: " << addressLine[1];

it just works fine...

Please help!...

You did not initialize entries 3..8 of the addressLine array... their
content is pure garbage...

[jhagens14]

On Sep 16, 5:27 pm, "Laurent D.A.M. MENTEN"
<[e-mail]:

[e-mail] a écrit :

The following program compiles successfully on a Microsoft Visual C++
6.0 compiler but when I execute it..it encounters an unknown
error..may be a because of a seg fault..

#include <string.h>
#include <iostream.h>

int main(int argc, char **argv){
int i;
int len;
char *addressLine[8];

addressLine[1] = "String1";
addressLine[2] = "String2";

for(i = 1; i <= 8; i++){
len = strlen(addressLine[i]);
if (len >= 1){
cout << "Address: " << addressLine[i];
cout << "\n";
}
}
return (0);
}

but when I just use the following without the loop..

cout << "Address: " << addressLine[1];

it just works fine...

Please help!...

You did not initialize entries 3..8 of the addressLine array... their
content is pure garbage...- Hide quoted text -

- Show quoted text -

Thanks! for ur reply..I need to use only 2 entries in the array...How
do I iterate and print by handling the error at the same time..I tried
to use

if(!addressLine[i]){
//Print value..
}

but same problem..

[LR]

Laurent D.A.M. MENTEN wrote:

jh*******@fastermail.com a écrit :

>The following program compiles successfully on a Microsoft Visual C++
6.0 compiler but when I execute it..it encounters an unknown
error..may be a because of a seg fault..

#include <string.h>
#include <iostream.h>

int main(int argc, char **argv){
int i;
int len;
char *addressLine[8];

addressLine[1] = "String1";
addressLine[2] = "String2";

for(i = 1; i <= 8; i++){
len = strlen(addressLine[i]);
if (len >= 1){
cout << "Address: " << addressLine[i];
cout << "\n";
}
}
return (0);
}

but when I just use the following without the loop..

cout << "Address: " << addressLine[1];

it just works fine...

Please help!...

You did not initialize entries 3..8 of the addressLine array... their
content is pure garbage...

My understanding is that an array of [8] would have valid indicies from
0..7, and that in c++ array indicies start at zero, an array with n
elements will have indicies from 0..n-1. So I think he didn't initialize
element zero and elements 3..7.

Check the loop again.

You may also want to look at std::string.

LR

[jhagens14]

On Sep 16, 5:38 pm, [e-mail] wrote:

On Sep 16, 5:27 pm, "Laurent D.A.M. MENTEN"

<[e-mail]:

[e-mail] a écrit :

The following program compiles successfully on a Microsoft Visual C++
6.0 compiler but when I execute it..it encounters an unknown
error..may be a because of a seg fault..

#include <string.h>
#include <iostream.h>

int main(int argc, char **argv){
int i;
int len;
char *addressLine[8];

addressLine[1] = "String1";
addressLine[2] = "String2";

for(i = 1; i <= 8; i++){
len = strlen(addressLine[i]);
if (len >= 1){
cout << "Address: " << addressLine[i];
cout << "\n";
}
}
return (0);
}

but when I just use the following without the loop..

cout << "Address: " << addressLine[1];

it just works fine...

Please help!...

You did not initialize entries 3..8 of the addressLine array... their
content is pure garbage...- Hide quoted text -

- Show quoted text -

Thanks! for ur reply..I need to use only 2 entries in the array...How
do I iterate and print by handling the error at the same time..I tried
to use

if(!addressLine[i]){
//Print value..
}

but same problem..- Hide quoted text -

- Show quoted text -

I am sorry I meant..

if(addressLine[i]){
//Print value..
}

[runner]

<jh*******@fastermail.comwrote in message
news:11**********************@r29g2000hsg.googlegr oups.com...
On Sep 16, 5:38 pm, [e-mail] wrote:

On Sep 16, 5:27 pm, "Laurent D.A.M. MENTEN"

<[e-mail]:

[e-mail] a écrit :

The following program compiles successfully on a Microsoft Visual C++
6.0 compiler but when I execute it..it encounters an unknown
error..may be a because of a seg fault..

#include <string.h>
#include <iostream.h>

int main(int argc, char **argv){
int i;
int len;
char *addressLine[8];

addressLine[1] = "String1";
addressLine[2] = "String2";

for(i = 1; i <= 8; i++){
len = strlen(addressLine[i]);
if (len >= 1){
cout << "Address: " << addressLine[i];
cout << "\n";
}
}
return (0);
}

but when I just use the following without the loop..

cout << "Address: " << addressLine[1];

it just works fine...

Please help!...

You did not initialize entries 3..8 of the addressLine array... their
content is pure garbage...- Hide quoted text -

- Show quoted text -

Thanks! for ur reply..I need to use only 2 entries in the array...How
do I iterate and print by handling the error at the same time..I tried
to use

if(!addressLine[i]){
//Print value..
}

but same problem..- Hide quoted text -

- Show quoted text -

>I am sorry I meant..

if(addressLine[i]){
//Print value..
}

addressLine[0] = "String1";
addressLine[1] = "String2";
addressLine[2] = NULL;

....

for (i = 0; i < 8; i++)

[Laurent D.A.M. MENTEN]

LR a écrit :

Laurent D.A.M. MENTEN wrote:

>jh*******@fastermail.com a écrit :

>>The following program compiles successfully on a Microsoft Visual C++
6.0 compiler but when I execute it..it encounters an unknown
error..may be a because of a seg fault..

#include <string.h>
#include <iostream.h>

int main(int argc, char **argv){
int i;
int len;
char *addressLine[8];

addressLine[1] = "String1";
addressLine[2] = "String2";

for(i = 1; i <= 8; i++){
len = strlen(addressLine[i]);
if (len >= 1){
cout << "Address: " << addressLine[i];
cout << "\n";
}
}
return (0);
}

but when I just use the following without the loop..

cout << "Address: " << addressLine[1];

it just works fine...

Please help!...

You did not initialize entries 3..8 of the addressLine array... their
content is pure garbage...

My understanding is that an array of [8] would have valid indicies from
0..7, and that in c++ array indicies start at zero, an array with n
elements will have indicies from 0..n-1. So I think he didn't initialize
element zero and elements 3..7.

Check the loop again.

You may also want to look at std::string.

LR

yep, that's true...

[jhagens14]

On Sep 16, 6:04 pm, "Laurent D.A.M. MENTEN"
<[e-mail]:

LR a écrit :

Laurent D.A.M. MENTEN wrote:

[e-mail] a écrit :
The following program compiles successfully on a Microsoft Visual C++
6.0 compiler but when I execute it..it encounters an unknown
error..may be a because of a seg fault..

>#include <string.h>
#include <iostream.h>

>int main(int argc, char **argv){
int i;
int len;
char *addressLine[8];

> addressLine[1] = "String1";
addressLine[2] = "String2";

> for(i = 1; i <= 8; i++){
len = strlen(addressLine[i]);
if (len >= 1){
cout << "Address: " << addressLine[i];
cout << "\n";
}
}
return (0);
}

>but when I just use the following without the loop..

>cout << "Address: " << addressLine[1];

>it just works fine...

>Please help!...

You did not initialize entries 3..8 of the addressLine array... their
content is pure garbage...

My understanding is that an array of [8] would have valid indicies from
0..7, and that in c++ array indicies start at zero, an array with n
elements will have indicies from 0..n-1. So I think he didn't initialize
element zero and elements 3..7.

Check the loop again.

You may also want to look at std::string.

LR

yep, that's true...- Hide quoted text -

- Show quoted text -

That worked by setting rest to NULL...Thanks!!

[Kai-Uwe Bux]

runner wrote:

>
<jh*******@fastermail.comwrote in message
news:11**********************@r29g2000hsg.googlegr oups.com...
On Sep 16, 5:38 pm, [e-mail] wrote:

>On Sep 16, 5:27 pm, "Laurent D.A.M. MENTEN"

<[e-mail]:

[e-mail] a écrit :

The following program compiles successfully on a Microsoft Visual C++
6.0 compiler but when I execute it..it encounters an unknown
error..may be a because of a seg fault..

#include <string.h>
#include <iostream.h>

int main(int argc, char **argv){
int i;
int len;
char *addressLine[8];

addressLine[1] = "String1";
addressLine[2] = "String2";

for(i = 1; i <= 8; i++){
len = strlen(addressLine[i]);
if (len >= 1){
cout << "Address: " << addressLine[i];
cout << "\n";
}
}
return (0);
}

but when I just use the following without the loop..

cout << "Address: " << addressLine[1];

it just works fine...

Please help!...

You did not initialize entries 3..8 of the addressLine array... their
content is pure garbage...- Hide quoted text -

- Show quoted text -

Thanks! for ur reply..I need to use only 2 entries in the array...How
do I iterate and print by handling the error at the same time..I tried
to use

if(!addressLine[i]){
//Print value..
}

but same problem..- Hide quoted text -

- Show quoted text -

>>I am sorry I meant..

> if(addressLine[i]){
//Print value..
}

addressLine[0] = "String1";
addressLine[1] = "String2";
addressLine[2] = NULL;

...

for (i = 0; i < 8; i++)

Did you mean:

for ( i = 0; addressLine[i] != 0; ++i )

or:

for ( i = 0; i < 2; ++i )

But why is 8 used in the first place if only two entries are needed?
Best

Kai-Uwe Bux

[red floyd]

jh*******@fastermail.com wrote:

The following program compiles successfully on a Microsoft Visual C++
6.0 compiler but when I execute it..it encounters an unknown
error..may be a because of a seg fault..

#include <string.h>
#include <iostream.h>

int main(int argc, char **argv){
int i;
int len;
char *addressLine[8];

addressLine[1] = "String1";
addressLine[2] = "String2";

for(i = 1; i <= 8; i++){
len = strlen(addressLine[i]);
if (len >= 1){
cout << "Address: " << addressLine[i];
cout << "\n";
}
}
return (0);
}

1. C++ arrays go from 0 to N-1, so addressLine[8] doesn't exist.
2. You never initialize addressLine[0] or addressLine[2 through 7].
3. iostream.h is non-standard, use <iostreamand std::cout
4. You never use string.h. Don't include it. Also, use <cstring>
instead of string.h.

[runner]

"Kai-Uwe Bux" <jk********@gmx.netwrote in message
news:fc**********@murdoch.acc.Virginia.EDU...

runner wrote:

<jh*******@fastermail.comwrote in message
news:11**********************@r29g2000hsg.googlegr oups.com...
On Sep 16, 5:38 pm, [e-mail] wrote:

On Sep 16, 5:27 pm, "Laurent D.A.M. MENTEN"

<[e-mail]:
[e-mail] a écrit :

The following program compiles successfully on a Microsoft Visual

C++

6.0 compiler but when I execute it..it encounters an unknown
error..may be a because of a seg fault..

#include <string.h>
#include <iostream.h>

int main(int argc, char **argv){
int i;
int len;
char *addressLine[8];

addressLine[1] = "String1";
addressLine[2] = "String2";

for(i = 1; i <= 8; i++){
len = strlen(addressLine[i]);
if (len >= 1){
cout << "Address: " << addressLine[i];
cout << "\n";
}
}
return (0);
}

but when I just use the following without the loop..

cout << "Address: " << addressLine[1];

it just works fine...

Please help!...

You did not initialize entries 3..8 of the addressLine array... their
content is pure garbage...- Hide quoted text -

- Show quoted text -

Thanks! for ur reply..I need to use only 2 entries in the array...How
do I iterate and print by handling the error at the same time..I tried
to use

if(!addressLine[i]){
//Print value..
}

but same problem..- Hide quoted text -

- Show quoted text -

>I am sorry I meant..

if(addressLine[i]){
//Print value..
}

addressLine[0] = "String1";
addressLine[1] = "String2";
addressLine[2] = NULL;

...

for (i = 0; i < 8; i++)

Did you mean:

for ( i = 0; addressLine[i] != 0; ++i )

or:

for ( i = 0; i < 2; ++i )

But why is 8 used in the first place if only two entries are needed?
Best

Kai-Uwe Bux

1)

I did mean

addressLine[0] = "String1";
addressLine[1] = "String2";
addressLine[2] = NULL;
....
addressLine[7] = NULL;

for (i = 0; i < 8; i++)
if(addressLine[i])
{
//Print value..
}

to show the OP that the array index starts from 0
and that

for (i = 1; i <= 8; i++)

would be wrong anyway.

2)

that said, i would go for

for ( i = 0; addressLine[i]; i++ )

which is more efficient and general.

3)

I wouldn't use

for ( i = 0; i < 2; i++ )

because it's not "easily" reusable due to the
hard-coded number of iterations.

[James Kanze]

On Sep 17, 12:52 am, "runner" <emb@ddedwrote:

<[e-mail] in message
news:11**********************@r29g2000hsg.googlegr oups.com...
On Sep 16, 5:38 pm, [e-mail] wrote:

On Sep 16, 5:27 pm, "Laurent D.A.M. MENTEN"

<[e-mail]:

[e-mail] a écrit :

The following program compiles successfully on a
Microsoft Visual C++ 6.0 compiler but when I execute
it..it encounters an unknown error..may be a because of
a seg fault..

#include <string.h>
#include <iostream.h>

int main(int argc, char **argv){
int i;
int len;
char *addressLine[8];

addressLine[1] = "String1";
addressLine[2] = "String2";

for(i = 1; i <= 8; i++){
len = strlen(addressLine[i]);
if (len >= 1){
cout << "Address: " << addressLine[i];
cout << "\n";
}
}
return (0);
}

but when I just use the following without the loop..

cout << "Address: " << addressLine[1];

it just works fine...

You did not initialize entries 3..8 of the addressLine array... their
content is pure garbage...- Hide quoted text -

Thanks! for ur reply..I need to use only 2 entries in the array...How
do I iterate and print by handling the error at the same time..I tried
to use

if(!addressLine[i]){
//Print value..
}
but same problem.

I am sorry I meant..
if(addressLine[i]){
//Print value..
}

addressLine[0] = "String1";
addressLine[1] = "String2";
addressLine[2] = NULL;

First, of course, the obvious solution is to use std::vector<
std::string >; std::vector can be adjusted to the required size.
But given what he's got, he really should write:

char const* addressLine[ 8 ] = { "String1", "String2 } ;

Never, never leave a pointer uninitialized.

--
James Kanze (GABI Software) email:ja*********@gmail.com
Conseils en informatique orientée objet/
Beratung in objektorientierter Datenverarbeitung
9 place Sémard, 78210 St.-Cyr-l'École, France, [phone]