Need help with Loading data from Text file

[Apollo1376]

I am very new to C++. I need some help with loading/reading data from text file and write in an array.

I have the following data.
12/31/2004 1213.55 1217.33 1211.65 1211.92 786900000 1211.92
12/30/2004 1213.45 1216.47 1213.41 1213.55 829800000 1213.55
12/29/2004 1213.54 1213.85 1210.95 1213.45 925900000 1213.45
12/28/2004 1204.92 1213.54 1204.92 1213.54 983000000 1213.54
12/27/2004 1210.13 1214.13 1204.92 1204.92 922000000 1204.92
12/23/2004 1209.57 1213.66 1208.71 1210.13 956100000 1210.13

I want to read the data from "CompFinSumAssi.txt" file and write in an array. I want access the data by columns. Here is what I have done so far. Program runs but goes into a infinite loop. I doesn't display the right values either. Someone please let me know what I am doing wrong. Note that so far I didn't try to write into an array, I just tried to display on the screen first. Hint into how to write into an array will be well appreciated.

#include<fstream>
using std::ifstream;
#include<cstdlib> // this is exit function
// Read the values from CompFinSumAssi.txt
 
int Load_Price_Data()
{
 
  ifstream indata;
 
  float date, Open, high, low, close,volume, price; //variable for input price value
 
  //char date; //variable for input date
 
  indata.open("CompFinSumAssi.txt"); //opens the file
  if(!indata) {
    cerr << "Error: file could not be opened" << endl;
    exit(1);
  }
 
  // Read the data from the file
 
  indata >> date >> Open >> high >> low >> close >> volume >> price; 
 
  while( !indata.eof() ) { // keep reading until end-of-file
    cout << "The data in the file is:" << date << " "<<Open<<" "<<high<<" "<<low<<" "<<close<<" "<<volume<<" "<<price<<endl;
 
    indata >> date >> Open>> high >> low >> close >> volume >> price;   
 
    //indata >> date;
  }
 indata.close();
  cout <<"End of file is reached" << endl;
  return 0;
}
 
int main() {
 Load_Price_Data();
}
 

Thanks
Raam

[Savage]

I am very new to C++. I need some help with loading/reading data from text file and write in an array.

I have the following data.
12/31/2004 1213.55 1217.33 1211.65 1211.92 786900000 1211.92
12/30/2004 1213.45 1216.47 1213.41 1213.55 829800000 1213.55
12/29/2004 1213.54 1213.85 1210.95 1213.45 925900000 1213.45
12/28/2004 1204.92 1213.54 1204.92 1213.54 983000000 1213.54
12/27/2004 1210.13 1214.13 1204.92 1204.92 922000000 1204.92
12/23/2004 1209.57 1213.66 1208.71 1210.13 956100000 1210.13

I want to read the data from "CompFinSumAssi.txt" file and write in an array. I want access the data by columns. Here is what I have done so far. Program runs but goes into a infinite loop. I doesn't display the right values either. Someone please let me know what I am doing wrong. Note that so far I didn't try to write into an array, I just tried to display on the screen first. Hint into how to write into an array will be well appreciated.

#include<fstream>
using std::ifstream;
#include<cstdlib> // this is exit function
// Read the values from CompFinSumAssi.txt
 
int Load_Price_Data()
{
 
  ifstream indata;
 
  float date, Open, high, low, close,volume, price; //variable for input price value
 
  //char date; //variable for input date
 
  indata.open("CompFinSumAssi.txt"); //opens the file
  if(!indata) {
    cerr << "Error: file could not be opened" << endl;
    exit(1);
  }
 
  // Read the data from the file
 
  indata >> date >> Open >> high >> low >> close >> volume >> price; 
 
  while( !indata.eof() ) { // keep reading until end-of-file
    cout << "The data in the file is:" << date << " "<<Open<<" "<<high<<" "<<low<<" "<<close<<" "<<volume<<" "<<price<<endl;
 
    indata >> date >> Open>> high >> low >> close >> volume >> price;   
 
    //indata >> date;
  }
 indata.close();
  cout <<"End of file is reached" << endl;
  return 0;
}
 
 
 
int main() {
 Load_Price_Data();
}
 

Thanks
Raam

You might want to check for the stream state in your while loop.You can do this either with good or bad basic_stream methods

[sicarie]

Yeah, I believe what Savage is getting to lies in your date (though I'm not sure, Savage, please let me know if I am mis-quoting you), and attempting to read the '/'s into floats. I believe that conversion is messing you up. Have you looked into a stringstream to parse those?

ie, use getline() to get a line of data, stringstream to parse into variables...

As for arrays, do you know how many there are going to be? Are you going to create an array of structures/classes to hold each line, or separate arrays for each different type of variable (and then for each reference, say the first, all the entries will be in slot 0 of all the arrays)?

[Apollo1376]

Yeah, I believe what Savage is getting to lies in your date (though I'm not sure, Savage, please let me know if I am mis-quoting you), and attempting to read the '/'s into floats. I believe that conversion is messing you up. Have you looked into a stringstream to parse those?

ie, use getline() to get a line of data, stringstream to parse into variables...

As for arrays, do you know how many there are going to be? Are you going to create an array of structures/classes to hold each line, or separate arrays for each different type of variable (and then for each reference, say the first, all the entries will be in slot 0 of all the arrays)?

Thank you, I realized my problem is in the date '/', Can I do that using a char or char*?

Thanks
Raam

[sicarie]

Thank you, I realized my problem is in the date '/', Can I do that using a char or char*?

Thanks
Raam

You might be able to declare a string and still use the fin >> operator as you are now, but if you can't, I would recommend a stringstream.

[Apollo1376]

Yeah, I believe what Savage is getting to lies in your date (though I'm not sure, Savage, please let me know if I am mis-quoting you), and attempting to read the '/'s into floats. I believe that conversion is messing you up. Have you looked into a stringstream to parse those?

ie, use getline() to get a line of data, stringstream to parse into variables...

As for arrays, do you know how many there are going to be? Are you going to create an array of structures/classes to hold each line, or separate arrays for each different type of variable (and then for each reference, say the first, all the entries will be in slot 0 of all the arrays)?

Thanks, I know exactly how many lines of data I have. I plan to use an m*n dimensional array. In this case I know exactly 'm' and 'n' are. May be I should do is use getline() and store the line in the first row of the matrix. Then hope to access the data column wise.

Thanks
Raam

[sicarie]

Thanks, I know exactly how many lines of data I have. I plan to use an m*n dimensional array. In this case I know exactly 'm' and 'n' are. May be I should do is use getline() and store the line in the first row of the matrix. Then hope to access the data column wise.

Thanks
Raam

Just keep types in mind when you declare that size m*n array, you're only going to be able to use the type it is declared as. If you pull them directly from getline (ie as strings), you can put them all in a char* or string array, and then use atof() to convert those you need to, or you can convert them, create separate m number of n-sized arrays of different types, and do what you need with them. The second method might be preferred just for the sake of code preservation - if you need to go back and change it later you'll get weird errors until you remember that you need to atof() them...

Seems like you've got it, though. Please feel free to post again if you get stuck.