The function readit() seems to jump to writeit() when it shouldn't

[doskey]

::links not allowed, please read the Posting Guidelines::

The function readit() seems to jump to writeit() when it shouldn't in read.c This has got me stumped. After inside the readit() gets called it seems to when the function ends it seems to just process the writeit() when it isn't being called. Any help would be much appreciated :P

[doskey]

I know the checkbuff() function is lame that's why it isn't being used.

[sicarie]

I know the checkbuff() function is lame that's why it isn't being used.

Can we see a snippet of your code? The useful parts would probably be the declarations and the implementations of those functions, maybe a line or two before and after.

[doskey]

Well i will post 2 pages
It seems to be when the readit() gets called, it just jumps and writeit() gets processed

-------READ.C----------------

#ifndef filesize
#define filesize 2001
#endif
 
struct tmpcommands{
       FILE *fp;
       };
 
extern void filehelp_text(char file[]){
       printf("\nFILE FUNCTIONS: ");
       printf("\nUsage is %s <COMMAND> <FILE> -f \n", file);
       printf("Commands are -read, -append, -write, -delete\n");
       printf("Remember the -f flag must be activated to use the file functions\n");
       }
 
 
 
extern void readit(char file[]){
       char filedata[80];
       struct tmpcommands init;
       init.fp = fopen(file, "r");
       while(fgets(filedata, 80, init.fp)!=NULL)
       printf("%s\n", filedata);
       fclose(init.fp);
       }
 
 
extern void writeit(char file[]){
      char filedata[80];
      struct tmpcommands init;      
 
      if(init.fp = fopen(file, "r"))
         if(init.fp != NULL){
               int hasbofprotect = 0;
               char writedata[filesize];
               char bofprotect[filesize];
               fprintf(stdout, "The file contains data,\nplease enter some data to create the file and save the text\n");
               fclose(init.fp);
               init.fp = fopen(file, "w");
               fscanf(stdin, "%s", &writedata);
 
               if(strlen(writedata) >= filesize){
                       fprintf(stdout, "Error max file size length is 2000 bytes\n you entered %d bytes\n", strlen(writedata));
                       fprintf(stdout, "Please enter some text, remember max file size is 2000 bytes. :P\n");
                       fscanf(stdin, "%s", &bofprotect);
                       fprintf(init.fp, "%s", bofprotect);
                       hasbofprotect = 1;
                       }
 
               if(hasbofprotect == 0){
               fprintf(init.fp, "%s", writedata);
               fprintf(stdout, "Everything is wrote to the file.\n");
               fclose(init.fp);
               }
 
         }
         else
         {
               char writedata[filesize];
 
 
 
      fprintf(stdout, "You have chosen to write some data into the file: %s.\n", file);
 
 
      }
      }
 
extern void appit(char file[]){
      char filedata[80];
      struct tmpcommands init;
     }
 
 
 
#ifdef filesize
#undef filesize
#endif

----MAIN.C-----------

#include <stdio.h>
#include <string.h>
#include <stdlib.h>
#include "main.h"
#include "safe.c"
#include "read.c"
 
/* checkbuff(buffer); A little command i made to check for bof in text which can be quite usefull */
 
static void command(char command[commandlen], char file[20], char flag[2]){
       struct tmpcommands issue;
       char com[10];
       int iffile = 0;
 
       if(strcmp(flag, "-f") != 1)
         iffile = 1;
 
       if(iffile != 0){
       if(strcmp(command, "-read") != 1)
       readit(file);
 
       if(strcmp(command, "-write") != 1)
       writeit(file);
 
       if(strcmp(command, "-append") !=1)
       appit(file);
 
       }
       }
 
 
int main(int argc, char *argv[]){
 
/* Main variables */
char buffer[max_buff];
char proccommand[commandlen];
int i=0;
 
if (argc < 4 ){
 
filehelp_text(argv[0]);
fprintf(stdout, "I am busy adding more commands, this program is still under development\n\n"); 
return 1;
 
}
 
command(argv[1], argv[2], argv[3]);
 
 
return 0;
}

[weaknessforcats]

if(strcmp(command, "-read") != 1)
readit(file);

if(strcmp(command, "-write") != 1)
writeit(file);

if(strcmp(command, "-append") !=1)
appit(file);

This is not good programming style. strcmp() returns a value of 0 when the comparison is equal and a value <0 when command is less than the second srgumennt. Both of these are !=1.

So if command is "-append", that's less than "-read", you you call readit().
Then "-append" is less than "-write" so you call writeit().
Then "-append" is equal to "-append" so you call appit().

Do you mean:

if(strcmp(command, "-read") != 0)
readit(file);
 
if(strcmp(command, "-write") != 0)
writeit(file);
 
if(strcmp(command, "-append") !=0)
appit(file);
 

???

[doskey]

This is not good programming style. strcmp() returns a value of 0 when the comparison is equal and a value <0 when command is less than the second srgumennt. Both of these are !=1.

So if command is "-append", that's less than "-read", you you call readit().
Then "-append" is less than "-write" so you call writeit().
Then "-append" is equal to "-append" so you call appit().

Do you mean:

if(strcmp(command, "-read") != 0)
readit(file);
 
if(strcmp(command, "-write") != 0)
writeit(file);
 
if(strcmp(command, "-append") !=0)
appit(file);
 

???

Well..... I thought strcmp returned 0 if the comparison is equal. I have changed it to !=0 and this is the result

doskey@DosKeys-Xion-sys:~/Desktop/project/src$ gcc main.c -o test
doskey@DosKeys-Xion-sys:~/Desktop/project/src$ ./test -read c -f
doskey@DosKeys-Xion-sys:~/Desktop/project/src$ ./test -read c -fa
The file contains data,
please enter some data to create the file and save the text
kjh
Everything is wrote to the file.

For some reason the -f flag needs another byte.... actually you can use any two bytes like -ba as an arguement. Also as you can see, when i used -read it still skipped and went to the writeit(). No matter what i put -append, -read, -write it's always jumping to the writeit() function.

This is the modified command() function

static void command(char command[commandlen], char file[20], char flag[2]){
       struct tmpcommands issue;
       char com[10];
       int iffile = 0;
 
       if(strcmp(flag, "-f"))
         iffile = 1;
 
       if(iffile == 1){
       if(strcmp(command, "-read")!=0)
       readit(file);
 
       if(strcmp(command, "-write")!=0)
       writeit(file);
 
       if(strcmp(command, "-append")!=0)
       appit(file);
 
       }
       }
 

As you can see this program is doing stuff it hasn't been programmed to do.
I NEED HELP !!!!!!!!

[weaknessforcats]

How about you try:

if(strcmp(command, "-read") == 0)
readit(file);
 
if(strcmp(command, "-write") == 0)
writeit(file);
 
if(strcmp(command, "-append") ==0)
appit(file);
 

My apology that I didn't see this on my previous post.

[doskey]

It seems it doesn't work. I don't know where i am going wrong here? HELP !!!!

[weaknessforcats]

Your problem is somewhere else. I took this code and made some stub functions and hard-coded a command. I then changed the command, recompiled. Each time I got the correct results: only one function was called.

void readit()
{
   cout << "readit" << endl;
}
void writeit()
{
   cout << "writeit" << endl;
}
void appit()
{
   cout << "appit" << endl;
}
int main()
{
      char command[] = "-append";
      if(strcmp(command, "-read") == 0)
        readit();
 
        if(strcmp(command, "-write") == 0)
        writeit();
 
        if(strcmp(command, "-append") ==0)
        appit();
 
}
 

[doskey]

That's C++, you can't use C++ in your C code :S

[weaknessforcats]

That's C++, you can't use C++ in your C code :S

You are right. Old habits. Just change the cout to a printf.