please let me know how to write the wraper function

[rasmidas]

I have a function sEntityFree() which is a function from a third party S/w we are using. For this we have our enhanced code.
sEntityFree() has been called inside our enhanced code 2000 or 3000 times. But NULL pointer checking before freeing the memory is not there.
Like the function has been called as below:

sEntityFree(Entity, ( void** )&StructPtr, sYES );
or
sEntityFree(Entity, ( void** )&StructPtr, sNO );

If I will write it as

if((Entity != NULL) && (StructPtr != NULL))
sEntityFree(Entity, ( void** )&StructPtr, sYES );

Then I have to write this repeatedly as many times the function has been called.
Even I could not change inside the function sEntityFree(), as the code is not with us.
Hence I wanted to write a wraper function like this:

int cMemoryFree(sENTITY * Entity,void** StructPtr,sYORN FreeMemory)
{
   int ret = sSUCCESS;   //#define sSUCCESS      0
 
   if((FreeMemory == sYES) && (Entity != NULL) && (StructPtr != NULL))
   {
      ret = sEntityFree(Entity, ( void** )&StructPtr, sYES );
   }
   else if((FreeMemory == sNO) && (StructPtr != NULL))
   {
      ret = sEntityFree(Entity, ( void** )&StructPtr, sNO );
   }
   return ret;
}
 

But this is giving segmentation fault. Please let me know how to write this cMemoryFree() wraper function.

Note: Here is the skeleton for sEntityFree()

int sEntityFree( sENTITY * Entity, 
                      void**    StructPtr, 
                      sYORN FreeMemory )
 

Entity : Entity pointer

StructPtr : void pointer to the pointer of the entity
data structure.

FreeMemory : Flag to indicate if the entity pointer
should be freed.

Please let me know. Thanks.

[weaknessforcats]

You are barking up a dead tree.

No amount of code can tell you whether it's safe to free something.

You need to know of there are any other pointers in the program that point to the thing you think you want to delete. If there are, and you delete, your program will crash somewhere else when the deleted memory is deleted again of if another pointer tries to access the variable that has been deleted.

The single most dangerous thing you can do in a program is pass pointers around and then try to make decsisions about freeing up memory.

You don't say if you are in C or C++.

If you are in C, you will need to build in reference counting on all of your pointers. And even this may not work since there's no guarantee that everyone will adhere to the reference counting rules.

In C++, you just use a handle. In this link there is a handle template you can just copy out and use in your application.