strings and arrays

[Nkhosinathie]

hello everyone,i'm writing this program to enter a name and marks of a student and after that a message should pop out to say whether the student has passed or supplementing or repeating next year. this is what i did but i'm already giving it up coz i can't find the solution




#include<iostream>
#include<string>

using namespace std;
#include<iomanip>

void getInput(string & ,int&);
void displayResults(string [],int []);

int main()
{


int MarkP[15]={0} ;

string NameP[15]={0};

for(int x=1;x<=15; x++)
{
getInput(NameP[15],MarkP[15]);
displayResults(NameP[15],MarkP[15]);
}

return 0;
}
void getInput(string &NameP,int &MarkP)

{ cout<<"Enter the Name of the student\n";

cout<<"Name\t\tMarks\n";

cin>>NameP;
cout<<"\t\t";
cin>>MarkP;


}






void displayResults(string NameP[],int MarkP)
{
if(MarkP<=39)

cout<<"you failed the course and come next year to repeat\n";

if(MarkP>=40 && MarkP<=49)

cout<<"You may write the supplementary examination\n";

if(MarkP>=50 && MarkP<=74)

cout<<"Congratulations!!You passed the examination\n";

if(MarkP>=75 && MarkP<=100)

cout<<"You passes with a distinction\n";

if(MarkP>100)
{cout<<"The number you entered is in valid\n";
cout<<"Please choose a value between 0 and 100\n";
}
}



please help.

[r035198x]

hello everyone,i'm writing this program to enter a name and marks of a student and after that a message should pop out to say whether the student has passed or supplementing or repeating next year. this is what i did but i'm already giving it up coz i can't find the solution




#include<iostream>
#include<string>

using namespace std;
#include<iomanip>

void getInput(string & ,int&);
void displayResults(string [],int []);

int main()
{


int MarkP[15]={0} ;

string NameP[15]={0};

for(int x=1;x<=15; x++)
{
getInput(NameP[15],MarkP[15]);
displayResults(NameP[15],MarkP[15]);
}

return 0;
}
void getInput(string &NameP,int &MarkP)

{ cout<<"Enter the Name of the student\n";

cout<<"Name\t\tMarks\n";

cin>>NameP;
cout<<"\t\t";
cin>>MarkP;


}






void displayResults(string NameP[],int MarkP)
{
if(MarkP<=39)

cout<<"you failed the course and come next year to repeat\n";

if(MarkP>=40 && MarkP<=49)

cout<<"You may write the supplementary examination\n";

if(MarkP>=50 && MarkP<=74)

cout<<"Congratulations!!You passed the examination\n";

if(MarkP>=75 && MarkP<=100)

cout<<"You passes with a distinction\n";

if(MarkP>100)
{cout<<"The number you entered is in valid\n";
cout<<"Please choose a value between 0 and 100\n";
}
}



please help.

1.) Never give up
2.) Use code tags when posting code
3.) Go through a basic tutorial on using strings in c++. Test the programs they give in that tutorial and then try your problem again. When you get stuck again, post in this thread both your attempt and the error messages that you get.

[Nkhosinathie]

1.) Never give up
2.) Use code tags when posting code
3.) Go through a basic tutorial on using strings in c++. Test the programs they give in that tutorial and then try your problem again. When you get stuck again, post in this thread both your attempt and the error messages that you get.

my problem is my program only takes the first name not the last name,

[weaknessforcats]

my problem is my program only takes the first name not the last name,

Don't forget that cin>> stops on whitespace.

You might look up cin.getline() which can receive the entire line entered including all of the separate words.

[Nkhosinathie]

Don't forget that cin>> stops on whitespace.

You might look up cin.getline() which can receive the entire line entered including all of the separate words.

#include<iostream>
#include<string>

using namespace std;
void getInput(string & ,int&);
void displayResults(string [],int []);

int main()
{


int MarkP[15]={0} ;

string NameP[15]={0};

for(int x=1;x<=15; x++)
{
getInput(NameP,MarkP);
displayResults(NameP,MarkP);
}

return 0;
}
void getInput(string &NameP,int &MarkP)

{ cout<<"Enter the Name of the student\n";

cout<<"Name\t\tMarks\n";

cin.getline(NameP);
cout<<"\t\t";
cin>>MarkP;


}
i tried to put that
cin.getline();
it is giving me another two errors that i don't understand.

please help

[Nkhosinathie]

#include<iostream>
#include<string>

using namespace std;
void getInput(string & ,int&);
void displayResults(string [],int []);

int main()
{


int MarkP[15]={0} ;

string NameP[15]={0};

for(int x=1;x<=15; x++)
{
getInput(NameP,MarkP);
displayResults(NameP,MarkP);
}

return 0;
}
void getInput(string &NameP,int &MarkP)

{ cout<<"Enter the Name of the student\n";

cout<<"Name\t\tMarks\n";

cin.getline(NameP);
cout<<"\t\t";
cin>>MarkP;


}
i tried to put that
cin.getline();
it is giving me another two errors that i don't understand.

please help

i'm really desperate to get this right. i've tried but i'm really filing to get it right

[ilikepython]

#include<iostream>
#include<string>

using namespace std;
void getInput(string & ,int&);
void displayResults(string [],int []);

int main()
{


int MarkP[15]={0} ;

string NameP[15]={0};

for(int x=1;x<=15; x++)
{
getInput(NameP,MarkP);
displayResults(NameP,MarkP);
}

return 0;
}
void getInput(string &NameP,int &MarkP)

{ cout<<"Enter the Name of the student\n";

cout<<"Name\t\tMarks\n";

cin.getline(NameP);
cout<<"\t\t";
cin>>MarkP;


}
i tried to put that
cin.getline();
it is giving me another two errors that i don't understand.

please help

Ok for the getline, use this:

getline(cin, NameP);
 

Also, you need a cin.ignore to eat the newline left by cin>>.

void getInput(string &NameP, int &MarkP)
{
    cout<<"Enter the Name of the student\n";
    cout<<"Name\t\tMarks\n";
 
    getline(cin, NameP);
    cout << "\t\t";
    cin >> MarkP;
    cin.ignore();
}
 

Also, you for loop is wrong. :

for (int x = 0; x < 15; x++)
{
    getInput(NameP[x], MarkP[x]);
    displayResults(NameP, MarkP);
}
 

And initialize your string array with a string:

string NameP[15] = {""};
 

[undead202]

how can i compare 2 string....
sample if i input a id number of a student and that number is already exist it must print that an id is already in use.

[ilikepython]

how can i compare 2 string....
sample if i input a id number of a student and that number is already exist it must print that an id is already in use.

Please don't ask questions in other people's threads. Use the "==" operator.

[Nkhosinathie]

Ok for the getline, use this:

getline(cin, NameP);
 

Also, you need a cin.ignore to eat the newline left by cin>>.

void getInput(string &NameP, int &MarkP)
{
    cout<<"Enter the Name of the student\n";
    cout<<"Name\t\tMarks\n";
 
    getline(cin, NameP);
    cout << "\t\t";
    cin >> MarkP;
    cin.ignore();
}
 

Also, you for loop is wrong. :

for (int x = 0; x < 15; x++)
{
    getInput(NameP[x], MarkP[x]);
    displayResults(NameP, MarkP);
}
 

And initialize your string array with a string:

string NameP[15] = {""};
 

thank you,i did that,now it is giving me two errors about getline.
this is the code that i did




#include<iostream>
#include<string>
using namespace std;
using std::getline;
void getInput(string & ,int&);
void displayResults(string [],int []);


int main()
{

int MarkP[15];

string NameP[15];

for(int x=1;x<15; x++)
{
getInput(NameP[x],MarkP[x]);
displayResults(NameP,MarkP);
}

return 0;
}
void getInput(string &NameP,int &MarkP)

{


cout<<"Enter the Name of the student\n";
cout<<"Name\t\tMarks\n";
getline(cin, NameP);
cout << "\t\t";
cin >> MarkP;
cin.ignore();

}
void displayResults(string &NameP,int &MarkP)
{
if(MarkP>=0&&MarkP>=39)
{
cout<<"\n failed";
}

[gsi]

Hi,
Firstly, your initialization of ' int MarkP[15]={0} ; ' initializes only the first element to zero, Same for the string array allocation.

for(int x=1;x<=15; x++)
{
getInput(NameP,MarkP);
displayResults(NameP,MarkP);
}
 

Why do you have an array allocated if you are passing the same address to the the functions. You are always passing in the address of the first element by using Namep and MarkP. As stated previously your array is having an out of bound access.


Thanks,
gsi.

[ilikepython]

thank you,i did that,now it is giving me two errors about getline.
this is the code that i did




#include<iostream>
#include<string>
using namespace std;
using std::getline;
void getInput(string & ,int&);
void displayResults(string [],int []);


int main()
{

int MarkP[15];

string NameP[15];

for(int x=1;x<15; x++)
{
getInput(NameP[x],MarkP[x]);
displayResults(NameP,MarkP);
}

return 0;
}
void getInput(string &NameP,int &MarkP)

{


cout<<"Enter the Name of the student\n";
cout<<"Name\t\tMarks\n";
getline(cin, NameP);
cout << "\t\t";
cin >> MarkP;
cin.ignore();

}
void displayResults(string &NameP,int &MarkP)
{
if(MarkP>=0&&MarkP>=39)
{
cout<<"\n failed";
}

Is it? It compiles fine on Dev-Cpp 4.9.9.2. Also, your loop should start from 0, not 1.

[Nkhosinathie]

Hi,
Firstly, your initialization of ' int MarkP[15]={0} ; ' initializes only the first element to zero, Same for the string array allocation.

for(int x=1;x<=15; x++)
{
getInput(NameP,MarkP);
displayResults(NameP,MarkP);
}
 

Why do you have an array allocated if you are passing the same address to the the functions. You are always passing in the address of the first element by using Namep and MarkP. As stated previously your array is having an out of bound access.


Thanks,
gsi.

thanks for your help, but i'm new to this arrays so i'm putting all what i have.
mu proble now is if i compile the program it is complaining about getline.

[gsi]

Hi,
Sorry didnt lookup your previous post bfore submitting the reply. In the corrected version you are passing the same address to the display funtion while you are incrementing the address in the getinput function. in this case it must be displayResults(NameP[x],MarkP[x]);

Pls try this

for(int x=0;x<15; x++)
{
getInput(NameP[x],MarkP[x]);
displayResults(NameP[x],MarkP[x]);
}
 

Also think of your usage of an array if you are not storing in any data.

Thanks,
gsi.

[ilikepython]

Firstly, your initialization of ' int MarkP[15]={0} ; ' initializes only the first element to zero, Same for the string array allocation.

That's only true for the string. The integer array is initialized with the value in the braces for all elements. Strings are automatically constructed with an empty string. There is no need to do this:

string arr[15] = {""};
 

Sorry that was my mistake.

[Nkhosinathie]

Hi,
Sorry didnt lookup your previous post bfore submitting the reply. In the corrected version you are passing the same address to the display funtion while you are incrementing the address in the getinput function. in this case it must be displayResults(NameP[x],MarkP[x]);


Also think of your usage of an array if you are not storing in any data.

Thanks,
gsi.

the way this program is; i have to input 15 students name and their marks and after that i have to display whether they have passed,supplementing or failed. that is why i'm storing those arrays before i can display them

[ilikepython]

Hi,
Sorry didnt lookup your previous post bfore submitting the reply. In the corrected version you are passing the same address to the display funtion while you are incrementing the address in the getinput function. in this case it must be displayResults(NameP[x],MarkP[x]);

Pls try this

for(int x=0;x<15; x++)
{
getInput(NameP[x],MarkP[x]);
displayResults(NameP[x],MarkP[x]);
}
 

Also think of your usage of an array if you are not storing in any data.

Thanks,
gsi.

Yes, I noticed that but the OP's delcareation of the function takes an array, so I figured he wanted to print the values at every iteration. Not sure what you mean by incrementing the address in the input function.

[ilikepython]

the way this program is; i have to input 15 students name and their marks and after that i have to display whether they have passed,supplementing or failed. that is why i'm storing those arrays before i can display them

In you results function do you want to iterate over the array and display the results at the end or do you want to take a single student and call the function every iteration of the loop?

[Nkhosinathie]

Yes, I noticed that but the OP's delcareation of the function takes an array, so I figured he wanted to print the values at every iteration. Not sure what you mean by incrementing the address in the input function.

this is the code that i have so far, actually i'm storing information before i can display it. i have to store 15 names and 15 marks of the students before i can display whether they have passed or failed





#include<iostream>
#include<string>
using namespace std;
using std::getline;
void getInput(string & ,int&);
void displayResults(string [],int []);


int main()
{

int MarkP[15];

string NameP[15];

for(int x=1;x<15; x++)
{
getInput(NameP[x],MarkP[x]);
displayResults(NameP,MarkP);
}

return 0;
}
void getInput(string &NameP,int &MarkP)

{


cout<<"Enter the Name of the student\n";
cout<<"Name\t\tMarks\n";
getline(cin,NameP);
cout << "\t\t";
cin >> MarkP;
cin.ignore();

}
void displayResults(string &NameP,int &MarkP)
{
if(MarkP>=0&&MarkP>=39)
{
cout<<"\n failed";
}




}

[Nkhosinathie]

In you results function do you want to iterate over the array and display the results at the end or do you want to take a single student and call the function every iteration of the loop?

no sir, i have to store all the names and marks before i can display whether they have passed of failed.

[gsi]

Hi,
Sorry for the confusion it must have been 'iterating the array' rather than 'incrementing the address' . Also it would have been a problem only if he had intended to initialize the array with a value other than zero, since they are all intialized to zero if with less initializers than the declared array subscript. I shouldn't have pointed out that.

thanks,
gsi.

[ilikepython]

this is the code that i have so far, actually i'm storing information before i can display it. i have to store 15 names and 15 marks of the students before i can display whether they have passed or failed





#include<iostream>
#include<string>
using namespace std;
using std::getline;
void getInput(string & ,int&);
void displayResults(string [],int []);


int main()
{

int MarkP[15];

string NameP[15];

for(int x=1;x<15; x++)
{
getInput(NameP[x],MarkP[x]);
displayResults(NameP,MarkP);
}

return 0;
}
void getInput(string &NameP,int &MarkP)

{


cout<<"Enter the Name of the student\n";
cout<<"Name\t\tMarks\n";
getline(cin,NameP);
cout << "\t\t";
cin >> MarkP;
cin.ignore();

}
void displayResults(string &NameP,int &MarkP)
{
if(MarkP>=0&&MarkP>=39)
{
cout<<"\n failed";
}




}

Firstly, don't post the code again, if you didn't change anything, and if you did only post the relative parts. Second please use code tags when replying, they are on they right side of the page.

Ok, so what's the problem?:

for (int x = 0; x < 15; x++)
{
    getInput(NameP[x], MarkP[x]);
    displayResults(NameP[x], MarkP[x]);
}
 

[ilikepython]

no sir, i have to store all the names and marks before i can display whether they have passed of failed.

Ok, then so you need to call the function after you are done storing the results:

for (int x = 0; x < 15; x++)
{
    getInput(NameP[x], MarkP[x]);
}
displayResults(NameP, MarkP);
 

Then in displayResults:

    iterate over arrays:
        determine results
        display whatever
 

[gsi]

Hi,

" i have to store all the names and marks before i can display whether they have passed of failed. "

Then do something like

for(i=0;i<15;++i)
displayResults(NameP[x], MarkP[x]);
}
 

after removing the displayResults function from your previous loop.

Thanks,
gsi.

[Nkhosinathie]

Firstly, don't post the code again, if you didn't change anything, and if you did only post the relative parts. Second please use code tags when replying, they are on they right side of the page.

Ok, so what's the problem?:

for (int x = 0; x < 15; x++)
{
    getInput(NameP[x], MarkP[x]);
    displayResults(NameP[x], MarkP[x]);
}
 

i'm so sorry about that. okay the problem is that it is giving me this two errors that i don't know how to solve them.





Compiling...
(31) : error C2667: 'getline' : none of 2 overload have a best conversion
C:\Documents and Settings\200729335.LAB2-R7-C1\Desktop\assistance.cpp(31) : error C2668: 'getline' : ambiguous call to overloaded function
Error executing cl.exe.

assistance.exe - 2 error(s), 0 warning(s)

[ilikepython]

i'm so sorry about that. okay the problem is that it is giving me this two errors that i don't know how to solve them.





Compiling...
(31) : error C2667: 'getline' : none of 2 overload have a best conversion
C:\Documents and Settings\200729335.LAB2-R7-C1\Desktop\assistance.cpp(31) : error C2668: 'getline' : ambiguous call to overloaded function
Error executing cl.exe.

assistance.exe - 2 error(s), 0 warning(s)

That's wierd, it works on my compiler. I think the problem is something about the compiler having trouble with the overloaded function. Try this:

getline(cin, NameP, '\n');
 

Edit:
What compiler are you using?

[Nkhosinathie]

That's wierd, it works on my compiler. I think the problem is something about the compiler having trouble with the overloaded function. Try this:

getline(cin, NameP, '\n');
 

Edit:
What compiler are you using?

i'm using microsoft visual c++ 6.0

[gsi]

Hi,
It works well with my compiler even, May be you should remove the redundant declararion ' using std::getline ', as you are pulling in the whole of std namespace in to your global scope by the previous line declaration of ' using namespace std ' in ur code.

Thanks,
gsi.

[Nkhosinathie]

Hi,



Then do something like

for(i=0;i<15;++i)
displayResults(NameP[x], MarkP[x]);
}
 

after removing the displayResults function from your previous loop.

Thanks,
gsi.

i have already done that, but the problem is. the compiler cannot convert parameter 1

[ilikepython]

i have already done that, but the problem is. the compiler cannot convert parameter 1

You have to change your function to:

void displayResults(string NameP, int MarkP);
 

[Nkhosinathie]

[quote=ilikepython]You have to change your function to:

void displayResults(string NameP, int MarkP);
 

[/QUOT


which means i have to change the the other function
void getInput to (string NameP[],int MarkP[])

[Nkhosinathie]

[quote=Nkhosinathie]

You have to change your function to:

void displayResults(string NameP, int MarkP);
 

[/QUOT


which means i have to change the the other function
void getInput to (string NameP[],int MarkP[])

this is the most c++ program i have ever struggled to compile,i haven't even eaten i've been struggling all day with it.

[ilikepython]

[quote=Nkhosinathie]

You have to change your function to:

void displayResults(string NameP, int MarkP);
 

[/QUOT


which means i have to change the the other function
void getInput to (string NameP[],int MarkP[])

No, no, no. Your other function is fine. You use it in a loop. Like this:

for (int x = 0; x < 15; x++)
{
    getInput(NameP[x], Mark[x]);
}
for (int x = 0; x < 15; x++)
{
    displayResults(NameP[x], Mark[x]);
}
 

Then you functions will look like this:

void getInput(string &NameP, int &MarkP);
void displayResults(string NameP, int MarkP);
 

[ilikepython]

[quote=Nkhosinathie]

this is the most c++ program i have ever struggled to compile,i haven't even eaten i've been struggling all day with it.

Don't worry, you'll get it. Please eat though, not good to compile on an empty stomach ;).

[Nkhosinathie]

[quote=ilikepython]

Don't worry, you'll get it. Please eat though, not good to compile on an empty stomach ;).

i won't sleep before i get it. sir i'm sorry if i'm stressing u but again this are the errors i'm getting after compiling,i'm really sorry if i'm stressing u




Compiling...
i
(37) : error C2667: 'getline' : none of 2 overload have a best conversion
C:\Documents and Settings\200729335.LAB2-R7-C1\Desktop\i'm serious.cpp(37) : error C2668: 'getline' : ambiguous call to overloaded function
Error executing cl.exe.

i.exe - 2 error(s), 0 warning(s)

[Nkhosinathie]

[quote=Nkhosinathie]

i won't sleep before i get it. sir i'm sorry if i'm stressing u but again this are the errors i'm getting after compiling,i'm really sorry if i'm stressing u




Compiling...
i
(37) : error C2667: 'getline' : none of 2 overload have a best conversion
C:\Documents and Settings\200729335.LAB2-R7-C1\Desktop\i'm serious.cpp(37) : error C2668: 'getline' : ambiguous call to overloaded function
Error executing cl.exe.

i.exe - 2 error(s), 0 warning(s)

[Nkhosinathie]

[quote=Nkhosinathie]sir.let me give that statement with the error:'
it is this one, the get line below





cout<<"Enter the Name of the student\n";
cout<<"Name\t\tMarks\n";
getline(cin,NameP);

cout << "\t\t";
cin>>MarkP;
cin.ignore()

[ilikepython]

[quote=Nkhosinathie]

sir.let me give that statement with the error:'
it is this one, the get line below





cout<<"Enter the Name of the student\n";
cout<<"Name\t\tMarks\n";
getline(cin,NameP);

cout << "\t\t";
cin>>MarkP;
cin.ignore()

Ok, try this:

cout<<"Enter the Name of the student\n";
cout<<"Name\t\tMarks\n";
char cstr[256];
cin.getline(cstr, 256);
NameP += cstr;
 

Hope it works.

[gsi]

Hi,

I am pretty sure that the above code snippet works with ur compiler, The global getline function defined in std namespace is not working as expected in vc++ 6. Also with strings it has a bug it seems, check out this,

http://support.microsoft.com/kb/240015

Thanks,
gsi.

[Nkhosinathie]

[quote=ilikepython]

Ok, try this:

cout<<"Enter the Name of the student\n";
cout<<"Name\t\tMarks\n";
char cstr[256];
cin.getline(cstr, 256);
NameP += cstr;
 

Hope it works.

thanks for the help,i will compile it and then i'll come back to you to tell you the results.i really appreciate your help

[Nkhosinathie]

[quote=Nkhosinathie]

thanks for the help,i will compile it and then i'll come back to you to tell you the results.i really appreciate your help

sir the first function to input the marks and names is working fine thanks to you.
this is the code:

void getInput(string& name,int& number)
{

cout<<"enter the marks of the student\n";
cin>>number;
cin.get();
cout<<"enter your first and last names\n";
getline(cin,name,'\n');
}

now i'm having the problem for the second function to display the results.
this is the code: i don't know how to retrieve the information from the input function.

displayResults(string names[],int marks[])
{

for(int h=0;h<3;h++)

[Nkhosinathie]

[quote=Nkhosinathie]

sir the first function to input the marks and names is working fine thanks to you.
this is the code:

void getInput(string& name,int& number)
{

cout<<"enter the marks of the student\n";
cin>>number;
cin.get();
cout<<"enter your first and last names\n";
getline(cin,name,'\n');
}

now i'm having the problem for the second function to display the results.
this is the code: i don't know how to retrieve the information from the input function.

displayResults(string names[],int marks[])
{

for(int h=0;h<3;h++)

actually my question is how to retrieve a data in an array?

[ilikepython]

[quote=Nkhosinathie]

actually my question is how to retrieve a data in an array?

You loop over it with a for loop:

void displayResults(string names[], int marks[])
{
    for (int i = 0; i < 15; i++)
    {
        // names[i] or marks[i] is the current element
    }
}
 

[Nkhosinathie]

[quote=ilikepython]

You loop over it with a for loop:

void displayResults(string names[], int marks[])
{
    for (int i = 0; i < 15; i++)
    {
        // names[i] or marks[i] is the current element
    }
}
 

thank you so much guys,i really appreciate your help and i managed to finish the program today afternoon.thank you so much and i'll continue helping others,thank you

[Nkhosinathie]

[quote=Nkhosinathie]

thank you so much guys,i really appreciate your help and i managed to finish the program today afternoon.thank you so much and i'll continue helping others,thank you

can someone pls close the thread.thanks.

[JosAH]

[quote=Nkhosinathie]

can someone pls close the thread.thanks.

Consider it done.

kind regards,

Jos