User breakpoint called from code at 0x****** when using delete operator

[Dreea]

Hello
Could anybody help me?
I have the following piece of code

 
cryptReturnVal = new BYTE[len];
char *cryptReturnValueChar;
 
// call decrypt function            
cryptReturnVal=(*decrypt)(input, len, secretKey, ecretKeySize);
 
// convert result in hexadecimal format
cryptReturnValueChar = fromCharToHexa(cryptReturnVal, len);
 
m_editOutput.SetWindowText(cryptReturnValueChar);
 
// free memory
delete [] cryptReturnVal;
delete cryptReturnValueChar;
 
 

When i'm trying to free the dynamically allocated memory, my application crashes and i get the following message "User breakpoint called from code at 0x******". I think this means that some access violation occurs, but i don't understand why

[gpraghuram]

Hello
Could anybody help me?
I have the following piece of code

 
cryptReturnVal = new BYTE[len];//gpraghuram -- if u are allocating memory , then 
char *cryptReturnValueChar;
 
// call decrypt function            
cryptReturnVal=(*decrypt)(input, len, secretKey, ecretKeySize);//gpraghuram--the memory gets overwritten here.[/b]
 
// convert result in hexadecimal format
cryptReturnValueChar = fromCharToHexa(cryptReturnVal, len);
 
m_editOutput.SetWindowText(cryptReturnValueChar);
 
// free memory
delete [] cryptReturnVal;
delete cryptReturnValueChar; // gpraghuram does the memory is allocated to this properly?
 
 

When i'm trying to free the dynamically allocated memory, my application crashes and i get the following message "User breakpoint called from code at 0x******". I think this means that some access violation occurs, but i don't understand why

I have some doubts in the code.....
i have put the name with comment.
This shuld be memory corruption problem, which u shuld debug to find out.

Raghuram

[Dreea]

 
cryptReturnVal = new BYTE[len];
cryptReturnValueChar=new char[2*len+1];
 
// call decrypt function            
cryptReturnVal=(*decrypt)(input, len, secretKey, ecretKeySize);
 
// convert result in hexadecimal format
cryptReturnValueChar = fromCharToHexa(cryptReturnVal, len);
 
m_editOutput.SetWindowText(cryptReturnValueChar);
 
// free memory
delete [] cryptReturnVal;
delete [] cryptReturnValueChar; 
 

In order to avoid the memory being overwritten on line 5, should I comment line 1? I tryied this but the same error occurs. Thanks

[gpraghuram]

 
cryptReturnVal = new BYTE[len];
cryptReturnValueChar=new char[2*len+1];
 
// call decrypt function            
cryptReturnVal=(*decrypt)(input, len, secretKey, ecretKeySize);
 
// convert result in hexadecimal format
cryptReturnValueChar = fromCharToHexa(cryptReturnVal, len);//This is also overwriting the memory u have allocated.
 
m_editOutput.SetWindowText(cryptReturnValueChar);
 
// free memory
delete [] cryptReturnVal;
delete [] cryptReturnValueChar; 
 

In order to avoid the memory being overwritten on line 5, should I comment line 1? I tryied this but the same error occurs. Thanks

Try to comment out the delete one by one and find which delete is causing the issue.Then u can dig there to find the issue.
Raghuram

[weaknessforcats]

This doesn't work:

cryptReturnVal = new BYTE[len];
char *cryptReturnValueChar;

// call decrypt function
cryptReturnVal=(*decrypt)(input, len, secretKey, ecretKeySize);

The return from decrypt is overwriting the address obtained by new just above. Now when you delete cryptReturnVal you will crash.

[Dreea]

Try to comment out the delete one by one and find which delete is causing the issue.Then u can dig there to find the issue.
Raghuram

I already done that and i know that the problem is

delete [] cryptReturnVal;
 

What i find odd, is the fact that the other value has no problem being deletede even though I declare it, I allocate memory for it in the same manner, it is the result of a function and then i try to delete it

// declare variables
char *cryptReturnValueChar;
BYTE *cryptReturnVal;
 
// allocate memory
cryptReturnValueChar=new char[2*len+1];
cryptReturnVal=new BYTE[len];
 
// call crypt function     
cryptReturnVal=(*crypt)(input, len, secretKey, secretKeySize);
cryptReturnValueChar = fromCharToHexa(cryptReturnVal, len);
 
m_edit2.SetWindowText(cryptReturnValueChar);                        
// free memory
delete [] cryptReturnValueChar;
delete [] cryptReturnVal; // here is the problem
 

I understand what you all are saying that the memory is overwritten on line 10, when the crypt function is called, but what do you sugest me to do? I tryed commenting the line in which memory is allocated with new, but this still doesn't solve my problem; i get the same "User breakpoint called from code at 0x****** " error :(

[gpraghuram]

I already done that and i know that the problem is

delete [] cryptReturnVal;
 

What i find odd, is the fact that the other value has no problem being deletede even though I declare it, I allocate memory for it in the same manner, it is the result of a function and then i try to delete it

// declare variables
char *cryptReturnValueChar;
BYTE *cryptReturnVal;
 
// allocate memory
cryptReturnValueChar=new char[2*len+1];
cryptReturnVal=new BYTE[len];
 
// call crypt function     
cryptReturnVal=(*crypt)(input, len, secretKey, secretKeySize);
cryptReturnValueChar = fromCharToHexa(cryptReturnVal, len);
 
m_edit2.SetWindowText(cryptReturnValueChar);                        
// free memory
delete [] cryptReturnValueChar;
delete [] cryptReturnVal; // here is the problem
 

I understand what you all are saying that the memory is overwritten on line 10, when the crypt function is called, but what do you sugest me to do? I tryed commenting the line in which memory is allocated with new, but this still doesn't solve my problem; i get the same "User breakpoint called from code at 0x****** when using delete operator" error :(

Hi,
1)first check what the function pointer call return.
2)Then u can deceide whether u can delete the memory or not.

Raghuram

[Dreea]

Hi,
1)first check what the function pointer call return.
2)Then u can deceide whether u can delete the memory or not.

Raghuram

typedef BYTE* (*DLLCRYPT) (BYTE*, UINT, BYTE*, UINT);
DLLCRYPT crypt;
..............................
crypt = (DLLCRYPT) GetProcAddress(hinstDLL, "crypt");
.................................................................................
cryptReturnVal=(*crypt)(input, len, secretKey, secretKeySize);
 

[gpraghuram]

typedef BYTE* (*DLLCRYPT) (BYTE*, UINT, BYTE*, UINT);
DLLCRYPT crypt;
..............................
crypt = (DLLCRYPT) GetProcAddress(hinstDLL, "crypt");
.................................................................................
cryptReturnVal=(*crypt)(input, len, secretKey, secretKeySize);
 

Hi,
As it is returning a process address, i am very sure that u cant delete the memory.
If u have a memory-corruption identification tool u can use it.
Try Rational-Purify

Raghuram

[icedchicken]

LRESULT CWnd::WindowProc(UINT message, WPARAM wParam, LPARAM lParam)
{
// OnWndMsg does most of the work, except for DefWindowProc call
LRESULT lResult = 0;
if (!OnWndMsg(message, wParam, lParam, &lResult))
lResult = DefWindowProc(message, wParam, lParam);
return lResult;
}

I get a 'User breakpoint called from code at *******' error.

The lResult and the lparam values are both at zero. I am clueless as to how to proceed and will be grateful of any help I can receive.

This is not the only place where I get a 'user breakpoint' in debug mode. I get the same here too:

#ifndef _AFX_NO_DEBUG_CRT
// we remove WM_QUIT because if it is in the queue then the message box
// won't display
MSG msg;
BOOL bQuit = PeekMessage(&msg, NULL, WM_QUIT, WM_QUIT, PM_REMOVE);
BOOL bResult = _CrtDbgReport(_CRT_ASSERT, lpszFileName, nLine, NULL, NULL);
if (bQuit)
PostQuitMessage(msg.wParam);
return bResult;

The bQuit value stands at 0 here.
Help.

[gpraghuram]

It would be better if you create a new thread.
If u are using windows then try heapchk() which will give the heap status.
Introduce this befor and after every function call and find oout where the memory is getting corrupted.


Raghu