not getting the required output

[hpbrothers]

#include<iostream.h>
#include<conio.h>
 
void main()
{
   int a[10],b[10],i,j,k=0,fg=0;
   for(i=0;i<5;i++)
   {
      cout<<"enter no.";
      cin>>a[i];}
      for(i=0;i<5;i++)
      {
         for(j=0;j<5;j++)
         {
            if(a[i]==a[j]&& i!=j)
            {
               fg=1;
               break;
            }
         }
         if(fg==0)
         {
            b[k]=a[i];
            k++;
         }
      }
      for(i=0;i<k;i++)
         cout<<b[i];
      getch();
   }
 

this is the program to remove duplicate values from an array.

if my input is 2,2,3,4,5
then i should get output 3,4,5
but i am getting garbage value

but if i put my input 1,2,3,3,4
then i get the output 1,2,4 which is right

why i am not getting the output in first case.please if the program is wrong then let me know the right program

[ilikepython]

#include<iostream.h>
#include<conio.h>
void main()
{int a[10],b[10],i,j,k=0,fg=0;
for(i=0;i<5;i++)
{cout<<"enter no.";
cin>>a[i];}
for(i=0;i<5;i++)
{for(j=0;j<5;j++)
{if(a[i]==a[j]&& i!=j)
{
fg=1;
break;}}
if(fg==0)
{b[k]=a[i];
k++;}}
for(i=0;i<k;i++)
cout<<b[i];
getch();}



this is the program to remove duplicate values from an array.

if my input is 2,2,3,4,5
then i should get output 3,4,5
but i am getting garbage value

but if i put my input 1,2,3,3,4
then i get the output 1,2,4 which is right

why i am not getting the output in first case.please if the program is wrong then let me know the right program

The first thing I saw is a pile of meesy code. Please indent and use code tags:

#include<iostream.h>
#include<conio.h>
 
void main()
{
    int a[10],b[10],i,j,k=0,fg=0;
    for(i=0;i<5;i++)
    {
        cout<<"enter no.";
        cin>>a[i];
    }
    for(i=0;i<5;i++)
    {
        for(j=0;j<5;j++)
        {
            if(a[i]==a[j]&& i!=j)
            {
                fg=1;
                break;
            }
        }
        if(fg==0)
        {
            b[k]=a[i];
            k++;
        }
    }
    for(i=0;i<k;i++)
        cout<<b[i];
    getch();
}
 

[sicarie]

The first thing I saw is a pile of meesy code. Please indent and use code tags:

#include<iostream.h>
#include<conio.h>
 
void main()
{
    int a[10],b[10],i,j,k=0,fg=0;
    for(i=0;i<5;i++)
    {
        cout<<"enter no.";
        cin>>a[i];
    }
    for(i=0;i<5;i++)
    {
        for(j=0;j<5;j++)
        {
            if(a[i]==a[j]&& i!=j)
            {
                fg=1;
                break;
            }
        }
        if(fg==0)
        {
            b[k]=a[i];
            k++;
        }
    }
    for(i=0;i<k;i++)
        cout<<b[i];
    getch();
}
 

ilikepython-

Did you add a brace in there? I'm missing one, but I might have deleted it when I was trying to figure out the mess of code he made.

[sicarie]

hpbrothers-

You've already been asked by a Mod to use code tags, and now yo uhave by an Expert. I'm making it an official warning - read and follow the Posting Guidelines. If you want to post, you have to play by the rules.

[ilikepython]

ilikepython-

Did you add a brace in there? I'm missing one, but I might have deleted it when I was trying to figure out the mess of code he made.

I don't think so, but I definately might have.

[JosAH]

Shouldn't that variable 'fg' be reset every time the inner loop is started; e.g. insert
'fg= 0;' at line 14 of the code above.

kind regards,

Jos

[ilikepython]

#include<iostream.h>
#include<conio.h>
 
void main()
{
   int a[10],b[10],i,j,k=0,fg=0;
   for(i=0;i<5;i++)
   {
      cout<<"enter no.";
      cin>>a[i];}
      for(i=0;i<5;i++)
      {
         for(j=0;j<5;j++)
         {
            if(a[i]==a[j]&& i!=j)
            {
               fg=1;
               break;
            }
         }
         if(fg==0)
         {
            b[k]=a[i];
            k++;
         }
      }
      for(i=0;i<k;i++)
         cout<<b[i];
      getch();
   }
 

this is the program to remove duplicate values from an array.

if my input is 2,2,3,4,5
then i should get output 3,4,5
but i am getting garbage value

but if i put my input 1,2,3,3,4
then i get the output 1,2,4 which is right

why i am not getting the output in first case.please if the program is wrong then let me know the right program

You never set fg back to 0 when you set it to 1. The program works for me if I add fg = 0; after the first loop:

    for(i=0;i<5;i++)
    {
        fg = 0;
        for(j=0;j<5;j++)
        {
            if(a[i]==a[j]&& i!=j)
            {
               fg=1;
               break;
            }
         }
         if(fg==0)
         {
            b[k]=a[i];
            k++;
         }
      }
 

[ilikepython]

Shouldn't that variable 'fg' be reset every time the inner loop is started; e.g. insert
'fg= 0;' at line 14 of the code above.

kind regards,

Jos

Jos you beat me to it! ;)

[sicarie]

I don't think so, but I definately might have.

Nope, I missed one. Sorry!

[hpbrothers]

You never set fg back to 0 when you set it to 1. The program works for me if I add fg = 0; after the first loop:

    for(i=0;i<5;i++)
    {
        fg = 0;
        for(j=0;j<5;j++)
        {
            if(a[i]==a[j]&& i!=j)
            {
               fg=1;
               break;
            }
         }
         if(fg==0)
         {
            b[k]=a[i];
            k++;
         }
      }
 

thanks it is now working for me also

[JosAH]

Jos you beat me to it! ;)

Man, ain't I fast today ;-)

kind regards,

Jos