string to unsigned char using reinterpret_cast

[richardpeter]

I am attempting to convert a string to unsigned char. The Method I use appears to work but the function call fails.

I am using MSVC++ Express 2.0.50727 on Win XP with an AMD Processor. Forgive me if the following is verbose, however, I am ctumped as to what little element is hindering me so i'll try to be as clear as I can.

The aim of my code is to call an SQL database (MS SQL Server 2005) using ODBC and all works well up until now.

//inside a sqlext.h file there is a typedef of UCHAR
typedef UCHAR   unsigned char
 
//in my main() function
UCHAR SQLstr[128] = "execute stored_procedure_FOOBAR 3, 'spam' "
retcode = SQLPrepare (hStmt, SQLstr, sizeof SQLstr);
if(retcode == something_bad){
     cout << "sqlprepare error \n";
     return 9;
}
retcode = SQLNumResultCols(hStmt, &cols);
if(retcode == something_bad){
     cout<<"SQLNUmResultCols error \n";
     return 9
}
 

(Here hStmt is a handle to the sql statement) However, I now need to concatenate the different sql statement variables together and turn them into UCHAR. To demonstrate this, suppose I have made a string of my SQL statement: stringySQL, exactly the same as the above UCHAR (which works btw) but now a string...

string stringySQL =  "execute stored_procedure_FOOBAR 3, 'spam' ";
char temp[128] ;
strcpy(temp, stringySQL.c_str());
UCHAR SQLstr[128];
strcpy(reinterpret_cast<char*>(SQLstr), temp);
 

This code complies and runs but gives the error "SQLNUmResultCols error". I even tried the following:

UCHAR SQLtemp[128] ="execute stored_procedure_FOOBAR 3, 'spam' ";
//if I now use this it works...but
UCHAR SQLstr[128];
for(i=0;i<128;i++){
     SQLstr[i] = SQLtemp[i] 
}
//if I now use SQLstr it doesn't!
 

If anyone can offer advice it would be greatly appreciated. Rich.

[weaknessforcats]

One question is why the UCHAR? C-strings are CHAR.

Actually, since this is Windows, it should be TCHAR to support ASCSII/UNICODE mappings.

string stringySQL =  "execute stored_procedure_FOOBAR 3, 'spam' ";
char temp[128] ;
strcpy(temp, stringySQL.c_str());
TCHAR SQLstr[128];
strcpy(SQLstr, temp);
cout << SQLstr << endl;
 

[richardpeter]

One question is why the UCHAR? C-strings are CHAR.

Actually, since this is Windows, it should be TCHAR to support ASCSII/UNICODE mappings.

The function SQLPrepare takes UCHAR* as its input argument and did not work when given TCHAR. (even as a whole string, even using reinterpret_cast(UCHAR*)

On the bright side: I have just solved the problem to some, practical, extent. However I am intrigued as to why my solution works, If you want to tell me I would be happy to hear why it works.

      string stringySQL =  "execute stored_procedure_FOOBAR 3, 'spam'";
      char temp[128] ;
      strcpy(temp, stringySQL.c_str());
      UCHAR SQLstr[128] = "______any_length <= length(stringySQL)______";
      strcpy(reinterpret_cast<char*>(SQLstr), temp);
 

Again, many thanks,
Rich

[weaknessforcats]

Is this your SQLPrepare()??

SQLRETURN SQLPrepare(
SQLHSTMT StatementHandle,
SQLCHAR * StatementText,
SQLINTEGER TextLength);

Maybe you could post the function prototype of your SQLPrepare becuse this one has no UCHAR arguiments.

[Banfa]

Is this your SQLPrepare()??


Maybe you could post the function prototype of your SQLPrepare becuse this one has no UCHAR arguiments.

SQLCHAR is a unsigned type (which a suspect UCHAR is too from it's name)

Excert from SQLTYPES.H

typedef unsigned char   SQLCHAR;
 

However richardpeter the point I think weaknessforcats is trying to make is a valid one which is if you are going to call a function, since you are taking the trouble to change the datatype it is probably worth taking to trouble to change the datatype to the one the function is expecting.

[richardpeter]

SQLCHAR is a unsigned type (which a suspect UCHAR is too from it's name)

Excert from SQLTYPES.H

typedef unsigned char   SQLCHAR;
 

However richardpeter the point I think weaknessforcats is trying to make is a valid one which is if you are going to call a function, since you are taking the trouble to change the datatype it is probably worth taking to trouble to change the datatype to the one the function is expecting.

My apologies for the confusion, you are both correct: SQLCHAR is UCHAR which is unsigned char. like Banfa mentions, they both have typedefs located in the headder file sqext.h.

What weaknessforcats said is correct too, however in my program I have to concatenate strings to make my SQL statement and then convert these strings to SQLCHAR or equivalently UCHAR or equivalently unsigned char (they all work).

The code I posted above to do this does work, but I am now more intrigued as to why I have to initialise my UCHAR/SQLCHAR string to something of equal or lesser length than my desired SQL statement?

Many thanks
Rich

[Banfa]

Sounds strange, I would suggest that you use the debugger to examine the exact contents of the sting you pass to SQLPrepare in both the working and non-working case.

[weaknessforcats]

Going back to Post #1:

//inside a sqlext.h file there is a typedef of UCHAR
typedef UCHAR unsigned char

//in my main() function
UCHAR SQLstr[128] = "execute stored_procedure_FOOBAR 3, 'spam' "

The typedef is backwards. It defines UCHAR as an unsigned char but does not define an unsigned char as UCHAR.

I changed the typedef below and looked at the array in the debugger and it is properly initialized.

There should be no need to use a string or a strcpy.

typedef unsigned char UCHAR;
 int main()
{
//in my main() function
UCHAR SQLstr[128] = "execute stored_procedure_FOOBAR 3, 'spam' ";
}
 

However, this code:

retcode = SQLPrepare (hStmt, SQLstr, sizeof SQLstr);

may have a bug in it. sizeof SQLStr is 128 which is the size of the buffer. The SQLPrepare() for ODBC requires the third argument to be the number of characters in the query , in this case 42, and not the size of the buffer.