Please help me in memory corruption

[rasmidas]

I have a function in which memory has been allocated using new and not being deleted. The function is as below:

void AddItem(char* buffer, char* items[], int& index)
{
char* temp = new char[strlen(buffer) + 1];

strcpy(temp, buffer);

items[index] = temp;

index++;
}

This function AddItem() has been called 52 times inside the program.
Then I think this is causing some memory issue or its slowing down the program. Please let me know what corrective action can I take.
Thanks.

[Meetee]

I have a function in which memory has been allocated using new and not being deleted. The function is as below:

void AddItem(char* buffer, char* items[], int& index)
{
char* temp = new char[strlen(buffer) + 1];

strcpy(temp, buffer);

items[index] = temp;

index++;
}

This function AddItem() has been called 52 times inside the program.
Then I think this is causing some memory issue or its slowing down the program. Please let me know what corrective action can I take.
Thanks.

Use this in your function

delete [] temp;

That will solve memory deallocation problem.

Regards

[rasmidas]

Use this in your function

delete [] temp;

That will solve memory deallocation problem.

Regards

But here its copying temp to item[index].
if I will delete temp inside the function it will loose the memory to item[index].
Please let me know.

[Meetee]

But here its copying temp to item[index].
if I will delete temp inside the function it will loose the memory to item[index].
Please let me know.

void AddItem(char* buffer, char* items[], int& index)
{
char* temp = new char[strlen(buffer) + 1];
 
strcpy(temp, buffer);
 
items[index] = temp;
 
index++;
 
delete [] temp;
}

Value of temp is already added in items[index] before deleting temp. So this will not loose any data.

Regards

[weaknessforcats]

This is incorrect:

Value of temp is already added in items[index] before deleting temp. So this will not loose any data.

True, the value of temp is added in items[index]. However, temp is a pointer so all that been added to items[index] is the address inside temp.

Deleting temp inside the function will delete the string pointed at by
items[index] and that can cuase a program crash when items[index] is used by the calling function later on.

To the OP:
Your code looks fine. 52 calls is not an issue. Even if the buffer had thousands of bytes, you wouldn't notice a slowdown. There's something else going on.

One thing that comes to mind is sorting the array of char* by making copies of the strings rather than swapping the pointers. I need to see where you use this items array.

[rasmidas]

Here I am pasting the lines of code where it is calling the AddItem() function.

int PopulateTradeEvents( sDOC_SOURCE* DocSource, char* items[], int& index )
{
   int count = 0;
   int status = sSUCCESS;
   int maxCount = 5;
 
   char buffer[128] = "";
 
   if ( DocSource->Function == sDF_INCEPTION )
   {
      if ( dmgGenTrEvSched( &(DocSource->Trade.Base.Env->cTrEvTerms),
                            &(DocSource->Trade.Base.Env->cTrEvSchd),
                            00 ) == sSUCCESS )
      {
         // GPM 203 RI 247 Additional fields for RT_TERM fields for Swift MT360 message
         if ( DocSource->TradeType == sTT_SWAP )
         {
            for ( count = 0;
                  count < DocSource->Trade.Base.Env->cTrEvTerms.List.ItemsUsed;
                  count++ )
            {
               cTREVTERM* pTrevTerm = (cTREVTERM*)sGetListItem( &DocSource->Trade.Base.Env->cTrEvTerms, count );
               if ( pTrevTerm->EvType == cRT_TERM )
               {
                  char Buf[sMIN_STRING];
 
                  // Calculate Trade Date + Spot for Trade Currency
                  sIDATE TradeSpot = sCcySpotDate( sTradeCcy( &DocSource->Trade, 01 ),
                                                   DocSource->Trade.Base.Env->TradeDate );
 
                  // sIDATE Tenor = pTrevTerm->StartDate - TradeSpot;
                  sprintf( buffer, "TradeEventTerm[%d].SpotTradeDate=<Date>%s;\n",
                                   count, sISybDate( Buf, TradeSpot ) );
                  AddItem( buffer, items, index );
               }
            }
         }
 
         for ( count = 0;
               count < DocSource->Trade.Base.Env->cTrEvSchd.List.ItemsUsed;
               count++ )
         {
            cTREVSCHD* pTrevSched = (cTREVSCHD*)sGetListItem( &DocSource->Trade.Base.Env->cTrEvSchd, count );
 
            char Buf[sMIN_STRING];
 
            sprintf ( buffer, "TradeEventSched[%d].EventType=\"%s\";\n",
                      count, sEditString( NULL, sICEnum( "cTRDEVTYPE",
                                                         pTrevSched->EvType,
                                                         sSHORT_ENUM ), sNO_SPACES ) );
 
            AddItem(buffer, items, index);
 
            sprintf ( buffer, "TradeEventSched[%d].EventDate=<Date>%s;\n",
                      count, sISybDate( Buf, pTrevSched->Date ) );
            AddItem(buffer, items, index);
 
            sprintf ( buffer, "TradeEventSched[%d].NoticeDate=<Date>%s;\n",
                      count, sISybDate( Buf, pTrevSched->NoticeDate ) );
 
            AddItem(buffer, items, index);
 
            sprintf ( buffer, "TradeEventSched[%d].PayDate=<Date>%s;\n",
                      count, sISybDate( Buf, pTrevSched->PayDate ) );
 
            AddItem(buffer, items, index);
 
            sprintf ( buffer, "TradeEventSched[%d].WhoseOpt=\"%s\";\n",
                      count, sEditString( NULL, sICEnum( "cWHOSEOPT",
                                                         pTrevSched->WhoseOpt,
                                                         sSHORT_ENUM ), sNO_SPACES ) );
 
            AddItem(buffer, items, index);
 
 
            // eTrack 3644: Limit size of Sched, otherwise incres will crash
            if ( count == maxCount  )
               break;
         }
      }
      else
      {
         sLogMessage( "Error generating Trade Events for Trade %s",
                      sSERIOUS,
                      0,
                      DocSource->Trade.Base.TradeID.Num );
 
         status = sERROR;
      }
   }
 
   return ( status );
}
 

Please help me, my deliverable is on Friday. Thanks.

[JosAH]

Please help me, my deliverable is on Friday. Thanks.

Is the buffer size large enough? (count carefully) Are there enough slots in the
items[] array?

kind regards,

Jos

[rasmidas]

buffer size is 128.

char buffer[128] = "";

But you asked
Are there enough slots in the items[] array. ??????????????
I am not clear what do you mean by slots in the items[] array?

Thanks

[JosAH]

buffer size is 128.

char buffer[128] = "";

But you asked
Are there enough slots in the items[] array. ??????????????
I am not clear what do you mean by slots in the items[] array?

Thanks

slots == elements, sorry for the alien terminology: how long is that 'items[]'
array? i.e. how many string elements can you store in it? Enough?

kind regards,

Jos

[rasmidas]

#define MAX_ITEMS 1000
char* items[MAX_ITEMS];

That is , it can be at best 1000.
Thanks.

[JosAH]

#define MAX_ITEMS 1000
char* items[MAX_ITEMS];

That is , it can be at best 1000.
Thanks.

What do you see when you print out that 'index' reference parameter in your
AddItem function? (print out the length of the string parameter as well, just to
be sure).

kind regards,

Jos

[weaknessforcats]

Also, your buffer is 128 but you never check the return from any of your
sprintf() calls to see a) there were more than 128 bytes written to the buffer or b) there was a -1 indicating an sprintf() failure.

You might change your buffer size of 128 to something so big you know it's safe and see if your corruption goes away.