how to remove periods , punctuation from cstring

[jerger]

len = strlen(in);
if (in[len-1] == '.')
in = in.TrimRight('.');


you have to declare len, and use cstring for in...

this took me forever lol and its so simple.. i need to set it up for ! points now...

sorry if this is not relevant it took me weeks to figure this out lol and im excited

[jerger]

punk is int, len is int, in is cstring

//punctuation removal
//while loop checks several times to catch all punctuation

while (punk < 10){
len = strlen(in);
if (in.Left(1) == '"')
in = in.TrimLeft('"');

if (in[len-1] == '.')
in = in.TrimRight('.');

if (in[len-1] == '"')
in = in.TrimRight('"');

if (in[len-1] == '!')
in = in.TrimRight('!');

if (in[len-1] == ',')
in = in.TrimRight(',');

if (in[len-1] == '?')
in = in.TrimRight('?');

if (in[len-1] == ':')
in = in.TrimRight(':');

if (in[len-1] == ';')
in = in.TrimRight(';');

punk++;
}
punk = 0;
//end of punctuation check

[jerger]

errr only problem is if i enter like 30 periods it crashes the program 0.o

[weaknessforcats]

Why not just copy the string to a temp and skip the punctuation characters. Then copy the temp back to the original.

??

I mean, you have already done a strlen() so that's the read part of the copy right there.

[jerger]

can you expand on this? i'm a little confused. what do you mean by "skip the punctuation"??? how can i remove it then? thanks!

how can i ignore the chars while making the temp? sounds like a better idea with less if statements

[weaknessforcats]

char str[] = "H%e*llo.(*&"
char temp[100];
 
while (str[i] != '\0')
{
      switch (str[i])
      {
           case '.':
                  break;
           case '&':
                  break;
           case etc... the other puncuation marks
                  break;
           default:
                  temp[i] = str[i];
      }
      ++i;
}
 

When you leave the loop add a \0 to temp and strcpy(temp, str).

[weaknessforcats]

There is also an ispunct() function in stdlib.h that you can use if you want to omit all punctuation instead of specific punctuation.

[jerger]

interesting!!! how could i incorporate that?

well i made a double case statement and it works awesome for now with no memory overflows or crashing:

//punctuation removal
//case statement loops until punctuation is moved
//this prevents error where only one punctuation is fixed and it moves on, this catches quotes and punc."
//default is when input is good/cleaned

len = strlen(in); //sets len as a position for the last letter in



switch (in[0]) //punc removal
{
//case '" (in.Left(1) == '"')
//in = in.TrimLeft('"');

case '!' : in = in.TrimLeft('!');
// break;
case '.' : in = in.TrimLeft('.');
// break;
case '?' : in = in.TrimLeft('?');
// break;
case '"' : in = in.TrimLeft('"');
// break;
case ';' : in = in.TrimLeft(';');
// break;
case ':' : in = in.TrimLeft(':');
// break;
case ',' : in = in.TrimLeft(',');
// break;

default : //break;
len = strlen(in);
switch (in[len -1]){ //punc removal

//case '"' : (in.Left(1) == '"');
//in = in.TrimLeft('"');

case '!' : in = in.TrimRight('!');
// break;
case '.' : in = in.TrimRight('.');
// break;
case '?' : in = in.TrimRight('?');
// break;
case '"' : in = in.TrimRight('"');
// break;
case ';' : in = in.TrimRight(';');
// break;
case ',' : in = in.TrimRight(',');
// break;
case ':' : in = in.TrimRight(':');
// break;
default : //this is like a end loop, once it removes punctuation it moves on

break;
}
}

[JosAH]

You really should have a look at the ispunct() function in ctype.h/cctype. It's as
easy as this:

char* remove_punct(char* dest, char* string) {
 
   char* t;
   for (t= dest; *t= *string++; t+= !ispunct(*t));
   return dest;
}

kind regards,

Jos

[jerger]

how can i make that work with a cstring, and in c++? it currently works pretty well/fast but only for like 8 punctuations