GetOpenFileName() crashes program

[qhimq]

Hi,

I was wondering if anyone encountered the following error with GetOpenFileName().


The open dialog opens, and I hover my mouse over a file. The dialog shows the detailed info of the file like normal. I open my file and everything works as normal. I open the open dialog again. If I hover over any file again, the whole program is closed in a way that does not send any WM_CLOSE messages and not even windows shows up that there was an error.


A weird thing also is that this error only happends on 50% of the computer's i've tried with my program.

Maybe a work around that might work, is if there was a way of turning off the hovering detail display of files.

Ideas, thoughts?

void FileOpen(HWND hwnd)
{
 
    OPENFILENAME ofn;
    char* szFileName=new char[100];
 
    ZeroMemory(&ofn, sizeof(ofn));
    szFileName[0] = 0;
 
    ofn.lStructSize = sizeof(ofn);
    ofn.hwndOwner = 0;
    ofn.lpstrFilter = "DCP Files (*.dcp)\0*.dcp\0All Files (*.*)\0*.*\0\0";
    ofn.lpstrFile = szFileName;
    ofn.nMaxFile = MAX_PATH;
    ofn.Flags = OFN_EXPLORER | OFN_FILEMUSTEXIST | OFN_HIDEREADONLY;
    ofn.lpstrDefExt = "dcp";
 
    bool worked=GetOpenFileName(&ofn);
 
    if(worked)
        FileOpen2(hwnd, szFileName);
}
 

hwnd is the handle to the parent window.

[Banfa]

    char* szFileName=new char[100];
 
    ofn.lpstrFile = szFileName;
    ofn.nMaxFile = MAX_PATH;
 

You have created a buffer for szFileName that is 100 bytes long, however you tell GetOpenFileName that it is MAX_PATH bytes long, on my implementation MAX_PATH is 260 so you are telling GetOpenFileName that szFileName is a buffer that is 160 bytes longer than it actually is.

Either use MAX_PATH where you allocate szFileName or pass the actual size of buffer pointed to by szFileName to GetOpenFileName.

It is always a mistake to information a called function that a buffer is longer than it really is.

[qhimq]

yeah i agree that is a mistake, however its not causing my program to completely close without an error message.