Optimizing code by removing unused lines

[momotaro]

this program is to double space the lines but it works perfectly but there is two "unusfull lines in my point of view since i tried every possible version to see if the any porblem will hapen if omited but there was none...could we just take them out?"

this is the code:

 
#include <stdio.h>
#include <string.h>
 
#define LINE_LEN 80
#define NAME_LEN 40
 
int main(void)
{
   char line[LINE_LEN], inname[NAME_LEN], outname[NAME_LEN];
   FILE *inp,
    *outp;
   char *status;
   int i = 0;
 
   printf("Name of the input file -> ");
   scanf(" %s", inname);
   printf("Name of the output file -> ");
   scanf(" %s", outname);
 
   inp = fopen("inname.txt", "r");
   outp = fopen("outname.txt", "w");
 
   for(status = fgets(line, LINE_LEN, inp);
       status != 0;
    status = fgets(line, LINE_LEN, inp))
    {
       if(line[strlen(line) - 1] == '\n')  //these are two lines.
          line[strlen(line) - 1] = '\0'; //these are two lines.
       fprintf(outp, "%3d>> %s\n\n", ++i, line);
        }
return (0);
}
 

thx!

[ilikepython]

this program is to double space the lines but it works perfectly but there is two "unusfull lines in my point of view since i tried every possible version to see if the any porblem will hapen if omited but there was none...could we just take them out?"

this is the code:

 
#include <stdio.h>
#include <string.h>
 
#define LINE_LEN 80
#define NAME_LEN 40
 
int main(void)
{
   char line[LINE_LEN], inname[NAME_LEN], outname[NAME_LEN];
   FILE *inp,
    *outp;
   char *status;
   int i = 0;
 
   printf("Name of the input file -> ");
   scanf(" %s", inname);
   printf("Name of the output file -> ");
   scanf(" %s", outname);
 
   inp = fopen("inname.txt", "r");
   outp = fopen("outname.txt", "w");
 
   for(status = fgets(line, LINE_LEN, inp);
       status != 0;
    status = fgets(line, LINE_LEN, inp))
    {
       if(line[strlen(line) - 1] == '\n')  //these are two lines.
          line[strlen(line) - 1] = '\0'; //these are two lines.
       fprintf(outp, "%3d>> %s\n\n", ++i, line);
        }
return (0);
}
 

thx!

No, they're not necessary. From cplusplus.com:

char * fgets ( char * str, int num, FILE * stream );

Get string from stream

Reads characters from stream and stores them as a C string into str until (num-1) characters have been read or either a newline or a the End-of-File is reached, whichever comes first.
A newline character makes fgets stop reading, but it is considered a valid character and therefore it is included in the string copied to str.

A null character is automatically appended in str after the characters read to signal the end of the C string.

[momotaro]

Iknow all that but whene I'v omited theme it just work as well???
and if we don't take the two lines out if new line character reached it will be \0\0 at the end of the str am I righbt?
and that also is a waste of cells??

[sicarie]

momotaro-

Please use good thread titles - that's something I would have expected a member with 100+ posts to know....

http://www.thescripts.com/forum/faq....d_thread_title

[JosAH]

The fgets() function appends the \n character in the buffer before terminating it
with a \0 character, so either leave those lines in and print two \n yourself or
remove them and print just one \n character if you want doubly spaced lines.

kind regards,

Jos

[momotaro]

that is an answer !!! thank you!