fscanf not working

[naija]

When i am writing a simple c program-write to a file and read from it,fscanf not working.

#include<stdio.h>
int main()
{
    FILE *ptr,*ptr1;
    int s,r;
    clrscr();
    ptr=fopen("myfile.txt","w");
    do
    {
    scanf("%d",&s);
    fprintf(ptr,"%d",s);
    }while(!feof(stdin));
    fclose(ptr);
    ptr1=fopen("myfile.txt","r");
        while(!feof(ptr1))
    {       
        fscanf(ptr1,"%d",&r);
 
        printf("%d\n",r) ;
                getch();
    }
    fclose(ptr1);
    getch();
    return 0;
}

Please help me to find out the error

[sicarie]

What errors are you getting, besides those not seeing 'getch()' (which is in conio.h, which you dont' include, and shouldn't, but also shouldn't be using getch..., as a personal aside). I would imagine this isn't compiling yet, right?

[weaknessforcats]

Various things not correct. Here is a working version:

#include<stdio.h>
#include<conio.h>
#include<stdlib.h>
int main()
{
FILE *ptr,*ptr1;
int s,r;
system("cls");
//clrscr();
ptr=fopen("C:\\scratch\\instructor\\myfile.txt","w");
while (scanf("%d",&s) != EOF)
{
    fprintf(ptr,"%d ",s);
}
//do
//{
//scanf("%d",&s);
//fprintf(ptr,"%d",s);
//}while(!feof(stdin));
 
fclose(ptr);
ptr1=fopen("myfile.txt","r");
while (fscanf(ptr1,"%d",&r) != EOF)
{
    printf("%d\n",r) ;
}
//while(!feof(ptr1))
//{ 
//fscanf(ptr1,"%d",&r);
 
//printf("%d\n",r) ;
//getch();
//}
fclose(ptr1);
getch();
return 0;
}
 

I did a check for EOF rather than use feof(). You have to check that your scanf() and fscanf() actaully worked.

EOF is CTRL+Z and marks the end of the data stream.

I added a space after the int in fprintf() so that fscanf() could see the individual int values. If you don't do this and write values of 1 2 3, in the disc file will be 123 and that will come back as one int.