ISO C++ Error

[compman9902]

Every time I run the compiler on the proceeding function, I get the following compiler error:
"ISO C++ forbids comparison between pointer and integer" On Line 15.
I am using Bloodshed Dev-C++ 4.9.9.2 on a Windows XP machine with service pack two.
Here is the function:

string sperat(string original)
{
string one;
string two;
char letter;
int positionOne = 0;
int positionTwo = 0;
//End Variables
//!*!*!*!*!*!*!*!*!*!*
//!*!*!*!*!*!*!*!*!*!*
//Begin Function Processes
one = original + " ";
while (positionOne != one.length()) {
    letter = one[positionOne];
    if (letter != " ") {
                        positionOne = positionOne + 1;
    }
    else {
                        one.replace(positionOne, 1, ",");
                        two = two + one;
                        positionOne = positionOne + 1;
    }
}
return two;
}

Thank you for your help.

[niskin]

Every time I run the compiler on the proceeding function, I get the following compiler error:
"ISO C++ forbids comparison between pointer and integer" On Line 15.
I am using Bloodshed Dev-C++ 4.9.9.2 on a Windows XP machine with service pack two.
Here is the function:

string sperat(string original)
{
string one;
string two;
char letter;
int positionOne = 0;
int positionTwo = 0;
//End Variables
//!*!*!*!*!*!*!*!*!*!*
//!*!*!*!*!*!*!*!*!*!*
//Begin Function Processes
one = original + " ";
while (positionOne != one.length()) {
    letter = one[positionOne];
    if (letter != " ") {
                        positionOne = positionOne + 1;
    }
    else {
                        one.replace(positionOne, 1, ",");
                        two = two + one;
                        positionOne = positionOne + 1;
    }
}
return two;
}

Thank you for your help.

Letter is a pointer to one[positionOne] and therefore you are comparing a pointer and an integer.

[weaknessforcats]

It's here:

if (letter != " ") {

letter is a char the " " is a literal using " " means to use the address of the literal.

You should compare a single space to your single char:

if (letter != ' '{
 

Just use single quotes instead of double quotes.

[compman9902]

It's here:


letter is a char the " " is a literal using " " means to use the address of the literal.

You should compare a single space to your single char:

if (letter != ' '{
 

Just use single quotes instead of double quotes.

That is great, It worked perfectly.
But, what is wrong with that function? What I'm trying to do is to replace all of the spaces with a cama.

[weaknessforcats]

There were several things preventing it from working. I did a code-ectomy and reduced it to this:

string sperat(string original)
{
 
unsigned int positionOne = 0;
//End Variables
//!*!*!*!*!*!*!*!*!*!*
//!*!*!*!*!*!*!*!*!*!*
//Begin Function Processes
    while (positionOne <= original.size())
   {
 
    if (original[positionOne] == ' ')
    {
       original[positionOne] = ',';
    }
    ++positionOne;
 
     }
    return original;
}
 

You didn't need two strings. The argument, original, is a copy of the caller's string so you might as well just make the changes there and return a copy to the caller.

Your loop need to run from 0 to original.size(). Hence the <=.

You should use string::size() for the number of characters rather than string::length(). string::length() is deprecated since none of the other STL containers have a length() but they all have a size() for the number of elements in thje container.

Rather than use a replace I just assigned all space element a comma.

[compman9902]

There were several things preventing it from working. I did a code-ectomy and reduced it to this:

string sperat(string original)
{
 
unsigned int positionOne = 0;
//End Variables
//!*!*!*!*!*!*!*!*!*!*
//!*!*!*!*!*!*!*!*!*!*
//Begin Function Processes
    while (positionOne <= original.size())
   {
 
    if (original[positionOne] == ' ')
    {
       original[positionOne] = ',';
    }
    ++positionOne;
 
     }
    return original;
}
 

You didn't need two strings. The argument, original, is a copy of the caller's string so you might as well just make the changes there and return a copy to the caller.

Your loop need to run from 0 to original.size(). Hence the <=.

You should use string::size() for the number of characters rather than string::length(). string::length() is deprecated since none of the other STL containers have a length() but they all have a size() for the number of elements in thje container.

Rather than use a replace I just assigned all space element a comma.

Alright, thank you a lot for all of the effort.
Just one question: what is an unsigned int, and why would you use it?
I've just never had seen that type of variable beofre today.

[weaknessforcats]

An unsigned int is just an integer where the sign bit is part of the integer value. By doing this you can store a number twice as large as can fit in an int but the value must always be positive.

The return from string::size() is an unsigned int. If I assign that to an int, the compiler will give me a warning about truncation and possible loss of data.

[compman9902]

An unsigned int is just an integer where the sign bit is part of the integer value. By doing this you can store a number twice as large as can fit in an int but the value must always be positive.

The return from string::size() is an unsigned int. If I assign that to an int, the compiler will give me a warning about truncation and possible loss of data.

Oh, okay.
Well, thank you for all the help and effort put into this, it has helped me a lot.
Also, I just wanted to say that this website and all of its users are a great help to people like me: barley into their teen years, self taught at programming, and willing to learn.
Thanks.