Is this function correct? please help

[momotaro]

am trying to write the code of a function that search for an employee given its employee id on a binary file that contains only employee structure.
the function displays the corresponding data whene found a "not found" message otherwise.
my struct contains: int id, char *name, double salary, int rank.

void search(FILE *bf, int id){
employee temp;
fb = fopen("fb", "rb");
while(fread(&temp, sizeof(employee), 1, bf)){
if(strcmp(temp.id, id)){
display;
break;
}
else
printf("not found");
}
}
 

thx!

[ssorower]

So what your program does is prints a lot of "Not Found" and finally a "Found" if it gets a match in the file, right?

I am assuming this is problem you are talking about as you didint mention anything.

You see, in the while loop, every time it reads a data from the file, it checks for match. It if matches then it displays that and breaks out of the loop. But if the current data doesnt match? Then it prints "Not found" and moves on to next data from file...that results in printing so many "Not Found".

What you can do is, set a flag (an integer may be) to 0 at the beginning of the function. Then if you find a match then make the flag 1 and break out of the loop as it is now. You can remove the else part now.

Now once you are out of the loop, you can check the value of the flag, if still it is 0, then "Not Found"..otherwise ou have already shown the data.

Hope it helps!
Sorower

[niskin]

fb = fopen("fb", "rb");
 

Not so sure about this line. What is the fb pointing to?